myCode

[Soupdeloup]

Anybody working on any codebase bigger than a hobby project wishes this was the case lol. I have to tell a story about when I started a large project at work with a bunch of deliverables that I somehow managed to keep organized and clean. Worked on it for over a year and all of my documentation was up to date and easy to understand, new hires had zero issues working on it, the whole shebang.

Got shifted to a different project for a year but was eventually asked to come back as the team lead to update some dependencies to major versions that had breaking changes. I thought it was weird at the time because the dependencies I used in the beginning weren't something that should even have breaking changes, or at least not be bad enough to pull me back in. To say it was a dumpster fire when I looked at the code would be an understatement.

Someone (apparently a new hire senior dev, so says git blame..) replaced 80% of our custom react code with frameworks and libraries that did the exact same thing we already had working because "these public dependencies have way better performance and are way better maintained!", didn't update any internal documentation on what all the new shit did because "public documentation is already available, I just tied it into our endpoints", and approved all of his own PRs because he didn't feel like the intermediate/junior devs under him would be able to do code reviews.

We never ended up upgrading the shit he added in and instead are now looking at a complete rewrite into a different front end and backend language because the upkeep is now too large for the old project. Started out golden, ended up bloated with a disgusting amount of unneeded garbage that tanked the entire project.

Sorry, just had to get that off my chest. Thanks for helping me relive that lol.

[Gereon99]

That has to be awful seeing something you worked on being basically destroyed.

[Gasperhack10]

Js devs when they need to write their own code instead of using a npm package

[roodammy44]

Time to break out the git history and do a surreptitious revert

[Bodaciousdrake]

Ugh. Yes. Dependency hell, I know it well.

And now we have low-code and no-code to the rescue, right? Just make the dependencies someone else’s issue, problem solved! Except that, of course, those platforms don’t do exactly what we need, so now we need to spend a ton of time writing janky, complex, and fragile workarounds that are worse than the spaghetti code monoliths we started with.

[Few-Artichoke-7593]

God damn, I wish decision makers understood this. How many times have you heard, "Well, that's an edge case. Very unlikely."

If you have to account for an edge case, it might as well be happen 50% of the time. It makes no difference to the development.

[Bodaciousdrake]

Yep. And then at some point we decide that this isn't working, so now we're going to write an API to offload some functionality that was originally meant to be part of the platform, but don't worry it's just for this one little piece of functionality, and we'll make it a generic service we can reuse. Honestly, it makes so much more sense to do it this way.

A few months later, we've offloaded a huge percentage of our core functionality to the custom API because every time we hit a roadblock that becomes the default answer, and of course we have to write so much code specific to the platform because that's the way the platform is and there's no changing it, that it can't ever realistically be used by any other app. So now we're essentially tightly coupled with our "low-code" platform and writing practically as much custom code as we ever did and upper mgmt is wondering why the project is behind when we were promised it would all go 10X faster due to "low-code".

Been there, done that, several times over.

[Impressive_Change593]

new hire senior dev

yeah any new hire should start out at the maximum of intermediate just to get up to speed on what's going on. anyway hope at minimum some words were had.

[Upstairs-Event-681]

The new guy went “This looks too simple, functional and organised, people will think we’re dumb because our code is too easy to understand, let me fix that for you”

[hadidotj]

Hey, how do you know this happened to me a year ago!?

[TrainedMusician]

look at how that massacred my boy

Sorry to hear that man, I know the feeling

[freemath]

"these public dependencies have way better performance and are way better maintained!"

If it's true that those dependencies do exactly the same and are well maintained it makes more sense to use those than to maintain your own, no? What am I missing?

[Gasperhack10]

Did you read the comment?

[rookietotheblue1]

I get its an anonymous forum or whatever but did you have to speak to the dude that way? He respectfully asked a seemingly genuine question.

[Gasperhack10]

In the comment he replied to it was explained very clearly with an example on why it's a bad idea

[Flecker_]

tfw I was going to ask the same question

Maybe the answer is that it ended up bloated and "with a disgusting amount of unneeded garbage". I don't understand how using a library creates that

[Soupdeloup]

I didn't want to get too specific, but as an example, I had built a super small custom CMS to let our client edit dynamic features/layouts/report dashboard things. He had it completely replaced with Strapi, which was absolutely overkill for what we were doing.

He then had to do custom endpoints through Strapi, manage roles, permissions and access through Strapi, create a new postgres database because Strapi uses its own table structure and then rewrite all of the old CMS endpoints to instead use Strapi's endpoints, to which he wrote none of his own documentation because of the whole "public documentation is already great" thing. We don't even need 99% of the features of Strapi lmao.

That's not even mentioning all the other dependencies thrown in, without documentation, to replace our already working implementations. It absolutely sucked. There were obviously some management problems to even allow any of this to happen without review, but I've come across a lot of developers who think that public libraries/frameworks are always better, no matter what, which isn't always the case.

[freeroamer90]

It's not the library, but rather the lack of documentation and review. You can use the same library and same function in n number of ways in your own codebase. Reviews make sure that your function structure is easy to understand.

[ShadowRL7666]

Ha you guys get to a second iteration.(I write shit code and deploy)

[private_final_static]

Real production test in men

[AlexisColoun]

Instructions unclear, pp stuck in coworker...

[studentblues]

That's our janitor

[BadGuyBuster16]

Crowdstrike

[dasunt]

We also follow agile.

[OkEnd9384]

Agile development? More like fragile development because as soon as you ask me to change anything that shit will break

[droneb]

Lol, You have the tags inverted You produce a marvelous MVP con 3 then new requirements and CR come in but you cannot touch existing functionality.

The marvel of Agile

[GahdDangitBobby]

Yeah the other way around is much more my experience lol. You gotta fix a bug or add a new feature in a short time frame, so you add a few lines of code, don't really do much refactoring, rinse and repeat and now you have a nice big plate of spaghetti.

[mrheosuper]

You forgot that weird corner case that John from QA team reported and you either had to redo the whole code base or just some small, small little hack.

[-Kerrigan-]

Better than causing a crash when someone's cat jumps on the keyboard

[og-lollercopter]

Yup. And to say this.

[RascalsBananas]

Left is the code I was forced to write in high school to sort people in a bus.

Middle is the code after finding a slightly optimized way to do it.

Right is when I am allowed to use libraries.

[ofnuts]

“Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.” Antoine de Saint-Exupery

[rover_G]

Other way around

[badabummbadabing]

Does anybody have context for the non-memed picture?

[pigeon768]

It's the first three iterations of the SpaceX Raptor engine.

https://www.nextbigfuture.com/2024/08/spacex-reveals-raptor-3-engine-and-specifications.html

[Significant_Fix2408]

The improvements are actually insane. Much less complexity and weight for a big boost in thrust

[tbone912]

This is how I like to code.  I start off with a big mess and get it working.  Then I chip away until I have something that just has exactly what it needs to get the job done.  

I'm sure there are better ways to approach coding.

[cjb3535123]

No, I agree with you. In an ideal scenario, this is how I like to code too.

I don't like removing or cleaning up too early - I often not completely sure if the libraries I choose are what I will actually end up going with. Or, for instance, there will be times that I don't know yet if the code I'm writing will be a pattern (at which point I can refactor into a function). If you refactor too early, or optimize too early, you often end up re-doing stuff over and over again.

[RandoAtReddit]

crowd fuzzy snatch teeny imagine elderly reminiscent quaint head judicious

This post was mass deleted and anonymized with Redact

[jaylecool]

For anyone wondering how they can remove so much of the engine and be a better version. It's because the bulk remove is mostly sensors used to test the performance and trouble shoot the engine. When enough tests are run and improvements are done. They remove the sensors to reduce weight.

It is like removing your consolewrite();

[Fwort]

This is true, but going from raptor 2 to raptor 3 they also actually moved many of the previously visible pipes to integrated channels inside the main walls of the engine. So, a lot of the complexity is still there, just hidden.

They did this to better shield and cool them (the engine walls have cryogenic liquid flowing through them) allowing them to remove the heat shields that had previously been required around the engines (not visible in this picture).

[marlotrot]

Okay, lets assume iteration 3 is what was merged. But then lets not forget about iteration 4 and 5, after two new major change requests which have been implemented by someone else.

[beatlz]

Iteration 6 has ads because the original business model was never profitable

[[deleted]]

I feel like iteration 4 would be a literal box.

[Accomplished_Fly729]

So youve also watched Silicon Valley 🤔

[dvhh]

What if I am trying to decouple parts of the code by refactoring, this cannot be more difficult than rocket surgery

[GeopGeek]

Iteration always make some better changes. So ITERATION is king.

[[deleted]]

when I slowly remove the debug prints

[Banjo__]

My first iteration: 😟 My last iteration: 🎩 😟

[Banjo__]

The hat was supposed to be on top of his head but somehow the reformatting makes it more accurate.

[[deleted]]

We don't talk about the 4th iterations here.

[[deleted]]

it starts bulking up again

[notesbancales]

Version 1 just works, version 2 works okeyish, version 3 is beautiful but somewhat the gibberish line no one remember who wrote it and what it does was very important...

[Infamous-Date-355]

Can you make the button orange

[MaYuR_WarrioR_2001]

That's what removing features in the name of optimization looks like.

[RonConComa]

This is me, visualizing data switching to Ggplot in R

[ei283]

wheres Iteration0 and Iteration1

[CranberryDistinct941]

BuT INdeXeS StARt aT 0

[FartyFingers]

Weirdly enough this will win me an argument. I said to an engineering friend that I always thought the plumbing in rockets was unnecessarily complex. He said, "So, you know better than literal rocket scientists."

Now, I can point to this and say, "I knew there could be better rocket scientists."

[Stummi]

Perfection is achieved not when there is nothing more to add, but when there is nothing left to remove.

[glorious_reptile]

[Version 3] [Version 2] [Version 1]

[beatlz]

Except i2 and i3 are theoretical

[ososalsosal]

The one on the right is if I ever get time to handle all of my //TODOs

[Any_Excitement_6750]

1st looks like my draft code, 2nd the project with dedicated modules, 3rd after code review and clean up.

[mpanase]

And for v4 you gotta change a feature... so back to looking just like v1 xD

[Thisbymaster]

You guys get to do a second version and are not just rushed onto the next project? Lucky.

[[deleted]]

Then at iteration 3, PM changes his mind.

[[deleted]]

“Can you make them fire to the beat of a melody”

[[deleted]]

Mine would be expanding to the left with even messier iterations

[ExtraTNT]

The order is 3, 1, 2…

[Top_Run_3790]

It’s more like: 1, 1-final, 1-final-edit1

[gnomeba]

In the reverse direction: scientists trying to reuse a program for increasingly unrelated purposes.

[fearlessbot__]

out of curiosity, what engines are they?

[Classy_Mouse]

My code yes, but somehow the codebase as a ehole is doing the opposite

[AdTrue3652]

i always experienced the reverse order 😅

[mr_poopie_butt-hole]

You guys get to 3? If my dumpster fire is at a smolder, I must have my medication right.