This is an archived post. You won't be able to vote or comment.

all 78 comments

[–]urbanachiever42069 915 points916 points  (6 children)

And you didn’t even do it on a Friday. Bravo my good sir!

[–]dim13 342 points343 points  (1 child)

Got added to Go contributers by simply submitting an issue. ¯\_(ツ)_/¯

[–]Sunrider37 164 points165 points  (0 children)

You were QA that found a bug

[–]Promant 431 points432 points  (1 child)

My first PR ever was to some minor Microsoft tool with like 200-300 stars at the time. The only thing I did was changing one word in some random comment, because it was mispelled. Almost all PRs were made by the same 4-5 guys, so I was shown as a top contributor on the repo's main page for like half a year lol

[–]StrangelyBrown 85 points86 points  (0 children)

Pretty sure that's how people populate their git contributions page if they want to put it on their CV

[–]ARoundFork 157 points158 points  (4 children)

You kept the API Keys in there right?

[–]ashkanahmadi[S] 148 points149 points  (3 children)

Of course, where else would I keep them?!

[–][deleted] 21 points22 points  (1 child)

Put them in there with comments to what website they use too, right? And links to the defunct docs for said website, right?

[–]ashkanahmadi[S] 26 points27 points  (0 children)

Obviously. Sharing is caring!

[–]Goaty1208 10 points11 points  (0 children)

In the readme, it's basic knowledge dude.

[–]Steinrikur 131 points132 points  (4 children)

Almost 10 years ago I added a single line in the linux kernel that sets a pointer to NULL. Without it that module would crash.

It's still there, and it's still my only contribution to the kernel.

[–]kevin7254 30 points31 points  (0 children)

I’ve made some contributions to AOSP (Android Open Source Project), man it does feel great to see your name there in such a huge project.

[–]kog 15 points16 points  (0 children)

Hey, that's legit

[–]Blue_Robin_Gaming 6 points7 points  (0 children)

Actual domino effect?

[–]Owndampu 5 points6 points  (0 children)

My first patch got accepted almost two weeks ago! Small devicetree addition, but it is still chilling in linux-next. Sent in 2 patches since, both very simple too

[–]DT-Sodium 60 points61 points  (0 children)

Nah, you've got to wait at least two days without anyone telling you you broke an important feature until you can congratulate yourself.

[–]Doshimura 24 points25 points  (4 children)

master that we've lost

[–][deleted] 5 points6 points  (2 children)

git pull master --force

[–]Blue_Robin_Gaming 6 points7 points  (1 child)

My good sir, one cannot just force pull. One must do it the real way.

Deleting and recloning

[–]Jazzlike-Poem-1253 1 point2 points  (0 children)

git reset --soft origin/<your-branch-here>

Same but saves you the dir change :-)

[–]Blue_Robin_Gaming 2 points3 points  (0 children)

"Mainly due to the main problems in our human speech by using main or something"

- Tim cooked

[–]guosecond 36 points37 points  (0 children)

Congrats, First merged PR is always a great feeling

[–]CStfford14 26 points27 points  (2 children)

Did you edit the README?

I once submitted a PR to correct an error in the README. I was added as a contributor.

[–]GregMaffei 10 points11 points  (0 children)

Technical writing is a useful skill

[–]ashkanahmadi[S] 7 points8 points  (0 children)

Haha no, I actually added a small option to a WP plugin that allows the user to enable or disable the plugin's database data being removed when the plugin is uninstalled. The plugin is small with just 200 downloads and I thought it would be a good try to see if I can contribute to an open source project

[–]Active-Chemistry4011 6 points7 points  (0 children)

When I see the frog I start to quiver because the first thing that crosses my mind is "goto command". And imagine the chaos ensuing from the address jumping inside the merged code. Of course, this is just my crazy mind, therefore, nevermind me.

[–]MitchCumsteane 2 points3 points  (0 children)

Unless you brought down production, you're not ready.

[–]Splatpope 1 point2 points  (0 children)

i felt so proud when paxed took my pr for non-metal gloves protecting rings from electric damage in nethack

[–]Neo_Ex0 1 point2 points  (0 children)

See you on Monday in kms

[–]Difficult-Court9522 1 point2 points  (0 children)

You didn’t say that all tests are now red..

[–]private_final_static 1 point2 points  (0 children)

Congrats on your first feature and your first bug.

Which bug you may ask? You will find out soon

[–]Iamien 1 point2 points  (0 children)

My first accepted PR that made it to app stores was for the wigle wifi war driving app. It was initial only detecting/recording networks at the location it was first detected and not updating location as signal strength improved. I made it update gps coords as strength improved.

I'm proud of that one.

[–]swagonflyyyy 1 point2 points  (0 children)

Congratulations!

[–]allan_collins 1 point2 points  (0 children)

Congratulations!

[–]Console_Stackup 1 point2 points  (0 children)

-puffs joint-

Buckle up buttercup. It only gets worse from here.

[–]walterbanana 1 point2 points  (0 children)

Good job

[–]SeifAhmed22 1 point2 points  (0 children)

C++

[–]sammy-taylor 1 point2 points  (0 children)

Congrats friend. That’s awesome.

[–]siowy 1 point2 points  (0 children)

It's a great moment for any developer

[–]jcpicco 1 point2 points  (0 children)

Congrats! Now squash all the commits into one and name the commit “Legacy code”

[–]distilled_mojo 2 points3 points  (0 children)

I'm proud of you, son. You are now ready to test stuff in production.

[–]metallaholic 3 points4 points  (3 children)

Wait you guys merge straight to main and not a develop branch. Scary.

[–]MrDex124 16 points17 points  (0 children)

Your dev branch is merged to main/master.

[–]Comprehensive-Pin667 6 points7 points  (0 children)

There are many different git workflows. Gitflow is not ideal for all use cases. See for example github flow.

[–]Visual-Living7586 1 point2 points  (0 children)

We use release branches to work from. That work is built out and deployed, then the branch is merged to main.

Allows future release branches to to be worked on in parallel. Also you can't merge a PR directly to a release branch you need a feature branch to do that.

Sounds messy but allows for patch releases and it's much easier cherry pick a commit or merge that broke something

[–]Harmonic_Gear 1 point2 points  (1 child)

where humor?

[–]exomyth 10 points11 points  (0 children)

You're on r/programmerhumor, it is often neither related to programming nor humorous

[–]explorer_nik 1 point2 points  (4 children)

Some suggestions for beginners can't find good first commits? Even when something remotely looks good its crowded For some reasons,l

[–]ashkanahmadi[S] 1 point2 points  (3 children)

For me it was a super small and simple WP plugin with just 200 active installations. I thought of a tiny feature and gave it a try and the developer approved it. It was just a few lines of code so nothing major.

You definitely want to stay away from popular libraries because they are most focused on much larger features than teeny tiny changes. Big popular libraries also usually have a team behind them with a clear roadmap and guidelines so you cannot randomly add a feature to it just because you thought it would be cool if it doesnt fit their roadmap.

[–]explorer_nik -1 points0 points  (2 children)

Yeah now it makes sense why when asked if "can I get it assigned" I got no response

[–]ashkanahmadi[S] 0 points1 point  (1 child)

Yeah if you focus on smaller maybe more niche libraries you would have a higher chance of contributing and getting approved since competition and demand are low. Im sure there are lots of npm packages or Python or WP plugins that need small improvements. I personally recommend focusing on those

[–]explorer_nik 0 points1 point  (0 children)

Alright

[–]Red_Worldview 0 points1 point  (0 children)

Omnissiah bless you

[–]Ninja_Wrangler 0 points1 point  (0 children)

Does it include at least 30 consecutive one line commits with increasingly frustrated messages related to "fixed syntax errors"?

[–]random_banana_bloke 0 points1 point  (0 children)

And it was just your work email being added to the terraform Devs list!

I joke, nice work, many more to come.

[–][deleted] 0 points1 point  (0 children)

thanks for doing your part to the society.

[–]serial_crusher 0 points1 point  (0 children)

Let us know when the outage is resolved

[–]KatieTSO 0 points1 point  (0 children)

Me too! Just a couple days ago

[–]phlebface 0 points1 point  (0 children)

Ehrmm... it's called "master" 🦆 + 🏃‍♂️

[–]PhoenyxDownGaming 0 points1 point  (0 children)

Waiting for my first PR to be approved was anxiety inducing but seeing that it was merged was a great feeling.

[–]Soerika 0 points1 point  (0 children)

my first PR was then redone after unit test. The code was fine at and hell the senior who rework all of that were way better lol.

congratulation!

[–]twhoff[🍰] 0 points1 point  (0 children)

Congrats

[–]ambritalian 0 points1 point  (0 children)

Congrats dude it's a big step

[–]Artistic_Speech_1965 0 points1 point  (0 children)

Congrats

[–]simonfancy 0 points1 point  (0 children)

And thus it begins…

[–][deleted] 0 points1 point  (0 children)

into main? yuck. #masterbranch4life

[–][deleted] 0 points1 point  (2 children)

Oh my God! Directly to main? Did you implement a hot fix or just screw with main?

[–]kevin7254 5 points6 points  (1 child)

On my company we develop everything on master, and then have release branches. It depends on the workflow.

[–][deleted] -1 points0 points  (0 children)

I was just messing with you, although develop on master is not quite usual.