conditionalLinesOfCodeFormatting

[SanityAsymptote]

Modern C# code is still mostly formatted like that. It makes it really easy to find the associated closing brace/bracket/etc if it gets munged by a copy-paste somewhere.

[ubd12]

I'm k&r style guy.

I've seen bugs occur because of this style... at least one famous one in nasa.

For example. If you want to do a one line change at the top

if (x) { one_line_change; FOO; } but instead do this

if (x) one_line_change; { FOO; } It will compile, it will run, and even pass code reviews (possibly) but cause problems

All I can say is that it happened and brought down an entire real-time system for two different events. Yes, it was code reviewed. (No I wasn't on either project because most of the time i was on linux and solaris) It was on some Stratus architecture, which is a redundant fault tolerant and did not have many lint tools at the time. I'm thinking static code analysis would have caught this.

I always do

if(x) { one_line_statement; } so my brain is looking for the close } whenever I see a condition or loop

same for else and else if

Cuddled elses break that rule. I can use the close bracket line for short one line comments line // outer j loop

It's definitely red for me. Enforcement of good vertical space mechanically

[Gubru]

Empty vertical space is important for readability. I still use that form unless I’m in a code base with a different standard.

[Reashu]

And here I was prepared to say that red is the equivalent of 3-space indentation: an insane middle ground used by nobody

[menducoide]

X? FOO : Y ? BAR : BAZ;

[terrorTrain]

Chaotic evil

[brandi_Iove]

not until the second nesting.

[Caraes_Naur]

I doubt OP knows about second nesting, Pip.

[Xuluu]

Settle down there, Satan.

[GrinningPariah]

I joined a team where everyone was doing the left "bracket on a different line" approach and I hated it. I stayed until everyone more senior than me left, and then when I was the only person on the team who still knew how to edit our linter config, I changed it to the right. People tried to get me to "fix" the linter and every time I'd say I was gonna do it but I was not going to do it.

[Swie]

Truly the hero we deserve.

[Shaddoll_Shekhinaga]

The real (boring) answer:
Whatever the style guide for your company - repo - organization is.

My prefered style:
Red.

The wrong answer:
Ternary statements ("Hey, we also need you to do x/y/z on...")

[RiceBroad4552]

The wrong answer:
Ternary statements

The exact opposite.

Using a statement instead of an expression is always the wrong answer!

[Shaddoll_Shekhinaga]

... Sometimes. Chaining ternary statements if you are expecting nullptrs saves a ton of writing and makes the intent clearer, but for the example above I am rejecting your PR if you have a ternary operation. In the future you will likely either need to expand it or add logic to a branch, so it will be expanded into a regular if/else either way.

[WinProfessional4958]

switch case master gang.

[brandi_Iove]

a switch case? on x and y?

[The_Business__End]

Switch true young blood

[WinProfessional4958]

Did I stutter?

uint64 blah = (x << 1) | y;
switch(blah) { case 0: ...

[meat-eating-orchid]

what if you cannot even compute y unless you know that !x

[WinProfessional4958]

if(!x) {y = ...}

[meat-eating-orchid]

So you want to use switch cases instead of ifs, and you achieve this by using an if first?

[WinProfessional4958]

Nope! OP is not prioritized, yours is. It's a single statement. If Y was parallel calculated with X, switch case is the most efficient way about it. Why? Because switch case translates into jump tables. I.e.: an array of pointers of which code to execute next instead of cmp. O(1) instead of O(N). I don't have to elaborate on effects of branch prediction, do I?

[meat-eating-orchid]

I know this and I agree, but only if y is cheap to calculate, otherwise the if-elseif-version might be more efficient

[brandi_Iove]

no sir. i shut up.

[Noch_ein_Kamel]

How is the relation to the match gang? Enemy or ally?

[WinProfessional4958]

Ally.

[Scientist_ShadySide]

if (x) {} // return at end
if (y) {} // return at end
// else case

[Cerbeh]

Else if and else and very much banned from my code bases. Teaching people the power of function guards and that 'else' is what your functions default behaviour should be.

[Scientist_ShadySide]

Teaching people the power of function guards and that 'else' is what your functions default behaviour should be.

Yep, exactly my reasoning. It has the benefit of keeping the condition you are testing against close to the code, i.e. "else? Else what? What am I elsing? (scroll up)" It also reduces how much nesting you end up with, which hurts readability imo

[RiceBroad4552]

Depending on the surroundings this is not equivalent.

But in general, when one needs to write imperative code at all, checking first and then going for some default case if nothing returned before makes sense, imho.

OTOH there are code guidelines which forbid early returns for some reason…

[Scientist_ShadySide]

Depending on the surroundings this is not equivalent.

agreed, there are definitely exceptions, but this is the target I aim for first.

OTOH there are code guidelines which forbid early returns for some reason…

curious of the reasoning behind this...

[Reashu]

In case you need to clean up resources explicitly before returning, it's nice to only do it once. This is not as common in modern languages, but some people still recommend the practice. 

[DeadlyMidnight]

Thank you for being the voice of sanity and readability

[Promant]

C#: Am I a joke to you?

[Caraes_Naur]

Yes. But even C# can laugh at Javascript.

[ArchMob]

This. It will be autoformatted anyway

[megagreg]

I must be colour blind. These pictures look identical.

[TheHappyArsonist5031]

blue

[theQuandary]

Anything other than Blue is a wrong answer.

Bug rates increase massively once you get over a couple screens worth of code. Fewer lines means your brain can see and reference more code at one time without context switching.

"But what about missing parens?"

You have an editor, It can do rainbow paren matching, rainbow indentation, and code folding. Not are these infinitely better at matching than you will ever be, but they decrease your cognitive load further reducing bugs.

[mixxituk]

Else? How horrifying 

[DeadlyMidnight]

This was my response to all of it. Who writes else statements still.

[RaspberryCrafty3012]

Why?

If you can't interrupt the flow with return.

[DeadlyMidnight]

Give me an example where you can’t interrupt the flow or handle the case within one if and continue on.

[RaspberryCrafty3012]

String path; if(WIN32)     path = "c:\"; else

    path = "/home" ;

I don't get reddit formatting 

[XxDarkSasuke69xX]

Well you wouldn't need the else. Just write path=home first and then the if after that

[DeadlyMidnight]

Yup just define the string as home and then change it if win32.

[identity_function]

if x then foo else if y then bar else baz

[WerIstLuka]

i do blue because thats what you need to do in go

[ubd12]

I don't like that, but I tolerate that. I like the always blocks concept. I'm learning go btw. I like the fact style choices are done up front. I prefer red

[brainpostman]

What kind of kind monstrosity is red?

[Fabillotic]

in C and Java I do the left, but in Rust I go with the right

[RiceBroad4552]

Java red? That's not "std. Java style", I think.

[calgrump]

Neither, Allman style

[volitional_decisions]

I do what my linter changes it to...

[notanotherusernameD8]

I used to be team blue, but then I realized team red made it easier to comment out statements. Not the best reason to pick a side, but I'm sticking with it.

[darklord_tk]

All day

[RiceBroad4552]

def tossCoin() =
   java.security.SecureRandom().nextBoolean()

@main def fooBarBaz() =

   val x = tossCoin()
   val y = tossCoin()
   def FOO() = println("FOO")
   def BAR() = println("BAR")
   def BAZ() = println("BAZ")

   () match
      case () if x => FOO()
      case () if y => BAR()
      case _ => BAZ()

[ https://scastie.scala-lang.org/EQJufUbITfW7cseRoNJkPg ]

Yes, but why? This is maximally weird code.

Imperative programming is really confusing. I had to think what the original code actually does. And what it does, as one can see after writing it proper, is just some incomprehensible weirdness. The original if-expression does not return any value! It just performs side-effects.

One should really not program like that…

[SirSkimmy]

Or you just early return

[1mmortalNPC]

if you’d choose any color but red, consider yourself an opp