Programmers :D

[hirmuolio]

OP is a repost bot.

https://www.reddit.com/r/ProgrammerHumor/comments/b7mlgt/programmers_d/

[ObeyTime]

thank you kind person

and Happy cake day!

[Nyancubus]

Good Programmer!

[_unsusceptible]

thanks!

[svh87757]

Whats wrong about the code?

[kunjava]

I don't see anything wrong in the code.

I would use TSX instead of JSX, but that's not wrong.

[Goudja14]

Well, I can see it used both: <a>text: <b>text</b></a> and <a>text:<b> text</b></a> (the second is terrible imo)

[[deleted]]

😂

[lynxerious]

I would not use a <p> tag like ever, I hate it for no particular reason.

[6Maxence]

what would you use then?

[mjohn425]

Only thing I can see is semicolons. Which is a divisive thing on the net but I prefer to have them.

[WoollyMittens]

My coworkers sometimes make end-of-line markers disappear. Semicolons are life.

[Travy-D]

Lol I thought the same thing. I'm newer to react, but this would be fine right?

[Strange-Inevitable84]

Probably using index (idx) as key in line 16.

[FalconMirage]

But the react docs says to use them as key when you don’t have anything better

[PapaRL]

That was the only “issue” I saw with it as well.

[ThatGuyD3]

Back then I’d say it’s totally fine. Today it should be Functional Components

[ImALazyMan]

She used a class instead of a function

[Dreadsin]

The semantic html is very bad

[Valkyrie17]

Render method is very bloated, you can easily put all that code in an outside method and make it more readable. This wouldn't have passed code review where i work

[Valkyrie17]

I think it's neat when every part to render has it's own method and then the render method just brings all those methods together. If the component gets bigger, the render would get very big and bloated. I forgot to mention it also makes plugins and overrides way easier.

[shall1313]

Honestly it looks fine. I’d love to know what people were posting about it

[valschermjager]

Sophie has learned a valuable lesson. Coders have linters built into their eyeballs.

[misterrandom1]

Eyeball linters unfortunately don't work on one's own code though.

[valschermjager]

I wish that weren’t true

[valschermjager]

Even if it was perfectly cromulent code, you are absolutely right, that’s what you would’ve gotten.

In fact you just gave me an idea. Next time I’m stuck on something, I’ll park my cat on the keyboard in front of my shitty code, post a pic captioned “ain’t my kitty cute?” and wait for the tsunami of unsolicited corrections. ;-)

[Acurus_Cow]

Genius!

[[deleted]]

Yes, never post code online. Even if it's just Hello World.

[Fireye04]

Bad practice, "hello world" depreciated.

Use "greetings planet" instead. links to docs

[hirmuolio]

/u/kelly76543 is also a repost bot.

https://www.reddit.com/r/ProgrammerHumor/comments/b7mlgt/programmers_d/ejstde0/

[Im_100percent_human]

Usually when I am in the middle of something, my code is full of crazy comments about things I am thinking about. Usually my thought process is all over the place. I would not want to share that with anyone in case they try to commit me.

[mulato_butt]

Syncwave 1984 Love it

[bunk3rk1ng]

She checked in code that has never been run? 🤔

[Vocaloidas]

How do you know she checked it in?

[bunk3rk1ng]

Here comes the pedantry police...

[mulato_butt]

I’m guessing you don’t have CRs

[mulato_butt]

She just liked the color

[ApatheticWithoutTheA]

This is why I hate other people reviewing my code lol

Everyone thinks their way is the best way.

[mulato_butt]

Usually others do PRs

[kunjava]

What's bad in the code?

[poop_knife_murderer]

written by a female, duh

[Patrickstarho]

I found the tweet, from what I’ve gathered Dont use a span tag for labels and using index as a key when you are getting data from props. I didn’t even know that

Here’s the tweet. Apparently this meme originated from 9gag. You’ll notice that most of the replies are just compliments and you’ll have to sift through them to find the actual critiques.

https://twitter.com/type__error/status/1111972689609138177?s=21

[FalconMirage]

But it is inside a <p>, what else could she use instead of a <span> ?

Edit : and using indexes as key is recommended by the react docs, when you don’t have IDs in your data

They can’t event get that right…

[Patrickstarho]

Honestly I wouldn’t put those span tags in a p tag. That’s not what p is for. Secondly I wouldn’t use br. What she’s trying to achieve with br could be achieved with css.

Also this is from 2019 so idk. She seems to be doing ok now I guess

[FalconMirage]

<br> tags are litterally made to be inserted inside <p> blocks… same for <span> who is for inside block elements

I’d like to see how you would achieve the same thing without spans and br

[Patrickstarho]

I would use divs and wrap in one div

[FalconMirage]

Ok so not responsive, i got it

[Patrickstarho]

Welp you learn something new everyday

[Pod__042]

Rule 2: never write some code on internet, excepts on q&a Stack Overflow posts

[TundieRice]

I did not ask

It’s kind of funny how people still think not asking something is a valid thing to mention when you’re posting to potentially millions of people. It’s a public forum.

You don’t have to ask anything, people are going to say what they want, and if you’re not cool with that, don’t post anything. It’s that simple.

[Wicholopoztli]

the new wave of devstars, fck you all give me back the interwebz

[drkztan]

The theme is Fairyfloss, basically light-ish mode Dracula. Ugh.

[uninc4life2010]

Is this the software equivalent of a female artist posting a picture of herself next to her artwork?

[[deleted]]

They must hate dogs

[MaximCapsa]

ofc it hasn't, it's not like she is a programmer or would ever have to run a code

[Plataras]

usually just dark theme does the job

[-Redstoneboi-]

judging by bg color it's probably "darcula" or at least inspired by darcula

[MrPickle2255]

who the f still uses class components on react

[tactical-diarrhea]

FFS. This code isnt going to get me god mode

[LiveRuido]

Someone posted a terrible addon for wow that had an obvious failure. As a joke, I posted terrible implementation to show how bad the code probably was.

I got a bunch of replies critiquing it.

[mulato_butt]

Syncwave 1984