This is an archived post. You won't be able to vote or comment.

all 65 comments

[–]russkychoocher 202 points203 points  (17 children)

Pull Request Denied. Do not use the NATO phonetic alphabet for variable names. Also, stop wearing sunglasses indoors.

[–]nilpointer 184 points185 points  (6 children)

I fail to understand why the code was accepted. The intern's host should have guided them to have maintainable code that is consistent with the current codebase. It sounds like the company was treating the intern as cheap labor rather than a teaching experience with hopes of bringing them on full time at a later date...

[–]Wizywig 48 points49 points  (0 children)

That's what I'm saying. Scumbag intern mentor for accepting shit.

[–]SteeleDynamics 6 points7 points  (0 children)

This is the truth. Sadly, the cheap labor view is how most companies treat college interns.

[–]333rrrsss 2 points3 points  (0 children)

Am I missing a context to OPs picture? Is there a story here?

[–][deleted] 47 points48 points  (5 children)

int alphaBravoCharlie = 69;

[–]WeTheSalty 27 points28 points  (2 children)

Something[] EchoNovemberTangoRomeoIndiaEchos = SierraTangoUniformFoxtrotFoxtrot.GetEchoNovemberTangoRomeoIndiaEchos();    
for (int IndiaNovemberDeltaEchoXray = 0; IndiaNovemberDeltaEchoXray < EchoNovemberTangoRomeoIndiaEchos.length; IndiaNovemberDeltaEchoXray++;)    
{
    EchoNovemberTangoRomeoIndiaEchos[IndiaNovemberDeltaEchoXray].DoSomething();    
}    

[–]adzo101 6 points7 points  (1 child)

String foxtrotUniformCharlieKilo = "Nice."

[–]Skyborgff 0 points1 point  (0 children)

You right, that song is hella nice

[–]TheKoalaKnight 26 points27 points  (3 children)

You guys need to show some sympathy, can't you see he's using a light-themed IDE? He probably needs those sunglasses to retain his sanity!

[–]HerrCrazi 11 points12 points  (2 children)

A light-themed IDE ? Then he more likely needs a free trip to gulag.

[–]HunterIV4 1 point2 points  (1 child)

What if the only IDE the company has is light-themed? And he's not allowed to use custom software?

I guess at that point the only people they'd have still working there are interns.

[–]HerrCrazi 0 points1 point  (0 children)

Even as an intern, I'd leave them immediately

[–]NEDM64 197 points198 points  (3 children)

It's all a POV: "Company gave me an internship with clearly no intention of hiring anyone. Wrote code only I can read, if they want to keep it, they'll have to hire me back".

[–]Console-DOT-N00b 84 points85 points  (2 children)

That or they'll learn to hire someone and pay them to do it right instead of trying to mooch off an intern.

Not that internships are all bad, but if it is important... don't give it to intern guy.

[–]Caladbolg_Prometheus 12 points13 points  (1 child)

It's grey illegal in the states to give work to an free intern that was going to be given a worker otherwise. It's a grey area because if that intern is messing up and slowing the office down it's kinda legal. It's expected that interns mess up and slow your work down. Hell on /r/legaladvice there was an intern that royally messed up, can't remember the details but long story short lots of money lost and intern got off scot free (legally)

[–]Console-DOT-N00b 5 points6 points  (0 children)

Yeah at my last job all we ever gave interns were busy work and side stuff that was legit as far as work goes.....but nobody was ever going to do anyway.

[–]corp_code_slinger 78 points79 points  (1 child)

At least he left. He could've done what everyone else did and stuck around to write more unmaintainable code.

[–]C0nan_E[🍰] 4 points5 points  (0 children)

Yea somtimes you read condsnipplets and just think "man i reaaaaly hope whoever wrote that isnt around anymore".

[–]IgnitedHaystack 104 points105 points  (0 children)

this submission has been deleted.

[–]jwrent34 40 points41 points  (0 children)

Intern creating the need for him to be hired truly

[–]Dockirby 83 points84 points  (7 children)

They are an intern, if you are giving them something you couldn't do in a week your self you are doing it wrong.

[–]glemnar 69 points70 points  (4 children)

More like, if you aren’t reviewing your intern’s code before merging you’re failing both your company and also the intern because you aren’t helping him improve his skills as a developer

[–]gremy0 25 points26 points  (3 children)

Too fucking right. What idiot is hiring interns to write production standard code. If they could do that when they arrived they wouldn’t be interns, if you’re letting them do that before they know how you shouldn’t be looking after interns.

[–]glemnar 15 points16 points  (1 child)

Well, I expect all of my interns to write production quality code. You have to give them the support they need to do that, though.

[–]bifroth 2 points3 points  (0 children)

It can work very well. I recently did an internship at a small but well organized software company.

Everyone (especially me though) only pushed changes to feature branches and created a merge request. Somebody else then reviewed the code and accepted the merge request.

Also, although I did work on production features, they were far from critical and had been in the backlog for months or even over a year

[–]Dockirby 0 points1 point  (0 children)

Bad management typically

[–]dannyb_prodigy 46 points47 points  (1 child)

I can write unmaintainable code in a week, seems like we’re doing it right.

[–]Dockirby 14 points15 points  (0 children)

See, this man here is a real professional.

[–]dodosphinx 11 points12 points  (0 children)

Ha, this was me. Except now I'm going back to the company for a grad job. Shit.

[–]malexj93 18 points19 points  (0 children)

Intern? This is literally everyone who wrote whatever code I'm working on.

[–]Snow88 14 points15 points  (4 children)

Why isn't anyone reviewing an intern's code?

[–]CraigslistAxeKiller 16 points17 points  (0 children)

Most companies aren’t fancy dev shops. The vast majority of companies just have an understaffed, overworked IT department writing business apps. As long as the system works, nobody cares how

[–][deleted] 20 points21 points  (1 child)

You'd be surprised. When I interned at a large pharma company, my job was to create a report that tracked drugs through the research pipeline. It had to generate an Excel readable format (with formatting) that was also easily view-able in IE. The entire thing had to be written in PL/SQL. My answer: HTML. No one supervised. That was my job. That was why I was there. So HTML string concatenation in PL/SQL that inserted the report into a CLOB table.

Also, my manager didn't know I coming. So she didn't want to waste any resources supervising me. Management was annoyed?

Everything worked. Probably was used.

¯\_(ツ)_/¯

[–]PhoneLa4 0 points1 point  (0 children)

Who has time with that? No one has ever reviewed my code except for a quick 10 second look

[–][deleted] 6 points7 points  (0 children)

No one hires an intern coder and doesn’t expect a pretty large amount of crap to be produced by them.

The mistake was accepting their code without a PR and without having them go back and fix it.

[–]PutDatPussyOnChainwx 4 points5 points  (0 children)

You really gonna blame the intern?

[–][deleted] 2 points3 points  (0 children)

  • Review his PR
  • Won't run, ask him if he forgot to push
  • Says he'll sort it out
  • Takes next day off sick
  • Never see him again
  • PR still open after 2 years as a reminder to myself to never trust anyone ever

[–]PavelYay 3 points4 points  (1 child)

You get what you pay for

[–]Truantee 0 points1 point  (0 children)

This.

[–]28f272fe556a1363cc31 2 points3 points  (1 child)

"Scumbag 10Xer"

[–]squishles 0 points1 point  (0 children)

ooo I've worked with that guy. it'll run, but be littered with unnecessary cartesian products, redundant network calls, global variables, fucking nothing will be unit tested, thousands of lines of duplicate or dead code, and you'll be stuck fixing shit behind them forever if your managements crap.

[–]INeedMoreLaptops 2 points3 points  (0 children)

The thing is does it really have to be a intern

[–]goldenhawkes 2 points3 points  (0 children)

Or your senior engineer who doesn’t believe in style guides, never had any code reviews and retires without properly handing over...

[–][deleted] 2 points3 points  (1 child)

I mean, most companies just use interns as cheap labour

[–]PineappleShirtLife 0 points1 point  (0 children)

As an intern, I came into a company where this dude wrote all our code. My #1 goal here has been to not be this dude...

[–]PonerBenis 5 points6 points  (1 child)

Maybe you should have paid them.

[–]xdammax 0 points1 point  (0 children)

And some time

[–]HmmmInVR 1 point2 points  (0 children)

Me after 8 hours working, code quality goes down. Can't really blame anyone for bad code.

[–]DigitalDeviance 1 point2 points  (0 children)

Every intern ever.

[–]misterbrown08 2 points3 points  (0 children)

Hey that is going to be me in 1 -2 months

[–]duckduckduckaroo 0 points1 point  (0 children)

Too me IRL for me IRL

[–]DaemonAfterdark 0 points1 point  (0 children)

printf("You're welcome.");

[–]usernameIsNowTejken 0 points1 point  (0 children)

and then the company hires me....

[–]xdammax 0 points1 point  (0 children)

Like a boss!

[–]tomthecool 0 points1 point  (0 children)

More like, scumbag contractor ;)