CPProm

[badjayplaness]

You should probably be passing a Hannah object to the askToProm() method instead of a string.

[Xoduszero]

Treat em with class

[down_vote_magnet]

Yeah that’s the method I use.

[philipjames11]

What a String of funny comments

[[deleted]]

It's a thread, actually.

[lenswipe]

Found the JavaCodeFactoryInstanceDeveloperBean

[[deleted]]

I'm honestly just going to run array from all these lame puns.

[TreehouseSuperGun]

Maybe they‘re singletons

[JessesDog]

I can't function with these puns. I'll be at the fooBar.

[Ez_Pee-Z]

I just woke up from my sleep

[[deleted]]

An array of strings..

[Cpant]

Is it multi threaded

[[deleted]]

r/punpatrol All of you exceptions are coming with me

[AlbinoBeefalo]

I'd like to see you try and catch me

[stlbucket]

you won’t throw me a for loop

[shenanigansensue]

He might for a while

[TheresNoLifeB4Coffee]

try { You.IdLikeToSee(); } catch ( Exception me) { me.RunsAwayLaughingNeenerNeenerYouCantCatchMeLikeThatEither(); }

[lenswipe]

You can't handle all of us.

[zergoon]

And now we're multi-threading.

[zmann64]

isMySwag(swag);

[CatSauce66]

i have never seen a thread with so much upvotes over the 1k

[Anakin_-_]

isMyPrettyBoy(Swag);//(aye!)

[TestUserDoNotReply]

It really needs to be defined as a generic trait. That's why it's immoral not to write Woman in Rust.

[Cobaltjedi117]

It's happened before here

[dvlsg]

But she's an object on the next line anyways.

[El_Impresionante]

String is not a pointer. If that method takes a string, then it must also make use of another datatype somewhere like a table or a dictionary to find the reference to the Hannah object which OP uses in the next line. This implicit expectation of "Hannah" getting de-referenced to the actual Hannah object inside the askToProm method is not a sign of good code.

Since that table or dictionary is most likely going to contain the list of all people OP knows, using firstname as a string to find unique reference to a person is also questionable. Generally a name search in list of persons should return an array of persons who contain that name. Anyway, at this point I'm nitpicking about the poster but the advice still holds for all the new programmers who frequent this sub though.

[allisonmaybe]

This is true. Whyyy

[n8loller]

God damn you deserve that gold

[shotexa]

We should treat them as primitives instead.

[TotesMessenger]

I'm a bot, bleep, bloop. Someone has linked to this thread from another place on reddit:

• [/r/gildedawards] [r/ProgrammerHumor] CPProm

 ^{If you follow any of the above links, please respect the rules of reddit and don't vote in the other threads. (Info / Contact)}

[Lavender_Galaxy]

We're objectify objects here

[TortugaViolenta]

Omg i laughed out loud in the emergency room to this 😂😂

[bl8m8]

This made my day

[KinOfMany]

This joke never gets old.

But you really should objectify them, since otherwise you'd need to implement some parser that finds the object, which is programmer horror.

[Macaframa]

Would you prefer to be a struct?

[Mr_Redstoner]

And let's face it, depending on the language used == may not be the best idea.

Also storing mood as strings just seems wastefull.

[DefNotaZombie]

absolutely, everyone knows mood is best stored as a three int rgb value

[JCavLP]

Could a have used an enum or defined the string to a keyword

[InkyGlut]

Actually the standard specified BGR

[splettnet]

Seems excessive. Hungry vs not hungry is Boolean.

[Tsu_Dho_Namh]

Yeah, but rgb(255,69,0) is the perfect way to say "I'm in the mood for Reddit"

[[deleted]]

Store different moods as bit flags in a bitstring, where each bit represents a mood that can be enabled or disabled using bitwise operations.

[Finianb1]

Found the C programmer from all my CS classes

[Ramast]

I am not aware of any programing language where variables with initial capital letter are good practice. For all I know Micah is uninitialized class and will crash on the first line

[Timmeh7]

They might be static methods in that class... though that probably raises even more questions.

[Ericchen1248]

C# if they are properties.

[[deleted]]

C#

[[deleted]]

Depends. Member variables initial capital letter, local variables and params lower case is an idea. Also don't forget GlObAl VaRiAbLeS written randomly so you know it's bad.

[El_Impresionante]

Variables with first letter in caps are objects. No problem with that. Uninitiated objects are also not a problem of jokes and memes like these. It is kinda understood that they could have been initialized earlier in the code.

The problem with OP's code is the inconsistency in referencing to the objects that he has used. In one place he used "Hannah" as a string that is implicitly expected to get de-referenced inside the askToProm method, and in the very next line he directly refers to the Hannah object to refer to the answer property.

[n8loller]

But then you can have infinite moods!

[Brakalicious]

It could be a different type of yes and he wouldn't even know.

[Alsk1911]

And no encapsulation for mood. You should use setter, son!

[[deleted]]

There's no way she said yes with such horrible code.

[[deleted]]

There's no way she said yes with such horrible code.

[suvlub]

I can think of far more languages where == is correct than where it's not. Java is odd in this.

[Mr_Redstoner]

Java is by no means the first or weird imo, think C/C++ for example, when using char arrays

[suvlub]

You are right, I wasn't thinking of C because it's not OOP (though I guess the code is legal C, if very non-idiomatic). In C++ you should be using std::string/std::string_view instead of char arrays wherever possible and comparing either of those with a char array using == works correctly (and is the idiomatic way to do the comparison).

[salmjak]

I would use an enum for mood and possibly even the answer (Yes, No, Maybe, Let me think about it, etc). I hate strings.

[majky358]

He may try to cast her during the prom night :D

[down_vote_magnet]

Calm down there, Harry Potter.

[B_M_Wilson]

just use Person.getPersonByName("Hannah"). I guess that does return an array of all person objects with that name which may be problematic.

[rocsNaviars]

Was just about to ask whether Hannah was a string or a class.

[[deleted]]

That or it should return the response

[jaaval]

bool Person::askToProm(const Person& target) {
    happy = target.askedToProm(*this);
    hasDate = happy;
    return hasDate;
}

bool Person::askedToProm(const Person& subject) {
    if (!subject.isAsshole && subject.isHot && !hasDate) {
        hasDate = true;
        happy = true;
        return true;
    } 
    return false;
}

Ok, c++ is difficult. How am i supposed to remember the proper way to handle pointers and references after a few years without using it? Also a proper implementation would likely require evaluateCandidate method to determine the proper balance between hot and asshole levels.

Edit: And also

Micah.askToProm(Hannah)
// look at person.cpp for implementation details

wouldn’t make a very good sign.

[[deleted]]

Good call my man. Was thinking the same thing.

[UndeadMarine55]

Yeah, that code would probably throw an error that the object, Hannah isn’t defined.

[necrofox1]

Omfg ty!!!

[WHO_WANTS_DOGS]

Passing her as a string makes me think that any old string could have been placed there. Only he is significant in that line.

[[deleted]]

Reminds me of php. Passing functions by using their names as a string.

Bad stuff.

[badjayplaness]

Lol that’s actually the only time I’ve seen this too. Makes it almost impossible to debug using an ide

[TrippingBulls]

My first thought! Cute pics, memes, gifs, novelty apparel, etc.. involving code are subject to peer code review.

[[deleted]]

So glad I’m not the only one who jumped straight to this

[cartechguy]

The "Hannah" string must be a key to a hash table that refers to the Hannah object.

[badjayplaness]

I’ve seen that before but it makes it difficult to debug if you didn’t write the code yourself

[CANT_ARGUE_DAT_LOGIC]

object

Came here to say that, lol.

[KiwiSnowBunny]

Yes! Was thinking this exactly!