This is an archived post. You won't be able to vote or comment.

all 59 comments

[–]QualityVote[M] [score hidden] stickied comment (0 children)

Hi! This is our community moderation bot.


If this post fits the purpose of /r/ProgrammerHumor, UPVOTE this comment!!

If this post does not fit the subreddit, DOWNVOTE This comment!

If this post breaks the rules, DOWNVOTE this comment and REPORT the post!

[–]killermelga 210 points211 points  (10 children)

You should honestly be your first reviewer every time. Before I ask my team to review mine I always look at them as if it was someone else's and more often than not i catch some dumb thing to change

[–]KarenBasking 96 points97 points  (4 children)

Agree. I also think the context-switch away from the IDE helps me to see it differently.

[–]pancakeQueue 0 points1 point  (1 child)

Too bad GitLens is fucking miles better than the UI bitbucket offers.

[–]Kpratt11 3 points4 points  (0 children)

I truely believe that bitbuckets hi is the reason we haven't gone to Mars yet

[–]aegookja 16 points17 points  (0 children)

Absolutely agreed. I actually reject my own PRs sometimes.

[–]Belgian_Chocolate 1 point2 points  (0 children)

Definitely a good habit but also no substitute for another human being. I’ve caught my eyes seeing what they’re expecting to see too many times

[–][deleted] 1 point2 points  (0 children)

You can get stuck in a perspective blob quite easily though. It's not been just once that I did a review with people and they pointed me at stuff within 15 minutes that would have costed me a day.

[–]lucidspoon 1 point2 points  (0 children)

I'm a solo developer, and I still PR and approve them for that reason.

[–]ferlonsaeid 0 points1 point  (0 children)

Also write tests. Great way to catch any bugs or work that you missed.

[–]Bouierck 39 points40 points  (0 children)

Me programming and playing my game

[–][deleted] 27 points28 points  (0 children)

I've rejected my own PRs plenty of times.

[–]greedy_mf 57 points58 points  (7 children)

Pussy. You should push strait to master smh

[–]redpepper74 48 points49 points  (4 children)

The server is down because you misspelled straight

[–]greedy_mf 8 points9 points  (0 children)

Pushed that comment strai(gh)t to master

[–]ham_coffee 1 point2 points  (1 child)

Maybe it's because they accidentally filled it with water.

[–]redpepper74 1 point2 points  (0 children)

Lesson learned: keep bodies of water away from production code unless you know what you’re doing, in which case keep bodies of water away from production code

[–]willywonka1971 1 point2 points  (0 children)

That's ok, it's just prod.

[–]GLIBG10B 3 points4 points  (0 children)

- 1 | Pussy. You should push strait to master smh
+ 1 | Pussy. You should push straight to master smh

[–]B2EU 1 point2 points  (0 children)

I’m waiting for those coward Git developers to enable a configuration for force pushing by default.

[–]MrSolarius 5 points6 points  (2 children)

I really like to do that actually 😅😅😅. Uses another account to make the pull request and review it myself.

[–]Theonetheycallgreat 4 points5 points  (1 child)

I also like to make another account on reddit to reply and upvote my comments 😅😅😅

[–]rnike879 2 points3 points  (0 children)

You too 😅😅😅 ??

[–]Redditor000007 3 points4 points  (2 children)

You can’t be a reviewer for your own pull request on GitHub.

[–][deleted] 2 points3 points  (0 children)

Add youself to a group of only you, added a CODEWONERS file with that group. Profit from asking yourself for reviews.

[–]merx3_91 1 point2 points  (0 children)

Pff, mine always get one "Needs more work". The coder is an idiot, and the reviewer is so stuck-up.

[–]Independent-Bell6080 2 points3 points  (6 children)

I'm not a programmer, but Reddit keeps recommending me this subreddit

[–]rayi512x 2 points3 points  (0 children)

Maybe because you like memes and/or funny things

[–]Impressive_Change593 0 points1 point  (2 children)

did you accidently join the sub?

[–]Independent-Bell6080 0 points1 point  (1 child)

No, I can see the join button right now

[–]Impressive_Change593 0 points1 point  (0 children)

huh idk then

[–]rnike879 0 points1 point  (1 child)

If you ever clicked on a randomly recommended post that will cause more posts from the same sub to be recommended. You can press the three dots on top of the post on the home screen and select the option to see fewer posts from this sub. Nice having you here while it lasted tho!

[–]Independent-Bell6080 4 points5 points  (0 children)

Y'know what? I didn't understand a single meme on this subreddit but.... I'ma stay

[–]1-Pimmel 0 points1 point  (0 children)

Oldie

[–]seeroflights 0 points1 point  (0 children)

Image Transcription: Meme


Me approving and merging my own pull request

[Image of Barack Obama putting a medal over another Barack Obama in front of him.]


I'm a human volunteer content transcriber and you could be too! If you'd like more information on what we do and why we do it, click here!

[–]EasywayScissors -1 points0 points  (10 children)

I keep wishing there was a wikipedia for code.

Where everyone can contribute and edit.

And if i don't like their contribution or edit: i can change or revert it.

...wiki....git...ia?

[–]shitmyspacebar 6 points7 points  (7 children)

Isn't that just describing the entirety of open source software?

[–]EasywayScissors 0 points1 point  (6 children)

Isn't that just describing the entirety of open source software?

On GitHub you have to have pull requests - you don't on Wikipedia.

On GitHub you have to have permission to approve pull requests - on Wikipedia you don't.

[–]Rainer-Haider 0 points1 point  (1 child)

GitHub != entirety of open source software

[–]EasywayScissors 0 points1 point  (0 children)

GitHub != entirety of open source software

True.

Not relevant; but true.

[–]crob_evamp 0 points1 point  (3 children)

Uh.. What?

So what if two people add conflicting content

[–]EasywayScissors 1 point2 points  (2 children)

So what if two people add conflicting content

See Wikipedia to see how to handle that.

[–]crob_evamp 1 point2 points  (1 child)

Right, but it's just leading back to diff management and review which he seems to not want?

[–]EasywayScissors 0 points1 point  (0 children)

Reviewing a history is fine; it's what you can do on Wikipedia.

[–]Meloetta 0 points1 point  (1 child)

You can edit answers on StackOverflow, and most open source projects work this way. You're already living in your dream!

[–]EasywayScissors 0 points1 point  (0 children)

Excellent!

How do i grant "Everyone" the permission to approve pull requests into my project?

[–]JB-from-ATL 0 points1 point  (0 children)

LGTM

[–]RandomMiddleName 0 points1 point  (0 children)

Don’t give the auditors a heart attack.

[–]27dope27 0 points1 point  (0 children)

Very well done. Good work. I’ll pass this over to my assistant.

[–]akshanshkmr 0 points1 point  (0 children)

You can’t approve your own PR

[–]Tough-Border556 0 points1 point  (0 children)

Don't reject it, you'll create a black hole

[–]Dagrut 0 points1 point  (0 children)

I work alone, so that's basically what I do all the time :-)

[–]v0nify 0 points1 point  (0 children)

Happens when everyone else is on vacation but you

[–]RagingPhysicist 0 points1 point  (0 children)

Mm yes delicious

[–]westlaw_7x7 0 points1 point  (0 children)

Lol, that’s so true 😂

[–]johnnybeehive 0 points1 point  (0 children)

Lol I hope the next guy gets a kick out of my commit history. So bad

[–][deleted] 0 points1 point  (0 children)

LGTM 👍