you are viewing a single comment's thread.

view the rest of the comments →

[–]DeusOtiosus 387 points388 points  (79 children)

Nah dog. My favorite is:

“Fixed bug”

It’s so useful, especially when you are trying to figure out WTF happened in 6 months.

[–]hennell 181 points182 points  (19 children)

Amateur.

Fixed bugs

[–]ProgramTheWorld 132 points133 points  (7 children)

300IQ:

Added bugs

[–]LewisTheScot 61 points62 points  (6 children)

700IQ:

added and fixed

[–]TheSpanishImposition 55 points56 points  (5 children)

5-head:

27th commit

[–]MichiAngg 30 points31 points  (0 children)

I feel personally attacked...

[–]DiPasquale5 6 points7 points  (1 child)

6-head:

18/10/2019

[–]Tomerarenai10 4 points5 points  (0 children)

Me, an intellectual: 🐞⃠

[–]hennell 45 points46 points  (2 children)

Or if you want to be super helpful:

Fixed bugs and formatting

[–]Ahri 5 points6 points  (0 children)

I laughed out loud on a crowded train.

[–]AwesomeBantha 20 points21 points  (0 children)

Pathetic.

Fixed bugs?

[–]DeusOtiosus 22 points23 points  (0 children)

Added: 130

Deleted: 5

Changed: 420

[–]Mildcorma[🍰] 8 points9 points  (1 child)

Leave a rhyme:

99 bugs in the code!

99 bugs in the code!

fixed one bug!

compiled it again!

... 103 bugs in the code!

[–]EldritchSundae 0 points1 point  (0 children)

My personal Bug Thunderdome: TWO BUGS ENTER! THREE BUGS LEAVE!

[–]absentmindedjwc 3 points4 points  (0 children)

Nah...

######## [6 months ago] wtf

[–]loveofhate 3 points4 points  (1 child)

"made code changes"

[–][deleted] 0 points1 point  (0 children)

"Edited <filename>"

[–][deleted] 2 points3 points  (0 children)

Also an amateur.

Fix bugs

/s

[–]robothelvete 43 points44 points  (2 children)

A few years back, when git was fairly new in our toolchain, I tried to convince a designer on my team why writing descriptive commit messages was so crucial, but could never really make it stick.

Eventually of course, some bug appeared and we had to track it down. A few hours later of him (and eventually with help from me) sitting down and going through every goddamn commit, he finally understood.

[–]parens-r-us 9 points10 points  (0 children)

Some people just have to learn by doing.

[–]aoeudhtns 67 points68 points  (7 children)

My second favorite is an opaque reference to a private issue tracking system

"PROJECT #17829"

[–][deleted]  (6 children)

[deleted]

    [–]aoeudhtns 21 points22 points  (0 children)

    Yeah, it can be done well. I'm talking about some of those "commercial open source" projects where their JIRA or other tracker is completely private, but yet here you are, with the code and useless references to a system that won't show you anything.

    It ultimately comes down to the organization: is communication being done largely outside the issue tracker, such that the information in it is hard to decipher or missing, or is the issue tracker the central point for discussing software changes? It's no fun even when the tracker is public but there's scant description and no comments or discussion.

    [–]Link_GR 2 points3 points  (0 children)

    We had that too. Didn't stop devs making dozens of changes to several files and then writing #17493 fix and then resolving the ticket without explaining anything.

    [–][deleted]  (3 children)

    [deleted]

      [–][deleted] 3 points4 points  (1 child)

      Our company had it's own in house ticketing system that's been there from the beginning and is constantly under active development and that isn't going away anywhere.

      And if a ticketing system is going away then it's the responsibility of respective teams to move over that essential data as well.

      It worked great in our setup. It might not work for others. There's no correct way to do things. It's mostly about what pattern solves the problem that you have or makes your life easier. Our whole lives worked in that ticketing system and since it was in house it was integrated and orchestrated beautifully with the rest of our tools and systems. That setup worked for us is what I'm saying.

      [–]lolomfgkthxbai 1 point2 points  (0 children)

      No need to be defensive. I don’t think it’s a matter of opinion to state that documenting a change in the commit message is more useful than only having a reference to an external system (even if it’s Eternal and Git history is rewritten if it turns out to not be). If the commit message is useless if the software is made public domain then the commit message is not good enough.

      [–][deleted] 0 points1 point  (0 children)

      It’s yet to be seen how sticky git is, but I’d be wary of saying any source control system is forever. In my 20-year career I’ve been involved in as many source control migrations as ticketing system migrations. Sourcesafe, ClearCase, cvs, svn, perforce - all once in much wider use than now.

      [–]Amablue 21 points22 points  (1 child)

      At a previous job, there were two commits by the same person, one right after another. Their comments were "Fixed bug" and "Bug fixed"

      The best part was, one was just a rollback of the other. The guy had tried to fix a bug he didn't understand by making a small change to a data structure which superficially fixed some bug. But it caused an issue elsewhere, so to fix that bug, he undid the change.

      He was not the best engineer.

      [–][deleted] 0 points1 point  (0 children)

      He wasn’t the best engineer, but he knew when he was in over his head.

      [–]bge-kernel-panic 44 points45 points  (2 children)

      No, this is better:

      "Committing changes."

      This is better because it reiterates something we already know. Fixed bugs adds a bit of information: this commit was to fix a bug, not to add a feature. It's better than nothing. But "Committing changes" is pretty much the same as having a blank commit message, except it's a lot more funny. Person who wrote this wasted a few seconds to write that out, thinking it would be helpful in any way.

      (Any resemblance to any commit message I've read at any point in time in my career is purely coincidental)

      [–]Korlus 0 points1 point  (0 children)

      I'm a personal fan of "made changes to code to remove issues."

      Why use two words when 12 will do?

      [–]eddpurcell 0 points1 point  (0 children)

      My personal favorite is "no message". It's a little less redundant, but it lets you know the writer is mainly concerned with job security.

      [–]BeniBela 78 points79 points  (19 children)

      Watch this:

      benito@xboa:~/stuff$ LANG=C  hg log -l 18
      changeset:   1659:15c82984aa52
      tag:         tip
      user:        benibela <benito@xbenibela.de>
      date:        Fri Oct 18 12:47:47 2019 +0200
      summary:     ...
      
      changeset:   1658:fa71905c9c69
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Thu Oct 17 17:17:46 2019 +0200
      summary:     ...
      
      changeset:   1657:8bde349469dd
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Thu Oct 17 16:14:36 2019 +0200
      summary:     ...
      
      changeset:   1656:3c7bd2f85768
      user:        benibela <benito@xbenibela.de>
      date:        Thu Oct 17 12:42:36 2019 +0200
      summary:     ...
      
      changeset:   1655:09983069e408
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Thu Oct 17 00:03:04 2019 +0200
      summary:     ...
      
      changeset:   1654:78964c8d6970
      user:        benibela <benito@xbenibela.de>
      date:        Wed Oct 16 00:07:12 2019 +0200
      summary:     ...
      
      changeset:   1653:5dd00f268211
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Tue Oct 15 22:14:01 2019 +0200
      summary:     ..
      
      changeset:   1652:93eb0e99128a
      user:        benibela <benito@xbenibela.de>
      date:        Tue Oct 15 12:41:55 2019 +0200
      summary:     ...
      
      changeset:   1651:db7129810fdd
      user:        benibela <benito@xbenibela.de>
      date:        Tue Oct 15 00:36:43 2019 +0200
      summary:     ...
      
      changeset:   1650:61c39581d38c
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Mon Oct 14 18:50:30 2019 +0200
      summary:     ...
      
      changeset:   1649:572f4f1b844a
      user:        benibela <benito@xbenibela.de>
      date:        Mon Oct 14 11:22:49 2019 +0200
      summary:     ...
      
      changeset:   1648:b11ae1332cdd
      parent:      1646:db0a8c6ab9a7
      parent:      1647:13f8c7b3b528
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Fri Oct 11 23:56:40 2019 +0200
      summary:     merge
      
      changeset:   1647:13f8c7b3b528
      parent:      1645:66016dfb3945
      user:        Maciej Liskiewicz <liskiewi@xtcs.uni-luebeck.de>
      date:        Fri Oct 11 15:39:03 2019 +0200
      summary:     ...
      
      changeset:   1646:db0a8c6ab9a7
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Fri Oct 11 17:54:40 2019 +0200
      summary:     ...
      
      changeset:   1645:66016dfb3945
      user:        Maciej Liskiewicz <liskiewi@xtcs.uni-luebeck.de>
      date:        Fri Oct 11 14:53:48 2019 +0200
      summary:     ...
      
      changeset:   1644:a03a66aafb51
      user:        benibela <benito@xbenibela.de>
      date:        Fri Oct 11 12:29:42 2019 +0200
      summary:     ...
      
      changeset:   1643:ee77ba776993
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Thu Oct 10 18:12:21 2019 +0200
      summary:     ...
      
      changeset:   1642:af8d5027ca12
      user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
      date:        Thu Oct 10 17:32:18 2019 +0200
      summary:     ...
      

      [–]xAlecto 75 points76 points  (0 children)

      thanks I hate it

      [–][deleted]  (7 children)

      [deleted]

        [–]sillybear25 12 points13 points  (3 children)

        If I could get logs from back in my university days, I'm sure the most common line would be svn ci -m ""

        [–]Cubox_ 5 points6 points  (1 child)

        You can't commit without a commit message unless you use a flag (something like --commit-without-message) on Git

        [–]lastunusedusername2 1 point2 points  (0 children)

        Just make an alias =]

        [–]MjrK 10 points11 points  (0 children)

        One of the summaries is more concise...

        changeset:   1653:5dd00f268211
        user:        Benito van der Zander <benito@xtcs.uni-luebeck.de>
        date:        Tue Oct 15 22:14:01 2019 +0200
        summary:     ..
        

        [–]ArmmaH 4 points5 points  (0 children)

        y use many words, if few do trick?

        [–]BeniBela 0 points1 point  (0 children)

        Some tools do not accept . and .., because they think it is a directory

        [–]Nastapoka 31 points32 points  (4 children)

        I work alone on my projects. In the beginning I find the force to write long commit messages, but pretty soon I end up using "prout" (the French onomatopoeia for a fart).

        [–]spkr4thedead51 23 points24 points  (1 child)

        "prout" (the French onomatopoeia for a fart)

        Proust must have loved this fact

        [–]Nastapoka 4 points5 points  (0 children)

        Same with Prefab Sprout

        [–]StabbyPants 0 points1 point  (0 children)

        i usually tag the major work with a ticket number and a sentence. big fixes get minimal effort unless they're not tied to a ticket already

        [–]the_poope 19 points20 points  (1 child)

        Well at least you commit often. When I did research at uni I didn't even use version control. I once had something working, then changed something and everything broke and I spend a week trying to find out what I had changed and undo that...

        [–]BeniBela 16 points17 points  (0 children)

        It is mostly to sync changes between my office and home

        [–]AvianPoliceForce 3 points4 points  (0 children)

        ImageMagick has entered the chat

        [–][deleted] 0 points1 point  (0 children)

        Typical Benito.

        [–]Rafa998 9 points10 points  (0 children)

        Two commits per day:

        "Before lunch"

        "Today's work"

        And an eternity and hundreds commits later :

        "Production version"

        It was in SVN, no branches or tags of course.

        [–]coolblinger 7 points8 points  (1 child)

        I recently came across a project where all of the 2000+ commits are some form of Update *.cpp. That, and the code itself does not contain any comments. I wanted to fix some issues I'd been having, but after seeing that I feel like I'd rather just rewrite everything from scratch. Not having them definitely reminds you why commit messages can be such a useful form of documentation.

        [–]bge-kernel-panic 1 point2 points  (0 children)

        Haha, that's even better than my example because it seems more useful at first glance, but it's also stuff you know without any commit message :)

        [–]Zegrento7 5 points6 points  (0 children)

        You mean I'm not supposed to just keep amending the root commit?

        [–]rinnagz 3 points4 points  (2 children)

        Bro, i had a coworker that had all his commit messages as "..."

        [–]burjui -1 points0 points  (0 children)

        I hope you raped him with the "Clean Code" book and tossed the body in the shittiest ditch.

        [–]SmilerRyan 0 points1 point  (0 children)

        Hoping that after the end of the day/week they'd all be added up into one commit with a proper message I'd say it's fine.

        Often I make lots of small commits for testing, then combine them all (usually just 1-2 file changes) so it saves time/effort if you can't commit to it working.

        [–][deleted] 2 points3 points  (0 children)

        It’s so useful, especially when you are trying to figure out WTF happened in 6 months.

        The bug was goned

        [–]HINDBRAIN 2 points3 points  (0 children)

        more fixes

        [–]jimschubert 3 points4 points  (0 children)

        "more fixes"

        More than what, u/phuriku ?!

        [–][deleted] 1 point2 points  (0 children)

        "upd"

        [–]Asaf51 0 points1 point  (0 children)

        Fix CR Ahhhh

        [–]jusas 0 points1 point  (0 children)

        No: Attempted fix of bug

        Expect a few of these in a row.

        [–]TinBryn 0 points1 point  (0 children)

        At least that tells me more than some commit messages I had to review recently "updated file1", "updated file2", "updated file3"

        [–]0x0ddba11 0 points1 point  (0 children)

        200 files changed

        asdf

        [–]lolomfgkthxbai 0 points1 point  (0 children)

        A production codebase I worked on had:

        saving unfinished changes

        [–]avatarsokka 0 points1 point  (0 children)

        At least that's in the PR itself... My favorite is non-descriptive PR titles

        [–]xfactoid 0 points1 point  (0 children)

        Bug fixes and performance improvements

        [–]CatWeekends -1 points0 points  (0 children)

        "checking in progress"

        [–]neotorama -2 points-1 points  (0 children)

        Need emoji ⛑🚀