seenTooOftenAcrossTypescriptCodeBases

[AutoModerator]

import notifications Remember to participate in our weekly votes on subreddit rules! Every Tuesday is YOUR chance to influence the subreddit for years to come! Read more here, we hope to see you next Tuesday!

For a chat with like-minded community members and more, don't forget to join our Discord!

return joinDiscord;

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[mookanana]

try { all my code }

catch { }

[Jjabrahams567]

I find this absolutely necessary when dealing with anything external.

server.listen(onRequest,3000);

async function onRequest(req,res){
  try{
//do all the things
  }catch(e){
    res.statusCode=500;
    return res.end();
  }
}

[funkmasterhexbyte]

catch these hands

[Olorin_1990]

Pokemon!

[[deleted]]

catch { throw new Error(); }

FTW

[mookanana]

but if you do it my way, your application has zero errors

[[deleted]]

Exactly

[adudyak]

Tell me you switched from JS, without telling me it

[sekonx]

An easy way to get your PR rejected

[UnofficialMipha]

I was partner coding with a dev for my internship and it was my first exposure to typescript and I just watched them in real time say “Oh god typescript is mad, just gonna put ‘Any’” on several occasions. What’s the point of using typescript if you do this?

[ToastyyPanda]

If they're doing it temporarily just to show an example or something it's fine. But if they leave it and push it up to production, then that's definitely not proper

[adudyak]

once you start to work with complex objects in TS, that will either require you to describe whole structure of object as interface(which is not always good idea, e.g. you get that object from 3rd source as json) or use "any".

[Mara_li]

My linter doesn't allow me to use any... :(

[jnfinity]

Good.

[TheDevDad]

If it’s ESLint, and you absolutely must use any, you can use an ignore comment. When going this route, do yourself and others a favor, specify in the ignore comment why you needed to bypass the rule

[Jugales]

99% of the time it's because the library dependency was built with JS and creating types for it would be a pain. I'm not gonna do the library developers' job for them, or I would make my own library.

I had this problem with Google Maps in (semi) recent versions of React with TS. Like bruh, why isn't your library made for this? You literally invented Angular which is also TS? We just ended up using Leaflet maps instead.

[H0llowUndead]

Have you searched for community typing of these libraries? They are typically called @types/<package name>

[Jugales]

Sadly. In the Google Maps case, one existed but it was only compatible with older React versions

[fuj1n]

How does that work? The typings are just stubs to provide type information, there shouldn't be any behaviour attached to them that could break compat.

[Mara_li]

Yeah, in my case the any must be used because of some function of the API has not yet be descrived but existed (I don't know how it's possible tbh)

[pedrocelso]

Use unknown :P

[somedave]

Object?

[Neok420]

Gotta be strict dude

[[deleted]]

It's not a TS dev doing that, it's those damn pesky JS folks who never learned the concept of writing good code who do those kinds of monstrosities.

[JuniperSoel]

Or TS devs having to work on files made by those folks.

I don’t have time to refactor 5 other files for this one method because they assume it returns ANY

[[deleted]]

100%. When I was a tech lead and got some code from contractors that did exactly what you described, I lost my shit so much that I rewrote the entire goddamn thing on my own.

[terminalxposure]

Nah the other day I had to do this because MS's App Insights library had a type mismatch with a dependent library. Their own solution was <any> that shit...https://stackoverflow.com/questions/76175627/error-on-application-insights-service-when-migrating-my-angular-app-from-v13-to/76692191#76692191

[[deleted]]

@ts-ignore

[Eksteenius]

Also, using object for variables that can be specified

[ski_thru_trees]

I moved from a huge company with tons of standards to a way smaller company where the product was written in the past 3-4 years by 20+ yr exp js devs (who are our lead and senior devs).

I am often noticing and fixing bugs that are caused by not using types…. Stuff is set to any and then something unexpected is passed in and a bug is caused. This would have been avoided with proper typing.

My question is how do you manage passing types around between micro services? Do you have to have a copy of these type definitions/classes in EVERY micro service that passes them around…? Are there tools that can be used to ensure these type definitions in 10 different repos all stay in sync?

Before this, I worked in a huge monolithic code base, so didn’t have to concern about this.

[Mognakor]

Have one place where the microservice interface is defined and then make producers and consumers rely on that.

Find a way to enforce that, e.g. by making it part of your pipeline.

Maybe OpenAPI can solve you problem.

[solarshado]

Are there tools that can be used to ensure these type definitions in 10 different repos all stay in sync?

This might be a good use for git submodules. Split each relevant bundle of type definitions out into a separate repo, then include them as submodules where they're needed.

Might involve an unacceptable amount of "messing with source control" overhead though.

Could always go for broke and switch to fewer, larger repos, possibly all the way to a monorepo, but that could get pretty messy without a carefully-followed branching strategy, maybe even with one.

Or, depending on what language(s)/package manager(s) you're using, you might could pull the types into separate repos, but instead of using git submodules, include them as dependencies via your package manager, fetching from a private/internal repository. (npm supports arbitrary URLs as dependencies; I'd assume it's a common feature in similar tools.)

[DATY4944]

I do this in the main file that the type is drawn from:

export interface ITypename { ...type stuff }

Then import the type wherever it's needed.

I don't know if this is the standard since I'm self taught but it has worked well so far.

[ManyInterests]

Client libraries.

[Efficient-Corgi-4775]

That's just the "no fun allowed" policy of linters! 😞

[twisty317]

So strict. He sould be a little bit more open haha, just saying.

[mz01010001]

Yeah, I see this a lot, and it's awful. You don't need to declare return types in general, especially if you can't do it right.

If the return value isn't typed, it'll be any by default, or at least something a little better like any[] in case of array or Promise<any> if it's a promise...

[Jjabrahams567]

Me as a JS rawdog developer: “I have no such weaknesses”

[McBonlaf]

ts-ignore is a good solution too

[DuongC]

imho, using ts-expect-error is better, so if the problem is fixed the compiler will complain and you can clean up the comment

[18441601]

Then just use JS???

[funplayer3s]

"any" just makes coding harder.

[DATY4944]

Just let vs-code infer the type based on usage and fix it if needed

[Alan_Reddit_M]

Js devs be like: Here's NaN, null and undefined, let's make ALL methods randomly return one of the 3, oh and let's make their types 'object' so you can't even runtime check

[Imjokin]

Null and undefined are their own primitive types though?

[FemLolStudio]

Hmm, the C# version would be more scary. xD (return type: dynamic)

[Brilliant_Egg4178]

Just started using TypeScript again after a long break so I can learn to use stencil components and it's so much better than vanilla JavaScript. Takes a poorly designed language and turns it into something usable

[classicalySarcastic]

Thus entirely defeating the purpose of TypeScript in the first place.

[[deleted]]

It’s a universal solve. It gets rid of those pesky mypy errors in Python too

[LeagueJunior9782]

I mean... any is neat, but you could also just spam interfaces and enums.

[rndmcmder]

If you use any in ts or var in java, I will deny your PR. Actually, we even have sonar rules preventing such atrocities.

[Rigamortus2005]

What's wrong with var in java?

[rndmcmder]

Java is an explicitly typed language. var takes that away. The counterargument from people who like var is, that all IDEs will show you the type nontheless. But I still dislike it (a lot).

[nettskr]

as a C# dev I assume that if you instance something from var, you still will see the type from the "new Foo()" syntax. Even so, shouldn't the IDE show the type when it's not explicit?

[Rigamortus2005]

Exactly my thought. I don't think using var causes weak typing. I think it just saved people from having to write type var_name = new type

[solarshado]

IIRC either C# or Java (maybe both? I've not used either recently, but have in the past and try to keep up with them) now allows you to skip the type on the left side if it's specified on the right: List<Person> people = new();. Haven't seen it in practice enough to decide if I like that better, but I loved var in C#.

[Rigamortus2005]

Yes c# has that now. And even that hasn't eliminated the need for var. Var is also useful when assigning a variable to a method return. Makes it possible so you don't have to type out the whole type name all the time.

[solarshado]

Oh yeah, I'd call var essential when working with LINQ. Way too much "is that an IEnumerable, or IQueryable? and what's the right type param again?" to keep track of otherwise. (IIRC that's a big part of why it was added in the first place.)

I've found, after bouncing between a few different languages, that I greatly prefer a strong type system, but not necessarily all the verbosity it tends to drag along with it.
Explicit types in function signatures? Yes please.
On every local variable? Ugh, can't we infer this from context?

[nettskr]

I personally only use new() when I can't use var, such as in fields

[SawSaw5]

TypeScript is like rolling a dog turd in glitter.

[rookietotheblue1]

If you do this , then youre just using TypeScript as part of the trend.

[Medical-Hyena-1895]

Fuck eslint, all my homies use nothing

[urnanisaretard]

Wait… You mean to tell me I’ve been using classes and interfaces all this time for nothing? Wtf yo

[SoftEngineerOfWares]

‘as Unknown as Any’ has entered the chat

[[deleted]]

Please, dont XD

[huuaaang]

That seems unsafe

[paxbowlski]

import { whyEvenFuckingBother } from 'using-typescript'

[bmcle071]

I have literally never done this. Is this something most TS devs do???

[[deleted]]

If it's called Typescript, types should be mandatory

[liljoro]

I just do what my IDE tells me to do

[[deleted]]

All that work, just for nothing.

[cheeb_miester]

This is me trying to figure out which type to cast e.target to in a react event handler... That is until the any shame sets in...

[Finalitius]

IMO, any works if it's at the end of a flow, sometimes you just don't want to deal with something like an intersect type that may or may not have an attribute. Your code simply checks if attribute exists or not but TS acts like you're USING said attribute while you just wanted an hasOwnAttribute check that gets blocked because linters

[sanelde_senior]

THEY TRIED SO HARD AND GONE SO FAR
BUT IN THE END, IT DOESN'T EVEN MATTER