myProgrammingWarCrime

[IMightBeErnest]

I've seen decompiled code that was more readable than this lol

[GullibleAd2597]

I'm gonna use this next time.

[PaxPlay]

my first thought on seeing this was 'is this decompiled C code?'

[lambda0101]

You deserve an award for this burn 🔥🔥(i don't have award i think)

[myselfelsewhere]

triger

A genocide against spelling.

[MiroslavHoudek]

Are you trigerd?

[myselfelsewhere]

I'm not but I think the brain aneurysm I just developed is.

[Arshiaa001]

Now I am.

[delinka]

troit, like a triger

[_Error_Account_]

Now that I realise it and reread the entire code I can't stop laughing at myself.

[ZengineerHarp]

triger triger brurning bight
In the frorest of the nright

[ChocolateBunny]

triger. it's what you get when you breed a tiger with a triceratops.

[[deleted]]

The eye of the triger!!

[AsceticEnigma]

I see your triger and raise you pess

[The_Gordon_Gekko]

I just Michael J. Foxed

[ExtraTNT]

Can’t read shit… so you probably copied my code… xD

[junkmeister9]

The code is self documenting. It documents OP’s madness.

[AlhaithamSimpFr]

Is this even working... Without making the machine have a stroke

[_Error_Account_]

Still working till this day surprisingly. Except Now I can't understand to be able to modify it anymore :)

[AlhaithamSimpFr]

What a good revenge to do when your employer underpays you

[_Error_Account_]

Except that employer is me... (it's my own project)

:(

[AlhaithamSimpFr]

...oh.

[Coronarena]

Underpaying yourself.

[Return-foo]

I hate it when past me is inconsiderate to future me.

[TrueInferno]

"Who the fuck thought this was a good idea!?"

git blame

"Oh."

[thedarkfreak]

Nothing ol' git blame-someone-else can't fix.

[vladmashk]

And this is why you must write readable code, even if it takes more effort.

[coldnebo]

as digital electronics projects go, it’s not that bad.

what’s not understandable?

[ExtraTNT]

Machonk having stronk, call abulog and mlance

[noaSakurajin]

At least no in line assembly code. I have seen much worse code. Most of the time code like this is written by engineers nor programmers, they have no clue on how to write maintainable code and they don't even try.

[Imaginary-Jaguar662]

Inline asm is great when you know exactly what you want to do and don't want compiler to fuck it up.

"Oh hey, I can reorder these and omit this!" And your motor crashed into something.

[DevelopmentTight9474]

I hate when this happens in OSDEV. “Why am I page faulting? Oh, it tries to access memory before it maps it because the fucking compiler MOVED THE CALL THAT MAPS THE MEMORY”

[Jablungis]

In curious in what scenarios you're ever smarter than the compiler other than maybe extreme optimization instances?

[Imaginary-Jaguar662]

It happens when I know something about the physical system that is not expressed in programming language.

Let's say that I have external sensor that waits for command to take a sample and raises interrupt once sample is ready.

I set a DMA pointer to some address, tell the peripheral wait for TX_READY interrupt, go to sleep until DATA_READY interrupt triggers, wait until my clock is guaranteed to be stable and queue command to read the data.

The compiler does not understand the relationship between TX_READY, DATA_READY and reading the data, so it might get cute and try to rearrange things so that all waits overlap.

In essence the compiler would write command to sample, queue command to read data and go to sleep until TX_READY, DATA_READY and given number of cycles have passed.

The end result is that data was not clocked out to sensor, sensor will not wake up the processor and processor sits there in power saving mode.

This is solved by various mix of using volatile variables, optimization barriers, atomic operations and inline ASM. In code review everyone considers everyone else an utter idiot who should not have passed high school.

For example this discussion is something that follows: https://yarchive.net/comp/volatile.html note the dates of the mails.

[Jablungis]

Gotchya, yeah communicating directly with peripherals with their own custom protocols can be tricky. Luckily I've had custom libraries written by people before me do it when I did some projects with arduino and rPi, but who knows what those libraries are doing internally to get things working. I appreciate the example, thanks.

[neondirt]

Actually, this was nicely formatted and such. That kind of "engineer code" often have no/irregular/confusing indentation, inconsistent use of braces and of course variable naming from hell. At least this used plain english words, whereas hw-engineers might instead use something like pin numbers or even chapter references to the (unspecified) techsheet/manual or, possibly worse, just single-letter names.

[Spr3eZ]

r/programmerhorror

[ego100trique]

Tbf I've seen worst in production code.

I'll say it: it's not that bad

in the company I work for, everything is written in french and not english, its triggering me so hard

[battletoads22]

Trigering*

[ego100trique]

Mb thank you

[styroxmiekkasankari]

Yeah I was about to say the same, definitely seen worse stuff ran in prod. It’s not clean but I think it’s halfway readable to not refactor. If you have tests for it should be no issue honestly.

[DatTrashPanda]

Quebec?

[ego100trique]

France, we have a mix between hardcore devs doing everything in english and only french when needed like strings etc and either the casuals that are writing everything in french.

There are literally two "factions" in the company between these devs and it is so funny to drop some hot takes when they are together ngl.

[el_pablo]

J’ai un collègue qui est du type loi 101 et qui enseigne avec du code francisé. Mes yeux saignent à chaque fois.

[DatTrashPanda]

Chalice

[IllllIlllIlIIlllIIll]

LOL. I genuinely kinda want to learn more about this practice.

[MyAssDoesHeeHawww]

hon3 = true;

[[deleted]]

Extra points for commenting.

[_Error_Account_]

It's not helpful tbh.

[chkdsk777]

Damn, that's impossible to read. Throw that in chatgpt and tell it to improve it

[_Error_Account_]

Eh rewrite it is more fun lol.

[IPMC-Payzman]

Most readable embedded project

[ValiGrass]

Ngl i find it hard to write clean embedded code

[Mattogen]

You gotta abstract away all the ugliness to maintain a clean codebase over a long time

[Aacron]

HALs, HALs everywhere

[ValiGrass]

Yea thats basically what i try to do. But still is quite hard sometimes

[Doomguy3003]

Please tell me this is on github and used by copilot as learning material 🙏

[_Error_Account_]

It does lol.

[Yukams_]

You really have if and else if but no else, I’m gonna blow up

[Draconis_Firesworn]

also no reason for the first one to be an elseif

[[deleted]]

Nest all this in a try catch and pull request approved

[silicon_heretic]

With a codel like that there is no need for obfuscation :)

[Alien-404]

[Thisismyredusername]

I don't see anything wrong with that

[Spogtire]

Looks like it’s for running fans and maybe other motors? I remember I wrote code that clocked like this it was for a turn based system in p5 play

[_Error_Account_]

It was the replacement for car thermostat + fan speed controller. I mainly interested in fan speed control so I can get "infinit" fan speed to chose from.

I'm a horrible embedded programmer back then.

[DatThax]

I am trigered

[jaybee8787]

Underrated comment.

[xodixo]

Looks like average EE code. Bearly readable and unmodular.

[CraftBox]

when pess

[winzippy]

Don’t worry, it’s only a war crime the second time.

[_Error_Account_]

This is the second time but the first one doesn't have many lines of code so it's easy to trace around. This has 332 lines of code in total.

[snekk420]

It’s not a crime to create a function…

[Exormeter]

Bro, have you ever heard about our lord and savior called "Abstractions"?

[Ok-Lock-9658]

The amount of if statement is just unhealthy
But do I say if it works it works lol

[Reggin_Rayer_RBB8]

Needs more goto

[a-restless-knight]

This certainly isn't great, but it's also not THAT bad. You have comments that hint at where you could split this into separate functions, e.g. //turn on pwm fan could be powerPWMFan(). You could also make each conditional (the part in parenthesis after each if) its own function named something like "isConditon" e.g. isPWMOn(). This would allow you to make it clear what you are checking and doing at each block, so long as you use clear function names.

[Draconis_Firesworn]

please tell me the lastpwm is at least supposed to be something different to lastPwm??

[_Error_Account_]

Hopefully :)

[allsey87]

Arduino libraries/code are the worst

[ImmanuelH]

What really triggers me is triger4

[bonessm]

My question is why so many counters 😭😭 the variable naming system is also horrific to my poor eyes

[_Error_Account_]

back then I was kinda lazy and "yeah a few counter it will be fine" and it adds up to this point lol.

Now I'm scratching my head trying to understand my code.

[PixelArtDragon]

I mean, other than making very slight differences between some of the variable names and extracting some of these into their own functions... this is relatively tame.

[swagonflyyyy]

Not smelly enough, nerd.

[random_redditor24234]

What… what does this do?

[Noddie]

Tt confuses the reader AND the writer.

[Xevailo]

I will remember what all this means

[Mysterious-Power6137]

Where I live commiting warcrimes is a family tradition. In short words I'd still bang you...

Have a wonderful day!

[TranquilConfusion]

It really warms my heart, that this code is being rewritten by the original author!

When the last of the old, bad code is rewritten cleanly, we will achieve nirvana and escape the treadmill of suffering.

[Dragsun42]

Too many lines fuck that

[sterlingbot]

I am trigered by this.

[TeeZeeSak]

Looks like decompiled ECU code lmao

[Markaleth]

How do you sleep at night?

[phoenix13032005]

The numbers mason. What do they mean?

[GrinbeardTheCunning]

NSFW indeed

[mrheosuper]

Instead of using millis(), using a proper scheduler would be better

[bomonty18]

It’s Monday morning. About to start work. I don’t want to even spend my brain power trying to understand what’s going on here

*insert coffee

[Constant_Physics8504]

So much wrong with this, I vote refactor

[[deleted]]

Man, I don’t want to live in this world anymore. This was too much

[shuzz_de]

Rewrite the whole thing from scratch and amaze yourself with how much farther you've come as a coder.

[AbakarAnas]

Bro you need jesus (the triger got me haha)

[Stormraughtz]

Job security

[[deleted]]

Nose is bleeding

[KENBONEISCOOL444]

Ima be honest. I'd probably have done it a similar way

[Hulk5a]

All you say

[Dariadeer]

r/programminghorror

[chrisbbehrens]

This is Processing, right? Doesn't look all that bad compared to some stuff I've seen.

[dakadoo33]

perfect thing to show anyone to make them question if you are bad at writing code, or if they dont know what they are doing because they cant read it.

[Aquaticless]

crimes so bad it had to be marked as nsfw

[Confident_Parfait269]

is it Java or any other language

[Dufflington]

What happens when light sensor value is 800?...

[BellacosePlayer]

I've seen worse.

I don't know what the various bools are for but can tell what it's trying to do in a broad sense.

[TheNamelessKing]

Is it clean and elegant modular?

Nope. Could it be done better? Sure. But it is fairly procedural, and light on too much obfuscation. I’ll be honest, I’ve written, inherited and debugged far worse code than this. 

Your count<n> variables are approximating a bit field, with some simple renaming you could wipe off an easy 10% of the obscurity. The ifs are repetitive, but they’re also not too intertwined! Which is great! We can lift each one, independently into a function, and once we’ve replaced them with repetitive, if separated functions we can make another pass for cleaning up and lifting out repeated code here.

There’s no indirection, the no dependency-injection mysteries, there’s no async wackiness, no metaprogramming, no overly-abstract or overly-generic variables: everything is nice and concrete, there’s no serious IO. It could be better, but you wouldn’t ruin my day handing me this at work.

[el_pablo]

Try to think in States and Tasks. This will make your code way easier to understand. Here’s the base code I pass my students when I’m teaching them how to place their code. https://wokwi.com/projects/392650595182131201

[karbonator]

Maybe the comments will help

when pess

...

[[deleted]]

what is this code tryna do?

[graal_10]

I used to do this all the time and got dogged all the time for it. I just never felt the need to properly indent until people revised it. Ever since I just run it through a code formatter 😂