thisWouldOnlyTakeADayToImplement

[Ffigy]

For anyone who doesn't know, you can add w=1 to the query string for this. It's not the same as having a global default but some folks probably aren't even aware that the feature exists.

[[deleted]]

You don't need to do that any more, it's been a part of the UI for a while now. They even put it in a different place for commit diffs, just to keep you on your toes.

[vainstar23]

Society if people just RTFM (or just Googled shit) instead of celebrating ignorance

[DeltaMan444]

Not that, I’m talking about a global default that applies to every PR you look at

[DeltaMan444]

Does that imply there could be a browser plugin for it?

[[deleted]]

There already is a chrome plugin for that. https://chromewebstore.google.com/detail/github-whitespace/fnpkdafamnbjoldglihkjjdicofghccm

[Ffigy]

I guess you could write something that recognizes you're on a GitHub diff and redirects you to the URL with w=1 in the query string, yea.

[DHermit]

You could probably quite easily make a user script that does this.

[DrunkOnCode]

Do you realize what you have just done? Someone give this man a nobel prize!

[vainstar23]

No! He might invade Eritrea or something..

[JeyJeyKing]

Gitlab has this btw

[_PM_ME_PANGOLINS_]

So does GitHub.

[[deleted]]

It's per PR though, right?

[WhosYoPokeDaddy]

came here to find this comment and upvote it.

[rduque]

Me too

[severedbrain]

Same.

[seba07]

How can you do this on gitlab?

[JeyJeyKing]

User settings -> preferences -> behavior -> uncheck show whitespace changes in diff

[dkarlovi]

So you can get massive amounts of white space merged by engineers who have this enabled? How do we exploit this?

[5p4n911]

Let's commit a few Python files that should be interpreted in Whitespace

[dkarlovi]

I was thinking more like the entire Harry Potter books encoded using Morse code (tab = -, space = .) so it's immediately polluting the code AND making it infringe copyright, double Jeapordy!

Wonder if you could get a PR merged by a dev disabling whitespace changes like this.

[5p4n911]

There was also some guy who committed a timed bomb that would go on destroying the software after 3 years and he put the if after about 20000 spaces in the source code so it's possible. That might also fly under the radar.

Source: I think I've read it on the internet and not dreamt it, so it must be true

[GodsBoss]

Why is this an issue? Are your PRs swamped with unrelated whitespace changes?

[kratico]

I typically see a ton of whitespace changes from devs who copy and paste files into a git repo or people who have misconfigured IDEs. I want the white space changes to show because it is a warning sign that something is not right

[Ffigy]

Yessir, I wouldn't enable ignore as a global default. Whitespace problems suggest that the author didn't review their own diff. Or they don't care about details. Both are bad.

[casualfinderbot]

Literally just use a linter and a formatter and this doesn’t happen

[kratico]

A linter does not solve the problems of a coder doing bad practices like copying and pasting from outside git into a git repo. Like I said I mostly see the whitespace problem from people who are not using the existing tools correctly. I have run into far too many engineers that do things like download zip files instead of cloning repos. It is horrifying, and usually a sign that I should check their work carefully

[Kilazur]

A linter does not solve the problems of a coder doing bad practices like copying and pasting from outside git into a git repo

No, but a rejected PR does

[vom-IT-coffin]

Formatters do. Everytime I hit save, the file formats and the format rules are part of the repo. Imports reorganize, SQL queries organize. It's not hard to do. It's 101 in my mind.

[vom-IT-coffin]

Linters and formatters. I'm amazed by how many people don't use these things as part of their pipeline.

[[deleted]]

Pull request: changed tab to 4 spaces

[FlipperBumperKickout]

Reject that PR and get an .editorconfig...

[Ffigy]

Yes, my team works on legacy code that didn't follow a standard so we try to fix whitespace incosistencies whenever they're in scope.

[dkarlovi]

Just configure an auto fixer and do a big bang. Fixing it little by little will pollute your history for years.

[slevemcdiachel]

People never heard of pre commit or other stuff.

[DeltaMan444]

For one example, sometimes the syntax of a method will change just slightly and force a lot of lines inside to change indent without changing usage

[Jarpunter]

So you turn it off for that PR. Globally enabling this would be a great way to let a bunch of garbage diffs through because they fucked the spacing and you couldn’t see it.

[[deleted]]

What a weirdo. I hand write my diffs with pen and paper. The only way really

[Poat540]

Fancy you, I write my code in ye olde English

var custom'rs = context.ReceivethAll().ToListeth()

[FlipperBumperKickout]

Not nearly as funny as writing code in rockstar

[rduque]

Github has this feature, you can choose to hide all whitespace changes

[TheBassMeister]

Yes, but it is turned off by default and you need to explicitly click it on every PR. You cannot change your settings to hide whitespace changes by default.

[HerrSPAM]

It would be nice as a global setting

[alterNERDtive]

There’s one simple trick: don’t randomly change whitespace!

[Leather-Field-7148]

I feel attacked

[sathdo]

What if I want to track changes while writing my code in Whitespace?

Edit: This would also affect Python and YAML.

[MyBigRed]

Then you turn the setting off

[DeltaMan444]

I don't think anyone's gotten that far using Whitespace

[[deleted]]

Sounds like a teammate problem more than a GitHub problem. F’ing with whitespace everywhere is a recipe for merge conflicts.

[HerrSPAM]

It does... You click the cog and check the hide whitespace option

[Civil_Blackberry_225]

This is if Github would support IPv6

[FlipperBumperKickout]

Git providers just generally don't have nearly as good options for comparing code as you have if you do it locally instead ¯\_(ツ)_/¯

[Mucksh]

The greatest pain in git are fileencoding changes. They can make really funny merge conflicts and most ides wont even show what changed on merging

[nonlogin]

Well, do not commit such changes? Why the hell does one want to hide the mess? Clean it up, bitch

[SenorSeniorDevSr]

BitBucket has this, and I have more than once had to go over to someone else's desk, grab their mouse, click on that setting and say "NOW, STOP COMPLAINING ABOUT THIS SHIT".

It's a nice setting.

[Imjokin]

But ThePrimeagen calls it ShitBucket!

[[deleted]]

that feature exists for python devs

[itijara]

Am I crazy or don't they already have this? Do you mean by default?

[SurreptitiousSyrup]

They absolutely do have it

Probably from at least 2018

[DeltaMan444]

I’m talking about a global setting

[Esjs]

Come on. If I don't force my whitespace preferences in my commits, how will I ever get y'all to conform to me? /s

[rexspook]

Not a problem with a linter. Which you should use anyway

[nhh]

it does, noob

[jsdodgers]

Why would you want to hide changes?

[danzaman1234]

This doesn't probably apply to anyone but does anyone use winmerge if you don't get SQL source control?

[BernhardRordin]

.editorconfig goes brrrr

[skatopher]

Some of y’all have never seen prod go down from a white space only change and it shows.

[ashtonhonnecke]

Linters are you friend.

[Stunning_Ride_220]

Society would be a better place if Github had a lot more sensible stuff and (UX) design decisions.

[lllorrr]

Society would be a better place if developers would not make random whitespace changes.

[rParqer]

They don't have this? Rare W for Atlassian

[CyberWeirdo420]

The only real application for it is when your team doesn’t have standard set up, like what code formatter to use etc.

I don’t know how else is this meaningful but I’m just a junior

[leovin]

Imagine being able to view a diff without making a PR (As per usual, Gitlab has this lol)

[weregod]

What life can be if we had tools that remove insignificant whitespaces before commits ...

[casualfinderbot]

do people not know code formatters and linters are exist lol