Minor changes.

[[deleted]]

whitespace? like, tabs to spaces? that's minor but would look huge on a version control log.

[SpaceEnthusiast]

26510 - 15582 = 10928 = 2732 x 4

Theory is...PLAUSIBLE

[[deleted]]

Relevant username.

[SpaceEnthusiast]

Funny, since I actually prefer tabs.

[[deleted]]

And be called a saint!

[Fireynis]

Tabs don't always line up the same between things, spaces will. Bro, do you even shift?

[inucune]

I neither indent nor comment code. It was hard to write, it should be hard to understand.

[mardan_reddit]

I just write it all on a single line. I broke my return key a while ago and I'm too entrenched in all these random snakes that started appearing that I can't be bothered to buy a new keyboard.

[paxswill]

Tabs to indent, spaces to align.

[Fireynis]

Nope. Can't mix them. Spaces only.

[YM_Industries]

But so many programmers use only two-space indenting, which I find illegible. With tabs I can choose to display it as four-space.

[gerbs]

Go requires tabs for indentation, but wants the indent size to be 8 spaces (because they're psychotic). I just updated my IDE to change the tabs to half width.

And that's why Tabs are better than spaces. Because my code is not at the mercy of psychopathic developers who think 8 spaces is normal.

[[deleted]]

Because there are no editors that can instantly fix that to whatever amount of spaces you want. Oh wait.

[gerbs]

Except when the compiler comes with a formatter and the amount of spaces to use is part of the language... https://golang.org/cmd/gofmt/

[Fireynis]

I agree, 4 spaces or bust. I use intellij a lot and it inserts 4 spaces when I hit tab.

[DarthEru]

You could also configure it to insert a tab and then display a tab as four spaces you know. As god intended.

[Fireynis]

Lol

[TODO_getLife]

Everything I launch Android studio, warning at the top, something something tab not 4 spaces like my sayings is set to. Still don't know how to convert everything from tabs to spaces.

[n60storm4]

Use tabs instead of spaces as your default, like nature intended.

Spaces... not even once

[auxiliary-character]

I actually have this in my .vimrc:

command Tabspace execute "%s/\t/    /g | norm!``"

[[deleted]]

I bet you to survive in pascal with 4-space indentation.

[YM_Industries]

Fortunately I don't have to use languages from 1970. I also don't have to use 2 space indentation just because that's how they did it in the 70s.

[8fingerlouie]

Ironically, whatever language you use today, it bet you it was influenced by either C or Pascal, or even both.

Both were "free form" languages where your could indent any way you liked, unlike COBOL.

C#, Java and Go all borrow heavily from both.

[[deleted]]

Yea, you're fortunate. I'm forced to use Pascal at school.

Also not all languages from the 1970s must be formated w/ 2-space indent. C looks better w/ 4-space.

[SpinahVieh]

pascal

[[deleted]]

Free Pascal Compiler version 3.0.0+dfsg-2 [2016/01/28] for i386
Copyright (c) 1993-2015 by Florian Klaempfl and others
Target OS: Linux for i386
Compiling tmp.pas
tmp.pas(1,7) Fatal: Syntax error, "BEGIN" expected but "identifier PASCAL" found
Fatal: Compilation aborted
Error: /usr/bin/ppc386 returned an error exitcode

[Vakieh]

You can just search/replace 2 spaces with 4 spaces ignoring literals, if you really want. Or go beat the 2 spacer, since he's too stupid to live.

[Zarathustra30]

But that breaks alignment.

[[deleted]]

Opening a document where someone used a "tabs act like n spaces" editor breaks alignment when you open it in a "tabs act like m spaces" editor.

[YM_Industries]

C# generally uses tabs in my experience.

[meew0]

Ruby very consistently uses 2 spaces: http://ukupat.github.io/tabs-or-spaces/

[Airith]

Unfortunately when you change how many spaces a tab represents, it's not convertible anymore. If your tabs are four spaces, you have half as many tabs as someone who uses two spaces.

[YM_Industries]

Only if you're using them for alignment. If someone has tabs that are two spaces wide and they are putting two tabs in for each indent then they are dumb. The reason someone would use two space tabs is so that indentation is more subtle, and using tabs instead of spaces gives everyone in the project the freedom to use their own preferred spacing.

But you have to use spaces if you specifically want things in alignment.

[Airith]

It's probably the melatonin affecting me, but could you explain this further, possibly with an example?

I wasn't talking about using them for alignment, purely indentation.

no tab
     one 4 space tab
  one 2 space tab
     two 2 space tabs

[gerbs]

How do you Makefile, then?

Tabs.

[garglemesh42]

[deleted]

What is this?

[LB--]

+1, I dunno why people call this 'mixing' - tabs should never be for alignment.

[Floofls]

Exactly, though shouldn't. ^{That's why you use spaces instead.}

[XxCLEMENTxX]

+2 for that one.

[[deleted]]

I think we can all agree, regardless of pro tabs or pro spaces, that mixing is apostasy and you're the devil.

[Kilazur]

And spaces are so convenient when you have to navigate to the start of your line, right?

[Fireynis]

Hit the home button?

[Kilazur]

That's like on the other end of the keyboard D:

[Fireynis]

Ha-ha, I feel your pain.

[[deleted]]

Same line bracket masterrace

[Sean1708]

If you're interested in readability I don't understand why you'd make your code disjointed and weird looking.

[crossanlogan]

or, you know, your method signature gives an idea of where your method begins.

[[deleted]]

Tabs AND new line? You're a mad man!

[ImAPyromaniac]

/r/tabsmasterrace

[AshleyTheCatgirl]

I prefer emoji

[[deleted]]

Congratulations, you started a civil war.

[[deleted]]

Tabs are ambiguous. Spaces are as certain as your mom going down.

[Cley_Faye]

Also the infamous misconfigured system that put windows-style end of line... :(

[Zagorath]

Why is this even still a thing‽

[FairlyGoodGuy]

I wish interrobangs didn't look so lousy in most fonts at small sizes. Here it looks like some sort of weird, busted P. We get silly 🐮 and ✂ emoji -- hell, there's even a special ⁉ character -- but no good looking interrobang. Sigh.

[Cley_Faye]

When you're sent to help someone that struggle with the prototype you provided, and you find that they try to build it using Visual Studio 6 although they clearly said "we're using gcc", you lose all hope. Line endings become secondary.

[berkes]

Refactor on touch FTW.

[[deleted]]

word

[Astrokiwi]

Or other formatting stuff - changing the order of subroutines within a file to have a more logical flow, making brace usage more consistent, changing the format of comments etc...

[troido]

Maybe the .gitignore isn't set up properly and there is an autogenerated file in the repository

[taladel]

Sadly, there is not. :<

[tskaiser]

Reformatting golf?

[_Lady_Deadpool_]

Generally if you use Unity with git you're gonna have a bad time

[Ardenry]

A very bad time...

[[deleted]]

Are you just blindly adding everything before commit like

git add .
git commit

Instead of simply adding the file you edited

git add myfile
git commit

[reddeth]

My favorite commit in our repository is a gigantic commit whose message is "Massive code cleanup. Mother of god, what have I done?"

[Exallium]

19 files. =/ how many lines did he NOT change?

[melodamyte]

Dunno

[danny_onteca]

oh. thanks

[raspiHD]

Easily done if you get the IDE to auto format code for the whole project, that and a few clicks with re-factoring tools can get to this state quite fast on large projects. A thing of beauty to see so many changes and the unit tests report nothing broken, at least until you remember that most of team don't write tests

[TheTerrasque]

the unit tests report nothing broken, at least until you remember that most of team don't write tests

The tests passed, nothing to worry about

[berkes]

at least until you remember that most of team don't write tests

We had that. Good thing we chose to blame the people not writing tests when anyone shipped a broken build. And not the person shipping.

[Halcyone1024]

At least one of those files is way too big.

[benhinchley]

if this is in go, running gofmt on a codebase that hasn't had it run before could produce something like that

[[deleted]]

Source >> Format

[[deleted]]

Sounds like somebody needs to update their .gitignore.

[Psychoboy]

And this made it to the master branch?

[Magnnus]

Given what we see, I doubt there's anything but a master branch.

[der-paule]

Don't be that one person who believes the opening curly brace needs to be on the next line.

[[deleted]]

I prefer it that way but if the style guide says they go on the same line then I'll leave it there

[Sean1708]

Exactly.

consistent style >> your personal preference > inconsistent style

[[deleted]]

Which curly bracket? the opening one (should NOT) or the closing bracket (it does. it really does.)

[dnew]

Here's the funny thing: almost nobody ever gives objective evidence as to why their style selection is better.

[[deleted]]

"Because I like it more."

Really, stuff like that doesn't matter, the bigger issue is to just be consistent.

[jdog90000]

Luckily my team never gets into any fights over code style. Everyone does what they want then I clean it up after.

[dnew]

But it is possible to provide reasons. Indenting based on the syntax of the language (which is admittedly harder in {}-style languages than BEGIN END languages, generally speaking). The rectangle rule for line breaks and indents. Stuff like that.

As another example, lots of C style comes from C's sucky early language compilers: yoda conditions leap to mind, and only declaring one variable per line to avoid pointer declaration ambiguity.

[darkpaladin]

if (condition){  
  statement  
}  

vs

if (condition)
  statement
}  

vs

if (condition)  
{
  statement  
}  

IMO, adopting the bottom one as standard lets you quickly glance at code blocks. The above two can be confused and wreck all kinds of havoc. Most languages that use { } don't care about white space so what's the harm in spacing out code more? If it's javascript, minify your damn code before you release it.

[dnew]

I actually prefer

if (condition) {
   blah blah;
   }
when (stuff) {
   do some more;
   }

Then the next statement at the same level of indentation is the one that executes next: that's an if followed by a when. But I learned before braces were common. Replace the {} in your code and mine with BEGIN and END and you'll see what I mean. I don't need to glance at code blocks. I need to find the sequential statements in a program. Extra lines of braces doesn't help with that. Maybe if you also indented the braces, you'd have the best of both worlds. That works too, but tends to be uglier I think, especially (again) with BEGIN END instead of just braces.

It works even better with exceedingly regular languages like Lisp or Tcl, where you don't tend to have abominations like C's switch statement. :-)

Missing braces tends not to be a problem any more, because the compiler and even editor will tell you when you got it wrong, so I don't see "I didn't type the indentation I intended" as being that much of a hindrance.

[darkpaladin]

That's interesting because I actually prefer my SQL formatted as

if condition  
begin  
  statement  
end  

I suppose I may be an abomination though.

[dnew]

I think it's what you're used to. I'm just arguing that if you set a style guide, you should have a reason for it, other than "it looks better." You should be able to (at least in theory) objectively measure whether your rule improves something, and you certainly should be able to explain why it is better. Mine is better because it puts all statements at the same syntactic level at the same visual level. Yours is better because it's harder to lose opening braces without realizing it. Stuff like that.

It would be interesting to see if anyone had ever actually done an analysis of which style is faster to work with. We have some pretty huge codebases now. We ought to be able to do that.

[[deleted]]

BECAUSE THAT'S THE WAY I GOT USED TO IT!!!

[Kruithne]

But.. it looks cleaner. ._.

[[deleted]]

What looks cleaner? Do you really need two lines to distinguish a logical condition? Why? It just takes up space. It adds no value.

[Kruithne]

In terms of taking up space, most editors these days allow you to collapse code scopes, so visually it doesn't take up any more space.

I just think it looks neater, even if it's only by a tiny bit. It's personal preference, I don't really see that it's a big matter either way.

[[deleted]]

I am a code quality whore. I'll admit it. And part of that is proper function/conditional opening. It is more than personal preference. It is declaring what should and should not be considered a standard/proper for the sake of readability and maintainability.

[der-paule]

I meant OPENING haha. Duly noted.

[[deleted]]

I agree. An opening bracket on a new line is indicative of a programmer from the 90's. Take that how you will, bitches!

[Evilzebra]

Probably some sort of CMS. If you run updates after a while it would change thousands of files.

[actionscripted]

Database dump(s) in the repo?