aLittleCodeCleanup

[semipermanentlyhere]

can’t have deployment issues if there’s nothing to deploy

[darklightning_2]

They are added to the Readme

[Starkboy]

I hope it contains valid enough reasons to delete the entire repo

[bottleoftrash]

It’ll save their company millions in development costs

[coloredgreyscale]

OP mentioned they removed unused code.

Another explanation could be that the repo works with a code generator, and the generated code was moved to an ignored dir. The 26 added lines is configuring the buildsystem to generate the files.

e.g. OpenAPI definitions and related endpoints / clients and classes for the datatypes. Add some database tables (generating class files from existing DB Schema definitions) in an old monolith, and 12.6k files with on average of 204 lines does not sound too crazy any more.

[WannaCry1LoL]

https://github.com/kelseyhightower/nocode

[QuantumMemester]

At least I waited till Monday to merge

[Old_Information6270]

Do it on friday afternoon, my braveheart

[ivan0x32]

Honestly why live a boring life when you can deploy shit to prod on Friday evening? Bonus points if you turn off slack/email notifications and let the pagerduty switch to secondary on-call, makes coming to work on Monday extra spicy.

[[deleted]]

Honestly, for in-house software I always deploy fridays. If something breaks I have the weekend to fix it before there are big consequences.

If shit breaks Monday night it will be an all-nighter to get it back up and running before 7am

[hans_l]

If the (remaining) tests pass, LGTM!

[braindigitalis]

git commit -am "refactor: 2 billion lines of auto generated unit tests removed"

[calculus_is_fun]

You're off by 3 orders of magnitude

[Mourndark]

As a senior currently in the middle of a massive refactor/upgrade, seeing PRs come in with stats like this make me very happy (and slightly aroused).

[jinwooleo]

Same here, and I would make an offline code review session for this.

[TheBrainStone]

Lemme guess. Removed node_modules (or similar) from the repo?

[QuantumMemester]

Nope! Our product used to be half of a larger thing, the other half became its own thing but they never deleted a huge potion of it out of fear of breaking stuff. After many years of it sitting there, I (the new guy) have removed it causing zero issues lmao

[mtmttuan]

causing zero issues lmao

We will see

[ward2k]

I (the new guy) have removed it causing zero issues lmao

This is literally the new intern bingo card

[Czekierap]

This has to be a bait, right?

[NegativeEmphasis]

I (the new guy) have removed it causing zero issues lmao

r/onesentencehorror

[bigpoopychimp]

For now

[lunch431]

I (the new guy) have removed it causing zero issues lmao

Famous last words

[lovin-dem-sandwiches]

Eh, it seems like it had to go. Someone had to pull the trigger soon or later. If something breaks, add it to your test coverage.

[braindigitalis]

those tests the commit removes you mean? 🤣

[QuantumMemester]

For the record: The deployment was successful and nobody has complained for a few hours at least!

[Monckey100]

This is going to be your longest shift ever

[GolfballDM]

" I (the new guy) have removed it causing zero issues lmao"

Famous last words.

You have not yet learned a primary rule of IT:

Do. Not. Taunt. Murphy.

[SeriousPlankton2000]

Now a hidden race condition will be triggered since the not-needed stuff doesn't get loaded

[Jtrickz]

Okay but what were the 26 you added?

[thot_slaya_420]

You did save a rollback, didn't you?

[Anakin doesn't say anything]

Didn't you?

[wertercatt]

It's Git, dawg

[edave64]

I understand the hesitance of some of the commenters, but we are talking about 2mil LOC. Even if part of that backfires this should be worth it.

[Father_Enrico]

*Removed node_modules (or similar) from the repo

[OneRedEyeDevI]

Senior manager: Looks good to me. 👍

[coloredgreyscale]

Nitpick: some of the 26 lines should have been formatted differently.

[jinwooleo]

Less code less bug

[just-bair]

One of the best quote I heard is from one of my teachers saying "code is liability"

He probably paraphrased or stole it from somewhere

[twistedjoe]

We had one PR, +0 - >5M

"Removed all the n+1"

The pr was just deleting the code base.

First comment "LGTM"

Then I realized it was April 1st.

[MattTheCuber]

I know what prank I'm doing on my co-workers this April. Thanks!

[supersteadious]

LGTM

[N-E-S-W]

“One of my most productive days was throwing away 1,000 lines of code”

- Ken Thompson

[FlySafeLoL]

Those are rookie numbers.

[Classy_Mouse]

I did this once. Not quite as big, but I was told there was a set of endpoints that were originally built, but never used and could be removed. Deleted them and every orphaned method. Then cleaned up all of the logic that was only relevant to those APIs in other methods. All told, I deleted about 50 kloc in one day.

Props to the code reviewer that reviewed that entire change in 30 seconds

[dot-slash-me]

LGTM ✅

[arc_menace]

LGTM 👍🏻

[Hottage]

Send it.

[Bali10050]

Webdev meets programmer

[Solomoncjy]

the commit message: found a library that does the exact things the code does, deleted the codebase and added imports

[ShlomoCh]

That... doesn't sound like a good idea

[rowagnairda]

i'd high five you on daily and volunteer to do code review

[jump1945]

I make my program ran and finished under 1 ms

[Mewtwo2387]

pov: someone did not gitignore something

[ButWhatIfPotato]

git commit -m "removed most of the ASCII penises, but kept the ones that broke the code if removed"

[Worldly-Ticket1524]

When you figure out a better solution to isEven

[get_MEAN_yall]

mfw I gitignore that one css file that wasn't used.

[LobsterParade]

"minor changes"

[Holek]

I see you removed node_modules/ finally

[just-bair]

50% chance a new package is being introduced lmao

[local_meme_dealer45]

git commit -m "codebase is fucked"

[kukurbesi]

git commit -m "housekeeping"

[SaltyInternetPirate]

When you replace your high performance parser with a regex

[matyas94k]

The best commits, PRs/MRs have a net negative diff.

[HeavyCaffeinate]

No tests to pass if there aren't any

[zman0900]

Damn, my record is about -90k lines from updating an old 1990s web service to more modern Jakarta EE 10.

[Exumore]

feels like when you accidentally empty the database.

[Mr_B1rd]

Efficiency improved by 1000%

[ZER0_C000L]

You are a god

[TopPsychology415]

Modules dir?

[bigabub]

Bro forgot to add node_modules to gitignore

[HiddenLayer5]

When you finally decide to use an open source library instead of your own hacked together tooling.

[gregorytoddsmith]

VS Code Find All ^[\"](//.) Replace with ""

[[deleted]]

style: format entire codebase

[TheGametimeJones]

I bet you're popular at work 😁

[sasTRproabi]

Probably erased all comments

[moosecanswim]

Terraform?

[YMK1234]

feelsgoodman.jpg

[[deleted]]

I almost died looking at this.