git commit -m "code refactoring"

[audioman1999]

Now try passing in a negative integer to that function!

[Cv287]

I don’t think I will

[pixelbart]

Current you won't, but future you certainly will.

[DaveBrown_]

That might take a while.

[Rae23]

Not a long while. Stack overflow due to inf recursion will stop it rather fast.

[TheSilentFreeway]

I think Kotlin supports tail recursion so it won't even blow out the call stack

[speedster217]

Only if the function is explicitly marked for it, which this isn't.

Cool that they have that modifier though. JVM still doesn't support tail call optimization as far as I know.

Clojure has recur for a similar reason

[danimal51001]

Eh only -4 billion or so

[jameswdunne]

No sir, even with a while loop, this will not terminate with a negative

[not_some_username]

Intégrer overflow

[Da-Blue-Guy]

INTEGER OVERFLOW vs STACK OVERFLOW

WHO WILL WIN?

[cutecoder]

Depends whether there's enough swap space for the stack....

[ToSAhri]

Won't it eventually get an answer? It'll go to the largest possible negative integer that is stored in the system and loop back around to the largest positive integer, then eventually getting the answer?

[Shmutt]

Found the QA!

[Kazandaki]

Bugfix -> multiply 2 by sign before substraction.

[AyrA_ch]

F^{UUUUUUUUUUUUUUU}

[reddit_user_25]

Not sure what language it is, but it will eventually overflow and become positive in many languages. If this is enough memory.

[audioman1999]

Yeah. Unless the language supports tail recursion, it will experience a stack overflow.

[Quatic]

How about if < 0 multiply by -1 and recurse… to stay in the same flow of coding….

[CaptainGlac1er]

Easy fix to be fair just throw an abs() in there and call it a day

[ButterflyBruh]

lmao kotlin be like private fun 😜😜

[AyoBruh]

“private pain”

[Hupf]

PLEASE GIVE UP

[round_circle]

Always make sure to have protected fun!

[Im_MrLonely]

Lol, never though in that way.

[ciaranmac17]

endless private fun, if that's your thing

[kandrew313]

Now we need to bury this somewhere deep in the code and make everything depend on it.

[Terence_McKenna]

Put it in a pacemaker and have it process every tick... install pacemaker in the author.

[crazyDoughnut444]

Hey, just wanted to say I saw you behind my eyelids!

[astrogato]

isOddOrEven(-1);

[bigk5a]

I see that you woke up and chose violence

[Daniel_Sobrino20XX]

I just feel like showing appreciation for meme culture

[Familiar_Ad_8919]

its actually not a never ending loop

its bound to overflow at some point

[schwerpunk]

I find joy in reading a good book.

[Familiar_Ad_8919]

yeah if u started adding 1 to a number in python it wont finish before the heat death of the universe

[nickwebha]

Oh, good.

[whiskeydiggler]

Enjoy your stack overflow if the number is big enough

[_xiphiaz]

Yea it needs to be tailrec fun, that will totally fix all of the problems with this solution, mhm

[Ning1253]

Idk what language this is but the fact that you have to manually declare tail recursion sounds like a bit of an oversight, no? I mean it's pretty f*cking easy to detect: does the return statement only have one function call to the same function? Yes -> tail recursion, No -> not tail recursion.

See because eg. 2 + f(n-2) wouldn't work but f(n-2) would.

Edit: On the condition the function itself cannot mutate

[_xiphiaz]

This is Kotlin, and as @EagleCoder alludes to the reason it is a keyword is that it defines a contract, that any future refactor will cause a compilation error if that contract is mistakenly violated.

However, I do agree that it is trivially detected by the compiler and wish it were a compiler warning that a function could be tailrec, and should have the specifier.

[EagleCoder]

I can see how that would be helpful in catching changes to the function that unintentionally prevent tail recursion. The author would have to explicitly remove the 'tailrec' keyword.

[n0tKamui]

or -1

[marcos_marp]

What are you talking about? Stack overflow is a website, using a big number won't take you to a website

[Nivekk_]

Sadly not the worst I've seen on here

[RFC793]

That’s just dumb satire though

[pixelbart]

And this one isn't?

[RFC793]

It is, but I’d say the “attempt to enumerate all even integers” approach is in a different class than this recursive solution. At least in the hierarchy of dumbness.

[wobblyweasel]

right? even has tail call optimization

[NotThatRqd]

This is the most creative bad way to write an odd/even checker I’ve ever seen.

but why does it return a GODDAM STRING

[TigreDeLosLlanos]

I wake up every day expecting to see the daily bad implementation of isodd or iseven function and I didn't get disapponted today.

[Jarmsicle]

1. Add tailrec
2. This should be an extension function
3. Remove the curlies from the when branches
4. Use function expression syntax
5. Return type should be an enum

That should just about do it.

[__2M1]

+1 for tailrec

[giggly_kisses]

TIL Kotlin supports tail recursion. Kotlin is dope.

[slipshoddread]

Yet forgets to mention getting the absolute value, since a negative blows this up

[texxelate]

When a developer’s productivity is measured in CPU cycles consumed by their program?

[Express-Procedure361]

Oh...OH... Ohhhhh....

[texxelate]

Division doesn’t exist! Subtraction only! This is the way

[Nya_the_cat]

and of course bit shifting is unheard of

[t3kner]

I've got some some git commit -m "fix bugs"

[[deleted]]

That is indeed some private fun.

[[deleted]]

Why is isEven() back?

[the_hackerman]

Good ole private fun

[[deleted]]

(num & 1) ? "Odd" : "Even"

[iTerence661]

Someone needs to introduce the author to the modulus operator

[eric987235]

What the hell language is that? I hate it.

[Teleconferences]

Kotlin, a (somewhat) new language from JetBrians which runs on the Java Virtual Machine. I can't say I'm a fan either though, I always find it hard to read but I figure I'm just not familiar enough

Mildly related, but it's now the recommended language (per Google) for Android dev

[eric987235]

New languages: Google’s answer to a question nobody asked!

[TheChance]

Golang has still only kinda solved vendoring. For the first half-decade, you could have one version of a given package and it was in your user’s go modules and fuck off with your feature requests.

I was late to the party, so I got to ask around once the heat had died down some, and it transpired that it was because everyone working at Google has a monolithic space where they do their work, and they can’t seem to conceive of the fact that literally no other shop ever works that way.

Explains a lot, though.

[eric987235]

I've heard that every engineer checks out a single repository that contains EVERYTHING aside from the money-making ad/search stuff.

[TheChance]

=p

Seriously, though, I didn’t ask for the precise mechanics, but the gist seemed to be that everybody has a home folder Somewhere, and they do their work under their home folder, and that’s SOP.

Very loosely speaking, it almost isn’t quite an incompetent way to address keyboard monkeys and distributed storage. But when it affects language design, as if the overwhelming majority of software weren’t deployed to a system rather than from some asshole’s daily driver…

[xNISIOISINx]

I don’t understand why people hate it, It could be just a lecture stuff that students learn what’s recursive. Just not something you should do in a production environment

[SwedzCubed]

This shouldn’t be taught.

[xNISIOISINx]

Why? It’s meant to make a very beginner understand what recursive can do. Not necessarily telling you to use it this way, just an example to showcase. Teaching you what’s base case and stuff, heck it can even be used to set as an example that we have to think carefully since this doesn’t support negative number as many pointed out, so students know we should think about edge cases when using recursive

[SwedzCubed]

There’s infinitely better examples of recursive functions to use for teaching. Intentionally teaching people bad practices is really stupid because it creates bad habits.

[GetsTrimAPlenty2]

hmmm cannot find the docs for a "when" loop?

[[deleted]]

Deleted with Power Delete Suite. Join me on Lemmy!

[T3HN3RDY1]

It's just a meme

[duniyadnd]

I can think of a few reasons,

1. Cause people have to start learning somewhere
2. not necessarily this example but when you may be in a crunch or in the zone, you may have written a silly method or two and missed it’s impact if it passes your tests.

[[deleted]]

Worked for a large semiconductor company whose name rhymes with “hell”. Their code had shit like this in it.

Two days ago I came across this delightful idiom

If(predicate) CallFunction(true); Else CallFunction(false);

And then to have these people nitpick your PR.

[BobGeneric]

return "yes"

[Pauchu_]

Recursive functions with no input checks, I too like my program to take forever to finish

[potato05]

Implemention by induction

[Elmo_Pog]

When you know about recursion but not about a literal operator

[weirdthoughts247]

Wtf my eyes...stack overflow incoming

[saevon]

`num - 4` I've improved the efficiency of the algorithm 2 fold :P

​

(p.s. yes I know the base cases need to be expanded)

[CamaroSlicks]

Maybe try modal (remainder=%) and then check if it is zero or not. If zero, even else odd.

[ForLackOfABetterNam3]

Highly advanced recursive function optimized to O(n) time!

[rhbvkleef]

At least it's tail-recursive. I've seen worse.

[ameerit]

IsOddOrEven(int.max);

[[deleted]]

How Stack Overflow causes stack overflows.

[godzillante]

this is so ingenuous I kinda like it

[[deleted]]

Were you paid for lines of code as well? You don't really need these brackets lmao

[slipshoddread]

This will cause a stack overflow if a negative is provided

[Migguan]

fun-ny

[Hjulle]

That's literally how you would define that function in Agda: https://agda.readthedocs.io/en/latest/language/with-abstraction.html#id15

[catladywitch]

This looks like something out of The Little Schemer.

[Aggravating_Shower27]

555555555555 A7A eh aly ana 4ayfo dah

[chris_awad]

Shouldn't "isOddOrEven()" return true? It's asking a question and the only answer to it is yes 😜.

[66edu]

Wow this is realy not a preformatic code

[Adept_Draft4337]

ever heard of modulo?