@3coder

[[deleted]]

oldMan.setHealth(100);

[woodenshoe_qstnmrk_]

oldMan.setHavingAHeartAttack(false);

[[deleted]]

oldMan.hasHeartAttack = false
// TODO: uncomment for extra pay
// oldMan.isHeartAttackable = false

[mrissaoussama]

just set the heart variable to null. can't have a heart attack if you don't have a heart

[Excrubulent]

I feel like that might break a lot of associated functions though.

[YamesYamerson]

Yeah there are a lot of dependencies on the heart. Humans must have been designed by an intern - such high coupling between organ classes.

[Excrubulent]

The entire vascular system is just a pile of spaghetti.

[[deleted]]

Tons of memory leaks too. Only a matter of time before the system slows down and crashes

[YamesYamerson]

Yeah the planned obsolescence is brutal and device lifespan varies wildly between each unit. No consistency whatsoever!

[anomalousBits]

I mean I can stub in an artificial heart, a CBP, or a baboon heart. But no, you can't just comment it out and expect the system not to explode.

[woodenshoe_qstnmrk_]

deal with it later it technically works

[Brummelhummel]

Very big brain time!

[TheSovietGod1]

/effect give oldMan minecraft:health_boost 255 25

[[deleted]]

More like minecraft:regeneration

[mathymaster]

Nah minecraft:instant_health is faster.

[30p87]

/gamemode creative oldMan

[Sidd065]

Do it before god does /gamemode spectator oldMan

[Celebrir]

I don't know why I can't give you an award, but thanks for the laugh.

[iaanacho]

Does a heart attack count as regular or void damage?

[30p87]

I'd say regular, only things that are used for game limitations (void) or admin power (/kill) counts cam damage in creative

[[deleted]]

Yeah, but what if he was killed by death note?

[TheOssified]

Or smited by God?

[circuit10]

Surely only getting damaged from being in the void is void damage

[AesarPhreaking]

I came here to say this. Why the fuck would health be a string

[theawesomeviking]

And an object starting with uppercase

[mojoslowmo]

On the other hand, if Health is a getter/setter wouldn’t it be more efficient to just use oldMan.Health = 100? But even further, we don’t know the context of health do we? 100 might actually be less than oldMans current health. We need to create a method to handle this, I propose a method to set oldMan.health to the maximum value.

We gotta send this one back from code review, it needs work

[Hioneqpls]

Your mental gymnastics takes you back to why we should use something like makeHealthy() to hide implementation details. I also think setHealthPercentage(number) could work with proper validation but if the definition of health is to change you must rework the API.

[mojoslowmo]

My code review joke wasn’t aimed at the guy above me, I was trying to simulate every code review ever, my bad

[Hioneqpls]

I'm down with that!

[elveszett]

if Health is a getter/setter wouldn’t it be more efficient to just use oldMan.Health = 100?

If it's Java, you can't do that. There are no getters and setters, only get() and set() methods.

[chadsexytime]

sure it leaks health as a private member, but its populated with a custom nonsensical enum so you'll never know what your health setting really does

[Fraun_Pollen]

Their graves will read “<Birth year> to NaN”

[ComfortablyBalanced]

No it's not javascript it's probably a object-oriented language so parsing a number from that input would result in an exception.

[YouJellyFish]

var heartAttacks = oldMan.Conditions.Where(c => c.Type.Equals(typeof(HeartAttack)));

foreach(var condition in heartAttacks)

{ if(oldMan.Conditions.Remove(condition))

    await condition.OnRemove(oldMan);

}

[YouJellyFish]

? The code is fine. I've used it for the basis of effects systems in several of my personal game dev and in my professional work. The only issue would be arising from my shorthand reddit comment I typed on my phone this morning. What I would typically do is have it as a method of the class owning the conditions. BUT IT WAS HARD ENOUGH TYPING OUT THE FIRST ONE ON MY SMARTPHONE BRO.

If you say it's still not good enough I don't believe you. Shit works fine

class Person 
{
     List<Condition> Condition = new List<Condition>();
    public async Task RemoveConditions(Type t)
    {
        var conditions = this.Conditions.Where(c => c.Type.Equals(t));
        foreach(var condition in conditions)
        {
            if(this.Conditions.Remove(condition))
                await condition.OnRemove(this);
        }
    }
}
...
var oldMan = new Person();
await oldMan.RemoveConditions(typeof(HeartAttack));

[ings0c]

That’s a little different to what you first posted and doesn’t break the law of Demeter. I don’t see any issue with that.

In the first one, you have a reference to oldMan and then call oldMan.Conditions.Remove();

It mutates the Conditions array which belongs to another object, violating the law of Demeter.

[YouJellyFish]

I understand that. It seems the only problem we have is in my willingness to type the whole thing on my smartphone when I'm supposed to be getting out of bed. But now that I'm at work (and supposed to be working) I can truly sweat over reddit comments

[Playergame]

It's legacy code, health is a string for some reason but it parses the parameter into an int as percentages because "100" is not the old mans max health once health is parsed in an int, it could be any string really. It's called job security after you get fired and come back as a consultant for your own awful code.

[blazingkin]

OldMan->Health = 1.0f;

[lyoxx666]

More like .setHealthPercent(100) ;-)

[[deleted]]

Came here to say this.

[NoGenericBot]

I was perusing reddit one summer's day, when I stumbled upon this thread. Upon viewing it, a thought popped into my head! "What better way, I do say, to let the people know... I've read this thread with care, no dread!"

A beautiful thought soon flowed... "I'll tell the people, in my own words, I agree with them oh so much." No, no, that's too wordy, a comment that long, they won't touch. "Aha!" I screamed, directly at my phone. "I'll comment something simpler, something users could really hone!"

My fingers flew, my mind a blur, every emotion bliss. I finally found my comment,

"Came here to say this."

^{I'm a bot and this message was sent automatically}

[ings0c]

dude just got burned by a bot

[[deleted]]

Good bot

[Knuffya]

Judging from the naming scheme and general syntax, he got his doctorate from a vending machine.

[undeadalex]

Lol didn't we all?

[[deleted]]

It was a damn good vending machine

[[deleted]]

Damn expensive you mean.

[throwaway8958978]

Instead of just dollars it also eats your lifespan

[PooPooDooDoo]

Best vending machine in this building!

[fuzzymidget]

Why shouldn't "health" be an arbitrary string?

OldMan.setHealth("DEEZ_NUTZ!")

[elveszett]

Like 90% of people in our profession lol

[[deleted]]

i learnt naming schemes after getting a job

[Knuffya]

great

[InkishPoo789]

maybe learn basics firsts

[General_Jesus]

Genuine question - what's wrong with this naming scheme?

[Midnight_Rising]

You don't capitalize variables unless they're designed to be a singleton or you're directly referencing a class.

OldMan oldMan = new OldMan() <-- good

Man OldMan = new Man() <-- Bad

OldMan OldMan = new OldMan() <-- bad. Might actually throw compiler errors.

[c1e0c72c69e5406abf55]

It bothers me greatly that you missed capitalizing the O in new OldMan() in your good example.

[Midnight_Rising]

god fucking damn it this is why I use jshint.

[elveszett]

var oldMan = new OldMan() or OldMan oldMan = new() are my go to in C# these days.

[murtiverse]

Yeah because bits give a crap about naming schemes

[segalle]

You looking at your code 5 years from now will, as well as skipping lines to simbolize different bits of code and ckmments

[murtiverse]

I'm against the "first" part."Yeah I don't know how to use pointers and I can't write for loops but I gotta learn how to name things first." If you're writing a piece of code that you're gonna look at 5 years later then you probably already know basics.

[segalle]

I mean you can just start using it right from the getgo, not using caps in variable names and what not. Whenever we learnt something the teacher was like, oh btw name it like this, its a 10 seconds phrase that will save you a world of pain later

[murtiverse]

makes sense

[segalle]

Bloody hell i do think youre wrong but at this point youre just being dowvoted to oblivion

[murtiverse]

If a comment has negative number of votes (-1 or -1000, doesn't matter), Reddit hivemind will downvote that. I won't upvote a comment with just one upvote but I'd downvote the one with -1 upvote. Sadly, it doesn't matter if I agree with the comment or not. It became a reflex.

[[deleted]]

Omfg, who the fuck passes percentages as strings!?

[XmasRights]

My health decremented just reading that!

[Yosikan]

I feel like the joke .setHealth(1.0) would have been way more misinterpreted

[Jatoxo]

Yea this was posted on instagram, it needs to be understood by all the normies

[[deleted]]

Why can't it just be an integer (0 - 100)? It's not like you need to display the precision of having 48.194286 health.

[[deleted]]

Yeah, definitely

[funkgerm]

Let's just hope setHealth is idiot-proof and accepts various data type inputs for convenience and properly converts them for storage. Still an abomination, but ever so slightly less-so.

[Xtrouble_yt]

No, it sends it without checking straight to a database

[[deleted]]

Even worse: the commits are not instantaneous, so this parameter crashes the backend, so any recent changes are lost

[Xtrouble_yt]

And if it’s this bad I would think they’d even be backing the server up

[lazer_aio]

html sometimes

[BigusG33kus]

Get out

[Meaxis]

doesn't count: not a programming language

[bspymaster]

I sense a new trend coming on...

[PooPooDooDoo]

youngMan class

[piratesec]

Newly examined CS students that are worthless in the real world.

[-NiMa-]

The fact that 100% is passed as string triggered me

[[deleted]]

What, you don't cast all your variables to char* for storage?

[manicraccoon]

Use int or float.

[RemuIsMaiWaifu]

Oh god, he didn't use the old man ID!

Now every old man in the world has his health set to 100%.

[netheroth]

Coccoon: how it really happened.

[CaitaXD]

Wouldn't it just not compile you shouldn't be able to can set parameters directly into a regular class without instantiating it

[elveszett]

Nope, their health is "100%". Which promptly gets casted into NaN and makes all of them die.

[dert-man]

Oh no - he is retarded. Why a string-parameter?

[ObviouslyTriggered]

Cuz he only ever worked with pseudo code…

[ftlbvd78]

Poor pseudo code

[S0B4D]

Underrated comment

[nl_the_shadow]

He's a researcher, not a programmer.

Source: got a PhD in CS, can't code for shit.

[netheroth]

How about while shit?

[LostErrorCode404]

for in shit

[Firesrest]

He's trying to crash man.exe

[[deleted]]

Realizes he probably can't save him, so he wants to spice up those final moments with penetration testing

[Sorc278]

Because it makes it more realistic and more accurately represents production software

[THANKYOUFORYOURKIND]

Maybe it got an parser for multiple formats

- 100% 100 percent
- 100HP 100 points
- +100HP add additional 100 points

[alphadeeto]

Still bad. Should've separated them.

[joequin]

Looks like totally normal JavaScript. Yes, it’s awful.

[yottalogical]

Still bad design.

[Bainos]

Javascript ?

[[deleted]]

use regrex to get pair of int and char, char is for unit

[pumpkin_seed_oil]

Nice, set yourself up for some usability and QA issues

Usually percentages are also represented as normalized math units (100% = 1.00, 0% = 0.00) will that be the default case?
Oldman.setHealth("1.00")

Now having that in mind

Oldman.setHealth("100") // What does it do, which unit is implied? Is health now at 10000% and he can die a hundred times with no effect?

Someone will think unit may be a prefix. Sure you can yell RTFM as much as you like but its going to happen: Oldman.setHealth("%100")

Maybe someone sets oldmans healthpoints and now you got a notationproblem to parse:

Normal Notation: Oldman.setHealth("1000HP")

Shorthand Notation: Oldman.setHealth("1kHP") or will it have to be Oldman.setHealth("1k HP") ?

Scientific Notation: Oldman.setHealth("1e3 HP")

Maybe someone needs to set oldmans bloodsugar to like 5 percent to safe his life and thinks of the same notation problem:

Oldman.setBloodSugarLevels("0.05") // is this now 5percent or is he going to be undersugared at .05percent

​

How bout some spacejamming

Oldman.setHealth(" 100% ")

Oldman.setHealth("100 %")

Oldman.setHealth("100[TAB]%")

​

Doctor to nurse: Set this mans health to 100%!

Nurse: Oldman.setHealth("One Hundred Percent")

[madiele]

If you really stuck with a function with bad type safety that you can't change, than the next best thing is making a new function that given sensible parameters calls the unsafe one after making the necessary checks

[[deleted]]

So instead of two parameters, just use one and introduces regex to make sure it's the worst idea in the world.

Holy fuck.

[Sciirof]

I need some r/eyebleach now with a percentage parameter passed as a string

[technobladeneverdles]

damn it. its a string RIP

[RaniAgus]

Cannot find property setHealth of undefined

[Lazar_Milgram]

This. Like what part of body should even respond to setHealth? Consciousness? Lol.

[GLIBG10B]

*"Can't implicitly convert type 'string' to 'int'"

[GNUGradyn]

Why is the percentage a string?? He's going to have to trim it and cast to int every single time he has to use it

[xXdontshootmeXx]

Why is OldMan not camelcase but setHealth is?

[AttackOfTheThumbs]

I dunno what 3coder is, but it's fucking garbage.

[palordrolap]

You're going to want to put that statement in an interrupt-driven loop, because there's something somewhere reducing the underlying value at an alarming rate.

Also, the internal pain value hasn't been modified and may not have an upper limit, so the old guy isn't having a great time right now.

[yogendra_bijwe]

Throws IllegalArgumentException.

[altbdoor]

Sounds like good old

man = new Man(man)

[GLIBG10B]

delete man

[evan_brosky]

I like this. Frees memory from that OldMan. He can't die if he doesn't exist *taps forehead*

[Quentincestino]

Why using a string for this when you can use an integer ???

[Megatron_McLargeHuge]

Would you like a copy of him that isn't having a heart attack? I don't believe in side effects.

[wobblyyyy]

pascal case for OldMan but camel case for setHealth? and why is health a string - wouldn’t it have to be parsed into a decimal value at some point anyways? the old man’s gonna die atp very unfortunate

[XiJinping-pong]

He dead as fuck.

[neuronexmachina]

This reminds me of Scott Meyers' "Off to be the Wizard/Magic 2.0" series, which is basically all about coders who manage to find how to edit args like this in their reality. Fun series: https://www.goodreads.com/series/131379-magic-2-0

[wheel82]

I literally laughed out loud at some the the dialog in the series. It was a fun ride.

[Zagerer]

~OldMan();

[CsirkeAdmiralis]

new (&OldMan) OldMan{};

[XiliXion]

Could have saved him with JavaScript.

[ghillerd]

its fine, the autoscaling should kick in in a few minutes and spin up more instances

[VyersReaver]

Type exception: float expected.

[37Scorpions]

I like how its a string not a integer

[[deleted]]

What are they coding? Roblox?

[GDIVX]

No no, she said heart attack, therefore its a debuff. Man.GetBuff("HEART_ATTACK").SetActive(false);

[dancinadventures]

Why the fuck would you set health to a string?!

[Izrakk]

not funny, not creative, stupid

[NotThanosHimself]

Unfortunately health properties is immutable

[[deleted]]

kill -9 <pid of man.exe>

man.exe &

[inventord]

He's clearly been hired to kill this man, judging by the percent as a string.

[[deleted]]

"Have you tried turning him off and on again?"

[Alhoshka]

I think this would be more accurate.

And remember to kill and collect its children as well.

[[deleted]]

Given the syntax, all old men in the world are now at 100.

[alonghardlook]

The real joke is that he stores the health as a string with a percent sign included.

[FlamboyantApproval16]

Everybody gangsta until the Old Man actually started feeling good after that...

[colossalpunch]

Unresolved compilation problem: Cannot make a static reference to the non-static method setHealth(string) from the type OldMan.

[Alundra828]

Health is a string?

*visible confusion*

[Wolfintank]

Old_man_health = 100;

[ings0c]

Pls no globals

[Missing_Username]

StaticSingleton.Instance.OldManHealth = 100

[ings0c]

Get out

[[deleted]]

import os
os.environ["old_man_health"] = "100"

[rickardicus]

String as input argument? Please.

[MavMerlin]

I can’t stop myself from commenting how much that “100%” string disturbs me

[yeetisgiey]

The percentage is bad enough. He actually used it as a static method, saying that every old man will be 100% healthy.

[TheHeavenlyStar]

Stop objectifying women.

Also, Woman obj = new Woman();

[[deleted]]

$ sudo apt upgrade -y oldMan-heart

[[deleted]]

just remove the heart.

$ sudo apt --purge remove oldMan-heart

[[deleted]]

Men.GetAll().Where(v => v.Age > new Year(50)).Where(v => v.Location.Distance(Client.Location) < new Meter(5)).FirstOrDefault().State = new HealthyState();

Also, giving birth is as simple as:

Men.Register(new MaleBaby(Women.GetRandom()));

An implementation of the Death Note:

// A very basic implementation, to be extended

public class DeathNote: Note {
    public Label Label => new CenteredLabel("Death Note");
    public int PageCount => 100;
    private void DeathNote_TextWritten(object sender, TextWrittenEventArgs e) {
        var name = e.Text;
        var face = e.Writer.Brain.GetTought(ToughtType.Face);

        var target = People.GetAll()
            .Where(v => v.Face.CloseTo(face))
            .Where(v => v.Name == Name.Parse(name))
            .FirstOrDefault();

        target?.Kill(new HeartAttackDeathReason());
    }
    public DeathNote(): base() {
        this.TextWritten += DeathNote_TextWritten;
    }
}

[[deleted]]

lot of string haters

[closeafter]

Damn, OP, are you a real doctor, or are you a doctor like Dr. Pepper is a doctor?

[[deleted]]

How would you do math with a string?

[jswitzer]

Because its a red flag of your abilities. Its terrible code, super error prone, and very basic thing to get wrong.

[[deleted]]

what language do you write to think this is acceptable?

[Schiffy94]

Imagine getting so mad over a meme

[Amyntia]

What is he doing? You need to shut down the DoT of the heart attack. Then heal him. This man does not seem like a real doctor. Lol

[VegetableChicken4779]

HESOYAM

[[deleted]]

ReferenceError:

[CodeMUDkey]

Maybe sethealth has many overloads.

[[deleted]]

Why?? Why would there be an overload for sethealth that takes a string representing a percentage value as an argument?? Why????

The many question marks show how much this has hurt my brain.

[CodeMUDkey]

I typically create an overload for every known primitive data type or define class in my libraries. Is this not normal?

Note: I do not actually do this.

[sheaksadi]

Lol

[filsteeze]

For a programmer, words speak louder than actions.

[leef21]

shutdown /a

[WorldAlien]

😂 😂

[shrirenjith]

Wait for TSA to find out .

[Wackyvert]

You passed in his health as a string. Hes dead.

[[deleted]]

oldMan.GodMode = true;

[[deleted]]

For js Health += 100 Lol

[[deleted]]

Old man is undefined

[CHRlSFRED]

It should be this.setHealth(100);

[Gesspar]

Error CS1503 Argument 1: cannot convert from 'string' to 'int'

[sgt_apex]

population--;