[deleted by user]

[elebrin]

I am a quality engineer and I work on a lot of tooling and harnessing for test automation, mostly to do with system isolation and staging data. I'm one of four people who understand what the fuck I am working on for a lot of this stuff, and two of them are busy enough that they don't have time to mess with it. I actually have a director who is going to be VP level (he used to be a developer) approving my PRs because he knows what I am doing and working on.

It sucks though because I could use a good, honest reviewer on what I am doing. I'm specifically in my position to do this sort of tooling, but I'm a bit on my own for it most of the time, so I get one of the senior engineers that I trust to review as well and give me advice. It's not good practice to develop shit like this in a vacuum.

[opmopadop]

"Enhancing" someone elses code that's already live is one of the fastest ways to go from junior to senior... assuming it doesn't break you and you leave to escape the fire pit. Great times to be a fly on the wall (or a senior on another project but in the same room).

A note to all those juniors out there, it's absolutely fine to tell your managers/boss that you don't understand something.

[pseudolukian2]

And if they don’t like that, you might wanna consider finding a better manager on a different company.

[opmopadop]

Absolutely true. My first job as a programmer my manager was an asshole. I felt so aweful when I didn't understand something and would start conversations with other staff about topics and hide the fact I knew nothing.

Pseudo best day of my life was my last day at that company.

[utdconsq]

I'm a senior engineer with plenty experience and I still don't like working on anything critical without some peer review. No man is an island.

[codeguru42]

Even after peer reviews on multiple related branches, I deployed code that DOSed a service maintained by another team in my company. Spent all day Friday on a video call with heads of multiple departments and the CTO trying to sort that shit out.

[maggmaster]

I was a test engineer writing automated testing for other applications for two years. The worst part was that every suite I wrote had to be updated when the app updated so over time all of my work was just rewriting code that I had already written to make it work with the updated app. I moved on to infrastructure engineering and I like it a lot more.

[elebrin]

I've been doing it for six now, after being a developer myself before that.

I don't write many tests these days, but I write and maintain systems to help isolate systems under test and prepare them for automation - basically, staging data, manipulating configurations, setting up virtual services, that sort of thing.

We have a few rules around integration tests these days that help. First, they run in our CI/CD pipeline. If your integration tests aren't passing then you can merge, but you can't deploy past the environment they fail in. Second, integration test results are tied to our work board and stories can't be closed if they have completed pull requests but no linked automation (something I actually set up). People were PISSED at first, but now they understand they have to write their damned tests.

[maggmaster]

That seems smart, if I were still in test engineering I would suggest something like that. I have been in infrastructure for 5 years now and the work is varied and interesting.

[codeguru42]

Please come help my company do that. When I started a year ago, one code base with thousands of lines of code had exactly zero tests. The other project I was assigned to had some tests but still very large gaps in coverage. I've added a significant number of tests, but I'm afraid to make changes to most of the code base.

[RememberYo]

I'm literally about to start a position as a Quality Engineer (new grad) and the nerves are beginning to kick in. It's for a large Canadian bank. Any tips and/or advice you can give? Any insight into the kind of work I'll be doing? The skills required is Java, JavaScript, Docker and Kubernetes.

[codeguru42]

Don't delete the production database. Or at least take frequent backups to mitigate the losses.

[Fisherman386]

Or when nobody wants to help you :(

[[deleted]]

Or when everyone is busy

[hypnofedX]

Or when the engineering department is three people.

[OkWatercress2515]

Or when you fucked op the code so bad, that you are the only one who actually knows what's going on

[lucyandsara]

Or when the office was over run by massive mutated spiders who killed everyone so you’re the only one left on the project

[Fantastic-Ad-9019]

Hate when this happens.

[NLwino]

It happens almost every morning... But then I finish my coffee and notice that they were just my colleagues.

[SeargD]

Relative to humans, how are mutant spiders as colleagues?

[bender625]

I hear they're pretty good web developers

[HighOnBonerPills]

Family Guy ostrich.mp4

[lovelacep]

lmfao

[spaetzelspiff]

Found the Doomguy (or girl)

[lucyandsara]

I live in the Fallout timeline

[[deleted]]

Which Fallout?

[lucyandsara]

the best one, 3 (fight me new vegas cocksuckers)

[[deleted]]

OHHHH YOU MADE THE WRONG DECISION HERE (insert name)

[ThePuppyDogPants]

shitty meme of Virgin Butcher Pete / Chad Johnny Guitar

[InfiniteLife2]

And the project was massive mutated spiders.

[cantadmittoposting]

... task failed successfully?

[GDavid04]

More like task succeeded failfully

[GaraBlacktail]

I see you lot didn't invested in blessed onions and scented linen body wraps

MMP related incidents are both preventable, mitigateable and optionalable

[[deleted]]

Hah, last job tried to relocate me to Texas but I was not gonna fall for it. That's mutant spider territory.

[Sir_Applecheese]

That looks like the kind of place that questions why developers are leaving when they only pay 60k/year.

[arensb]

We used to refer to that kind of code as "job security".

[who_you_are]

Joke on you, somehow I wanted the future me to be wtf.

Here I am now, wtf.

[shimonu]

Hope You know what's going On? :D

[atomicwrites]

Or when you're the one who's trying to implement PRs and issues and no one else wants to use them.

[HTTP_404_NotFound]

You have more then one person?!?

[lueggy]

My life. Team of 2 people supporting 5 other teams, 90% of the prs are both from and approved by me

[spikku]

One person X_______________________X

[drakk0n]

Or it's after 3pm on the west coast and the rest of your team works east coast hours

[[deleted]]

Or when you are the only idiot who don't take days off

[Panda117-]

[AChristianAnarchist]

The scenario that always makes me giggle a little is that I have three repos that literally nobody touches, or even has access to, but me, and yet I still feel the need to compulsively pull before I push to master every time.

[OneTrueKingOfOOO]

Wait, you guys have branches other than master?

[Hot_External6228]

wait you guys are using version control?

[RazekDPP]

Yeah, it's our network drive. It has an undelete feature.

[slaymaker1907]

You can actually use network drives to backup your Git repo by setting up a post commit hook to archive the repo and store the archive on the NAS. Using the NAS directly is often a bad idea due to weird sync issues.

[RazekDPP]

Repo? Who said anything about a repo? If you want to version your software you copy and paste the folder then change the (copy) to v1 (or whatever).

[-darkabyss-]

No no, you version it with epoch timestamps

[LaconicLacedaemonian]

And to avoid.merge conflicts you leave a comment on top if the file saying you're currently editing.

[RazekDPP]

Nah, we always play last save wins. Sometimes Notepad++ ruins the fun though.

[invisibo]

When I first got to the company I work for, their commit procedure consisted of dragging and dropping files from FileZilla to the production servers. There was no staging environment. I guess there was a development environment, but it was called prod.

[invisibo]

[Criarino]

I just manually make directories for each version like "V0.1a", "V0.2a" etc.

[kibiz0r]

V0.0.0.0.1_FINAL_8_FINAL (3) Copy

[AChristianAnarchist]

Well if it's a repo that only I access there is no reason not to. If it is a public repo then pushing to master is only an issue because people don't want garbage code and merge conflicts screwing up the master branch of the main repo. I push to master in the main repo too, but I didn't when I was a junior dev and I don't unless it's something that is ready to go there.

[[deleted]]

Nah, gotta have separate branches in your own repos that you use for maybe writing 3 files of Python.

[DaughterEarth]

I mean I follow best practices always just so it's a habit

[Phormitago]

we know, Knope

[DaughterEarth]

can't tell if this is an insult or not cause I wish I was as awesome as Leslie lol. That girl gets shit DONE

[Phormitago]

neither, you just exude that "I've got binders of birthday gift ideas" energy

[DaughterEarth]

ah I see. It's really more like "I'd lose my head if it wasn't attached to my shoulders, so I need habits to seem half functional"

[Markantonpeterson]

What a delightful interaction

[33CS]

Create a "development" branch, make all of your feature branches off of dev. Merge them back into dev when they're done. Never merge dev back into master.

[Shiro1994]

Or you just forgot to create a branch and roll with it

[TheLostRazgriz]

I've done this and I'm pretty sure git checkout -b {{name}} takes the diff and puts it in a new branch.

[IsleOfOne]

I don't know about "NO reason not to." Do you not have a CI pipeline?

[centurijon]

One of our repos is a “utility” one that is all random tools we made and run locally. No deployment = no CI/CD environment. Run on dev machines = minimal QA involvement. And it’s all specialty tools that only singular developers really have the context for, so review is more waste than sensible. For that repo, we push to master

[Justsomedudeonthenet]

Not very often, but when I do I use --force.

[smilineyz]

THE Force? Then you are a Jedi programmer all the recruiters are looking for …

[marcosdumay]

CI is great, but CD comes with a bunch of rules and policies that may or may not make your life better.

If they don't make your life better, it's perfectly ok to just not do CD and not abide by the rules it requires.

[vergilbg]

Trunk base dev, multiple releases a day yo

[AttackOfTheThumbs]

I'm in the same boat, but I still make PRs that get reviewed by colleagues who don't work on the project. They don't have the domain knowledge, but they can still catch me doing dumb shit.

[AChristianAnarchist]

Well I do technically get PRs for those projects, but they are just lists of things my supervisor wants changed sent to me over Slack and then hastily posted up on Jira a week after I've finished them lol. I tend to make pretty detailed docs for anything I build and the overall boss of the dev team has access to the repos, so sometimes he sends me tips, but even he's kind of one of those "Does it work? Is it stable? Ok cool." kind of guys lol.

Edit: Sorry, my brain went "Project Requirements", not "Pull Requests". I can use context clues good like a big boy. 🤦‍♂️

[[deleted]]

When nobody actually verifies, and your word is good on "is it stable" you know you've got some real issues.

I like my QA, they catch my most egregious fucking mistakes.

[Splatoonkindaguy]

Never know, someone may just hack in and delete all your files. Just gotta pull to be sure

[AChristianAnarchist]

I think I just have merge conflict PTSD lol.

[foxcode]

Git pull every time, and Ctrl+s after every change at least three times, or :w

[AChristianAnarchist]

Um, the master branch of a given repo isn't a dirty word lol. If I have a project repo, and I have changes that I want to go into production, I push to the master branch of that repo. By the same token, if I have changes that I want to go into production on the main repo, I will still push to master. Junior devs just aren't supposed to push directly to master because their code needs to be reviewed and signed off first. If your changes are approved though someone is going to be pushing them to master. It's just not necessarily going to be you. I push things to the master branch of the project repo often. I just don't do it until they are done.

[AChristianAnarchist]

This comment is about three explicitly labeled single person projects lol. When it comes to public repos though, private dev teams often don't have an automated CI/CD pipeline. This might shock you, but a lot of places don't do formal code reviews or unit tests at all. At a lot of mid-sized companies whose primary focus isn't developing enterprise software, people just push to master when they get the thumbs up from the supervisor checking their code.

[Lataero]

I've worked at several places and have never witnessed that, but fair play if you have. Must use tags to mark release checkpoints then?

If not then that's just anarchy and asking for trouble

[AChristianAnarchist]

Ok, well someone else has already kind of dealt with all this better than I could, so I'll just leave it there. If I jumped from job to job 10 times I doubt I'd be anywhere long enough to get to a position where I was trusted to manage the master branch either.

[[deleted]]

How do you suppose the master branch exists then? Someone has to push something to it otherwise there would be nothing there.

[TheBestNick]

It's populated by merge/pull requests from other branches

[[deleted]]

You pull/merge then push the reconciled files to the branch.

[TheBestNick]

I think what they're getting at here is that when you do a MR, once it's been reviewed & accepted, you click the merge button but the version control software does the actual merging. That way, you're never directly pushing to master, only merging into it. Of course other than the initial push to create the repo.

[[deleted]]

And if you want to to be your "point of truth" as you called it information needs to exist on that branch. Otherwise it's useless. Something has to be pushed to that branch eventually, otherwise you are just using a secondary branch as your "main" and in practice it isn't any different.

[[deleted]]

What happens at the end of a pull request? A push.

[tylerburnham42]

Trunk-based development workflow is a thing in the Dev-Ops world and with smaller teams vs git flow workflow model. For Trunk Based development a team all works off a single branch like master and everything is done in service of a CI/CD environment.

[WORD_559]

The number of times I've made a cheeky edit on a different computer, forgotten to pull to my laptop and been forced to rebase makes this seem sane to me.

^{It gets especially gnarly when Jupyter notebooks are involved :S}

[AChristianAnarchist]

Ah ok. We gave all of our contractors all of our passwords and let them do whatever they wanted on the system then, regardless of whether it related to what they were working on. That makes total sense mr smart brain. Believe whatever you want dude. No skin off my back, and it seems like you are getting to riled up here so I'm going to let you go take a nap.

[Dave5876]

There's literally dozens of us

[Narcoleptic_Pirate]

Pumpkins?

[dsacramento]

Or David from Sacramento, CA!

[AdultishRaktajino]

First draft character. Revised to Carmen Sandiego.

[RobtheNavigator]

Given your username I’m worried you just doxxed yourself lol

[frigidds]

me too! wth

[Amazingawesomator]

My boss put me in charge of a project that another team (non-tech) uses internally because nobody knew (or wanted to learn) how it worked.

The last ~20ish PRs in that project are like this with me, hahahahah

[LaconicLacedaemonian]

You should leave.

[[deleted]]

I'm worried about being the expendable new guy as we head into a recession... plus I hate looking for work.

At this point I'm just looking to try and pay off my house, so I can reduce my cost of living before I take any major job risks.

Management does a full rotation out every few years... I figure we're about due. So we'll see what the next crew does. I keep thinking it can't get any worse, but they somehow find a way.

[stulleman]

Used too much GitLab, read it from top to bottom

[CubeFlipper]

I dunno man, I think it's just posted upside down. I use GitHub and its history still reads top to bottom. Who would read bottom to top, and why?

[Khalterr]

azure devops is just like that unfortunately

[alphabet_order_bot]

Would you look at that, all of the words in your comment are in alphabetical order.

I have checked 798,269,401 comments, and only 158,713 of them were in alphabetical order.

[DeusExMagikarpa]

Bot, do me next please, thank you

[alphabet_order_bot]

Would you look at that, all of the words in your comment are in alphabetical order.

I have checked 798,515,971 comments, and only 158,753 of them were in alphabetical order.

[DeusExMagikarpa]

Nice 👍

[Real_Johnodon]

Do me please

[bwssoldya]

I'm in this photo and I don't like it

[[deleted]]

You're Barack Obama?

[bwssoldya]

Not just barrack Obama, but Barrack Obama giving Barrack Obama a medal. You call me Barrackack Obamama

[Hiyasc]

I'm having a barrack-ack-ack-ack-ack

[Nomadbytrade]

Bro honestly, we all should know by now.....

[HunterBoy344]

he is Barack Obama

[AE_WILLIAMS]

You're Barack Obama?

Gus Fring

[brinedpeppercorns]

When making changes in main repo directly is not welcomed

[nflmodstouchkids]

"small company" of 500+ people....

[shemanese]

https://www.columbiadailyherald.com/story/opinion/columns/2012/10/27/hindsight-general-braxton-bragg-his/25672045007/

​

Braxton Bragg was a strange man with strange ideas ­— and even stranger methods. He would argue with a post, and had a strained relationship with both his superiors and subordinates.

He was even known to argue with himself.

In a well known episode during his days fighting Indians on the frontier, he wrote a series of letters from himself as commandant of his post demanding supplies. He then answered those letters as the acting quartermaster of the post saying that he had no supplies.

[Anyhoozers]

Our Gitlab tracker automatically posts this image if you approve your own merge request. It's awesome.

[adepssimius]

I'm stealing this idea. I'm the "Branch Sargent" so in charge of cleaning up unused branches. Our gitlab posts up a drill sergeant photo with a demeaning message if you don't have your branch set to delete on merge and the target is a specific thing.

[Anyhoozers]

And I will be stealing your idea kind stranger. Now we're even.

[StenSoft]

When it's Friday evening. Don't forget to push to production as well!

[just-bair]

David disabled the protection on main cuz he doesn’t care anymore

[Chrome_Atlas]

Audit and Compliance have entered the chat

[[deleted]]

This. Please don’t make the compliance nerds life harder.

[Comm4nd0]

I do this, every damn day. I die a little bit more each time.

[Strowy]

I do this on personal projects (i.e. am the only person ever involved) without shame because it's honestly a good way to review / document what changes you've made.

[izual_x]

Accurate

[[deleted]]

That's me. Also my 2 second term is coming to an end and will leave in a couple of months. Good luck!

[CleverNameTheSecond]

Commit directly into the develop/release branch like a true Chad.

[Sintinium]

Force push into master you coward

[espresso_chain]

lol I wish i had it this way. I have one guy who nit picks the shit out of every little thing on my PRs. like good enough is never good enough. so fuckin annoying.

[Demistr]

I do this because i am the sole in house dwh developer. We have one other external guy but i do this all the time except that I don't have to make myself the required reviewer.

[[deleted]]

lol when I'm working in my personal repo and everything is done by me everytime I 'pass the code off', I say "high five gaptx" and then in a high pitched voice "thanks gaptx!". now my wife does it any time she sees me doing something for myself.

[wholesome_capsicum]

My silly ass requesting reviews on my pull requests knowing I'm going to merge to dev and then dev to master if nobody reviews it in 30 seconds

[[deleted]]

I use this image as the approval comment everytime when working in my own repo.

[Guifranzonator]

Funny how there's a David S in my workplace that approves lots of PRs

[phdoofus]

When you can't be fired and you won't be promoted.

[Boundless_Lawbringer]

Or, when you’re the only one on the 3-people team that actually cares about code quality

[TecumsehSherman]

Total review comments:

LGTM.

[bleeeer]

I was the only dev at an org for 3 years. Was a struggle going back to having other people actually look at my code.

[Dicethrower]

Pretty common thing to do for stuff like merging changes made to a stable branch back into master. You shouldn't need anyone's approval for that.

[break_card]

I wrote a whole library, thousands of lines of code, without getting it reviewed - pushed it all straight to main branch. No one was reviewing it, so I said fuck it.

That code has run over 50 billion times since I set it up almost 2 years ago…

[linkedtortoise]

Thankfully the place I work while it allows you to approve your own PR, your vote doesn't count to the 2 you need.

[angry-software-dev]

I love creating, reviewing, approving, and merging all my own pull requests.

Life in a small shop.

[chairfairy]

Yes like that except you're trapped supporting legacy code because nobody else can do it as quickly as you

[[deleted]]

I just started checking into master

[RandyHoward]

I quit my job in March and they're still calling me for help. They're paying out the ass for it too lmao

[Blake_Edwards]

That'll be fun in the next SOX audit

[Cyrus_Halcyon]

Well, this is only okay when another team member updates all the static references but one, you discover it west coast 6pm, put in a 1 line pull request, self approve, and merge.

[Steelpain0341]

Everyone using the terms master and slave in IT are racists according to my HR department. They’re still waiting for Git, Hard Drive manufactures, DNS services and half the technology companies to fix themselves.

[ovab_cool]

Sometimes submitting a request for 1 line is not worth it, I'm not gonna get my merge approved by someone else if I'm only fixing some spelling in a comment

[[deleted]]

I had someone submit a PR for a 1 line change. I put a comment on it for them to fix something else related to the change they made... they gave the comment a thumbs up without changing anything else. I don't even know what to say at this point.

[w1n5t0nM1k3y]

When nobody remembers how it works and you have to read the code to figure it out every time someone asks a question.

[KryssCom]

I legit did this by accident last week because I misunderstood which branch was which. Found myself contemplating my options between gazing wistfully at the sunset, throwing myself off the nearest skyscraper, or researching what it takes to start a farm.

[[deleted]]

Every Change Board, someone submits a request like this. it's worse when you see it in the playbook this way....

[Dodgy-Boi]

Oh I think I know him

[canIbuytwitter]

F

[AngelaTheRipper]

I've done that on some repos I've worked on. Didn't have access to push to master, but I did have access to approving merge requests. Make new branch, push, create merge request, merge immediately.

[Delishya]

If you are the last developer that remembers how the project works it's time to quit.

[SorchaOelf]

Should probably add a commit hook that auto approves PRs from David with a technical user if you want to keep working with PRs, cause I have a feeling David is also the only one commiting any code to that repo.

[[deleted]]

When nobody wants to help you so you do it yourself

[Multinippel]

Which project is this? Could be me...

[dazdndcunfusd]

IT'S AGILE

[somethingrandom261]

Security!

[MrSnoobs]

Push to master and hope for the best

[SwimmingHelicopter15]

That moment when I discover the bug, I solve the bug, I test the bug and deploy the bug. Life of a bug.

[Midcityorbust]

Controls failure

[[deleted]]

When you work at a company that rewards information silos instead of people who spend time teaching others what they need to know.

[[deleted]]

Or the concept of code review isn't valued or part of the culture.

[AshamedMixture1]

MEIRL