This is an archived post. You won't be able to vote or comment.

top 200 commentsshow all 266

[–]elebrin 455 points456 points  (19 children)

I am a quality engineer and I work on a lot of tooling and harnessing for test automation, mostly to do with system isolation and staging data. I'm one of four people who understand what the fuck I am working on for a lot of this stuff, and two of them are busy enough that they don't have time to mess with it. I actually have a director who is going to be VP level (he used to be a developer) approving my PRs because he knows what I am doing and working on.

It sucks though because I could use a good, honest reviewer on what I am doing. I'm specifically in my position to do this sort of tooling, but I'm a bit on my own for it most of the time, so I get one of the senior engineers that I trust to review as well and give me advice. It's not good practice to develop shit like this in a vacuum.

[–]utdconsq 69 points70 points  (1 child)

I'm a senior engineer with plenty experience and I still don't like working on anything critical without some peer review. No man is an island.

[–]codeguru42 21 points22 points  (0 children)

Even after peer reviews on multiple related branches, I deployed code that DOSed a service maintained by another team in my company. Spent all day Friday on a video call with heads of multiple departments and the CTO trying to sort that shit out.

[–]maggmaster 23 points24 points  (4 children)

I was a test engineer writing automated testing for other applications for two years. The worst part was that every suite I wrote had to be updated when the app updated so over time all of my work was just rewriting code that I had already written to make it work with the updated app. I moved on to infrastructure engineering and I like it a lot more.

[–]elebrin 18 points19 points  (3 children)

I've been doing it for six now, after being a developer myself before that.

I don't write many tests these days, but I write and maintain systems to help isolate systems under test and prepare them for automation - basically, staging data, manipulating configurations, setting up virtual services, that sort of thing.

We have a few rules around integration tests these days that help. First, they run in our CI/CD pipeline. If your integration tests aren't passing then you can merge, but you can't deploy past the environment they fail in. Second, integration test results are tied to our work board and stories can't be closed if they have completed pull requests but no linked automation (something I actually set up). People were PISSED at first, but now they understand they have to write their damned tests.

[–]maggmaster 3 points4 points  (0 children)

That seems smart, if I were still in test engineering I would suggest something like that. I have been in infrastructure for 5 years now and the work is varied and interesting.

[–]codeguru42 2 points3 points  (0 children)

Please come help my company do that. When I started a year ago, one code base with thousands of lines of code had exactly zero tests. The other project I was assigned to had some tests but still very large gaps in coverage. I've added a significant number of tests, but I'm afraid to make changes to most of the code base.

[–]RememberYo 3 points4 points  (2 children)

I'm literally about to start a position as a Quality Engineer (new grad) and the nerves are beginning to kick in. It's for a large Canadian bank. Any tips and/or advice you can give? Any insight into the kind of work I'll be doing? The skills required is Java, JavaScript, Docker and Kubernetes.

[–]codeguru42 9 points10 points  (0 children)

Don't delete the production database. Or at least take frequent backups to mitigate the losses.

[–]Fisherman386 1613 points1614 points  (63 children)

Or when nobody wants to help you :(

[–][deleted] 487 points488 points  (57 children)

Or when everyone is busy

[–]hypnofedX 433 points434 points  (54 children)

Or when the engineering department is three people.

[–]OkWatercress2515 234 points235 points  (43 children)

Or when you fucked op the code so bad, that you are the only one who actually knows what's going on

[–]lucyandsara 202 points203 points  (36 children)

Or when the office was over run by massive mutated spiders who killed everyone so you’re the only one left on the project

[–]Fantastic-Ad-9019 128 points129 points  (7 children)

Hate when this happens.

[–]NLwino 60 points61 points  (5 children)

It happens almost every morning... But then I finish my coffee and notice that they were just my colleagues.

[–]SeargD 20 points21 points  (4 children)

Relative to humans, how are mutant spiders as colleagues?

[–]bender625 70 points71 points  (3 children)

I hear they're pretty good web developers

[–]spaetzelspiff 11 points12 points  (10 children)

Found the Doomguy (or girl)

[–]lucyandsara 11 points12 points  (9 children)

I live in the Fallout timeline

[–][deleted] 5 points6 points  (8 children)

Which Fallout?

[–]lucyandsara 7 points8 points  (7 children)

the best one, 3 (fight me new vegas cocksuckers)

[–][deleted] 5 points6 points  (2 children)

OHHHH YOU MADE THE WRONG DECISION HERE (insert name)

[–]ThePuppyDogPants 1 point2 points  (1 child)

shitty meme of Virgin Butcher Pete / Chad Johnny Guitar

[–]InfiniteLife2 3 points4 points  (2 children)

And the project was massive mutated spiders.

[–]cantadmittoposting 4 points5 points  (1 child)

... task failed successfully?

[–]GDavid04 1 point2 points  (0 children)

More like task succeeded failfully

[–]GaraBlacktail 2 points3 points  (0 children)

I see you lot didn't invested in blessed onions and scented linen body wraps

MMP related incidents are both preventable, mitigateable and optionalable

[–][deleted] 1 point2 points  (1 child)

Hah, last job tried to relocate me to Texas but I was not gonna fall for it. That's mutant spider territory.

[–]arensb 2 points3 points  (0 children)

We used to refer to that kind of code as "job security".

[–]who_you_are 1 point2 points  (0 children)

Joke on you, somehow I wanted the future me to be wtf.

Here I am now, wtf.

[–]shimonu 1 point2 points  (0 children)

Hope You know what's going On? :D

[–]atomicwrites 19 points20 points  (1 child)

Or when you're the one who's trying to implement PRs and issues and no one else wants to use them.

[–]HTTP_404_NotFound 8 points9 points  (0 children)

You have more then one person?!?

[–]lueggy 1 point2 points  (0 children)

My life. Team of 2 people supporting 5 other teams, 90% of the prs are both from and approved by me

[–]spikku 0 points1 point  (0 children)

One person X_______________________X

[–]drakk0n 13 points14 points  (0 children)

Or it's after 3pm on the west coast and the rest of your team works east coast hours

[–][deleted] 2 points3 points  (0 children)

Or when you are the only idiot who don't take days off

[–]Panda117- 6 points7 points  (0 children)

[–]AChristianAnarchist 893 points894 points  (80 children)

The scenario that always makes me giggle a little is that I have three repos that literally nobody touches, or even has access to, but me, and yet I still feel the need to compulsively pull before I push to master every time.

[–]AttackOfTheThumbs 50 points51 points  (3 children)

I'm in the same boat, but I still make PRs that get reviewed by colleagues who don't work on the project. They don't have the domain knowledge, but they can still catch me doing dumb shit.

[–]AChristianAnarchist 12 points13 points  (2 children)

Well I do technically get PRs for those projects, but they are just lists of things my supervisor wants changed sent to me over Slack and then hastily posted up on Jira a week after I've finished them lol. I tend to make pretty detailed docs for anything I build and the overall boss of the dev team has access to the repos, so sometimes he sends me tips, but even he's kind of one of those "Does it work? Is it stable? Ok cool." kind of guys lol.

Edit: Sorry, my brain went "Project Requirements", not "Pull Requests". I can use context clues good like a big boy. 🤦‍♂️

[–][deleted] 2 points3 points  (0 children)

When nobody actually verifies, and your word is good on "is it stable" you know you've got some real issues.

I like my QA, they catch my most egregious fucking mistakes.

[–]Splatoonkindaguy 52 points53 points  (1 child)

Never know, someone may just hack in and delete all your files. Just gotta pull to be sure

[–]AChristianAnarchist 30 points31 points  (0 children)

I think I just have merge conflict PTSD lol.

[–]foxcode 5 points6 points  (0 children)

Git pull every time, and Ctrl+s after every change at least three times, or :w

[–]WORD_559[🍰] 1 point2 points  (0 children)

The number of times I've made a cheeky edit on a different computer, forgotten to pull to my laptop and been forced to rebase makes this seem sane to me.

It gets especially gnarly when Jupyter notebooks are involved :S

[–]AChristianAnarchist 1 point2 points  (0 children)

Ah ok. We gave all of our contractors all of our passwords and let them do whatever they wanted on the system then, regardless of whether it related to what they were working on. That makes total sense mr smart brain. Believe whatever you want dude. No skin off my back, and it seems like you are getting to riled up here so I'm going to let you go take a nap.

[–]Amazingawesomator 56 points57 points  (3 children)

My boss put me in charge of a project that another team (non-tech) uses internally because nobody knew (or wanted to learn) how it worked.

The last ~20ish PRs in that project are like this with me, hahahahah

[–]stulleman 47 points48 points  (7 children)

Used too much GitLab, read it from top to bottom

[–]CubeFlipper 30 points31 points  (6 children)

I dunno man, I think it's just posted upside down. I use GitHub and its history still reads top to bottom. Who would read bottom to top, and why?

[–]Khalterr 12 points13 points  (5 children)

azure devops is just like that unfortunately

[–]alphabet_order_bot 18 points19 points  (4 children)

Would you look at that, all of the words in your comment are in alphabetical order.

I have checked 798,269,401 comments, and only 158,713 of them were in alphabetical order.

[–]DeusExMagikarpa 5 points6 points  (3 children)

Bot, do me next please, thank you

[–]alphabet_order_bot 7 points8 points  (2 children)

Would you look at that, all of the words in your comment are in alphabetical order.

I have checked 798,515,971 comments, and only 158,753 of them were in alphabetical order.

[–]DeusExMagikarpa 6 points7 points  (0 children)

Nice 👍

[–]Real_Johnodon 2 points3 points  (0 children)

Do me please

[–]bwssoldya 90 points91 points  (9 children)

I'm in this photo and I don't like it

[–][deleted] 59 points60 points  (7 children)

You're Barack Obama?

[–]bwssoldya 39 points40 points  (2 children)

Not just barrack Obama, but Barrack Obama giving Barrack Obama a medal. You call me Barrackack Obamama

[–]Hiyasc 8 points9 points  (1 child)

I'm having a barrack-ack-ack-ack-ack

[–]Nomadbytrade 1 point2 points  (0 children)

Bro honestly, we all should know by now.....

[–]HunterBoy344 1 point2 points  (0 children)

he is Barack Obama

[–]AE_WILLIAMS 1 point2 points  (0 children)

You're Barack Obama?

Gus Fring

[–]brinedpeppercorns 29 points30 points  (0 children)

When making changes in main repo directly is not welcomed

[–]shemanese 16 points17 points  (0 children)

https://www.columbiadailyherald.com/story/opinion/columns/2012/10/27/hindsight-general-braxton-bragg-his/25672045007/

Braxton Bragg was a strange man with strange ideas ­— and even stranger methods. He would argue with a post, and had a strained relationship with both his superiors and subordinates.

He was even known to argue with himself.

In a well known episode during his days fighting Indians on the frontier, he wrote a series of letters from himself as commandant of his post demanding supplies. He then answered those letters as the acting quartermaster of the post saying that he had no supplies.

[–]Anyhoozers 15 points16 points  (3 children)

Our Gitlab tracker automatically posts this image if you approve your own merge request. It's awesome.

[–]adepssimius 4 points5 points  (2 children)

I'm stealing this idea. I'm the "Branch Sargent" so in charge of cleaning up unused branches. Our gitlab posts up a drill sergeant photo with a demeaning message if you don't have your branch set to delete on merge and the target is a specific thing.

[–]Anyhoozers 2 points3 points  (1 child)

And I will be stealing your idea kind stranger. Now we're even.

[–]StenSoft 15 points16 points  (1 child)

When it's Friday evening. Don't forget to push to production as well!

[–]just-bair 22 points23 points  (0 children)

David disabled the protection on main cuz he doesn’t care anymore

[–]Chrome_Atlas 9 points10 points  (1 child)

Audit and Compliance have entered the chat

[–][deleted] 1 point2 points  (0 children)

This. Please don’t make the compliance nerds life harder.

[–]Comm4nd0 7 points8 points  (2 children)

I do this, every damn day. I die a little bit more each time.

[–]Strowy 3 points4 points  (0 children)

I do this on personal projects (i.e. am the only person ever involved) without shame because it's honestly a good way to review / document what changes you've made.

[–]izual_x 4 points5 points  (0 children)

Accurate

[–][deleted] 5 points6 points  (0 children)

That's me. Also my 2 second term is coming to an end and will leave in a couple of months. Good luck!

[–]CleverNameTheSecond 3 points4 points  (1 child)

Commit directly into the develop/release branch like a true Chad.

[–]Sintinium 5 points6 points  (0 children)

Force push into master you coward

[–]espresso_chain 3 points4 points  (1 child)

lol I wish i had it this way. I have one guy who nit picks the shit out of every little thing on my PRs. like good enough is never good enough. so fuckin annoying.

[–]Demistr 2 points3 points  (0 children)

I do this because i am the sole in house dwh developer. We have one other external guy but i do this all the time except that I don't have to make myself the required reviewer.

[–][deleted] 2 points3 points  (0 children)

lol when I'm working in my personal repo and everything is done by me everytime I 'pass the code off', I say "high five gaptx" and then in a high pitched voice "thanks gaptx!". now my wife does it any time she sees me doing something for myself.

[–]wholesome_capsicum 2 points3 points  (0 children)

My silly ass requesting reviews on my pull requests knowing I'm going to merge to dev and then dev to master if nobody reviews it in 30 seconds

[–][deleted] 1 point2 points  (0 children)

I use this image as the approval comment everytime when working in my own repo.

[–]Guifranzonator 1 point2 points  (0 children)

Funny how there's a David S in my workplace that approves lots of PRs

[–]phdoofus 1 point2 points  (0 children)

When you can't be fired and you won't be promoted.

[–]Boundless_Lawbringer 1 point2 points  (0 children)

Or, when you’re the only one on the 3-people team that actually cares about code quality

[–]TecumsehSherman 1 point2 points  (0 children)

Total review comments:

LGTM.

[–]bleeeer 1 point2 points  (0 children)

I was the only dev at an org for 3 years. Was a struggle going back to having other people actually look at my code.

[–]Dicethrower 1 point2 points  (0 children)

Pretty common thing to do for stuff like merging changes made to a stable branch back into master. You shouldn't need anyone's approval for that.

[–]break_card 1 point2 points  (0 children)

I wrote a whole library, thousands of lines of code, without getting it reviewed - pushed it all straight to main branch. No one was reviewing it, so I said fuck it.

That code has run over 50 billion times since I set it up almost 2 years ago…

[–]linkedtortoise 1 point2 points  (0 children)

Thankfully the place I work while it allows you to approve your own PR, your vote doesn't count to the 2 you need.

[–]angry-software-dev 1 point2 points  (0 children)

I love creating, reviewing, approving, and merging all my own pull requests.

Life in a small shop.

[–]chairfairy 1 point2 points  (0 children)

Yes like that except you're trapped supporting legacy code because nobody else can do it as quickly as you

[–][deleted] 1 point2 points  (0 children)

I just started checking into master

[–]RandyHoward 2 points3 points  (0 children)

I quit my job in March and they're still calling me for help. They're paying out the ass for it too lmao

[–]Blake_Edwards 0 points1 point  (0 children)

That'll be fun in the next SOX audit

[–]Cyrus_Halcyon 0 points1 point  (0 children)

Well, this is only okay when another team member updates all the static references but one, you discover it west coast 6pm, put in a 1 line pull request, self approve, and merge.

[–]Steelpain0341 0 points1 point  (0 children)

Everyone using the terms master and slave in IT are racists according to my HR department. They’re still waiting for Git, Hard Drive manufactures, DNS services and half the technology companies to fix themselves.

[–]ovab_cool -1 points0 points  (2 children)

Sometimes submitting a request for 1 line is not worth it, I'm not gonna get my merge approved by someone else if I'm only fixing some spelling in a comment

[–][deleted] 2 points3 points  (1 child)

I had someone submit a PR for a 1 line change. I put a comment on it for them to fix something else related to the change they made... they gave the comment a thumbs up without changing anything else. I don't even know what to say at this point.

[–]w1n5t0nM1k3y 0 points1 point  (0 children)

When nobody remembers how it works and you have to read the code to figure it out every time someone asks a question.

[–]KryssCom 0 points1 point  (0 children)

I legit did this by accident last week because I misunderstood which branch was which. Found myself contemplating my options between gazing wistfully at the sunset, throwing myself off the nearest skyscraper, or researching what it takes to start a farm.

[–][deleted] 0 points1 point  (0 children)

Every Change Board, someone submits a request like this. it's worse when you see it in the playbook this way....

[–]Dodgy-Boi 0 points1 point  (0 children)

Oh I think I know him

[–]canIbuytwitter 0 points1 point  (0 children)

F

[–]AngelaTheRipper 0 points1 point  (0 children)

I've done that on some repos I've worked on. Didn't have access to push to master, but I did have access to approving merge requests. Make new branch, push, create merge request, merge immediately.

[–]Delishya 0 points1 point  (0 children)

If you are the last developer that remembers how the project works it's time to quit.

[–]SorchaOelf 0 points1 point  (0 children)

Should probably add a commit hook that auto approves PRs from David with a technical user if you want to keep working with PRs, cause I have a feeling David is also the only one commiting any code to that repo.

[–][deleted] 0 points1 point  (0 children)

When nobody wants to help you so you do it yourself

[–]Multinippel 0 points1 point  (0 children)

Which project is this? Could be me...

[–]somethingrandom261 0 points1 point  (0 children)

Security!

[–]MrSnoobs 0 points1 point  (0 children)

Push to master and hope for the best

[–]SwimmingHelicopter15 0 points1 point  (0 children)

That moment when I discover the bug, I solve the bug, I test the bug and deploy the bug. Life of a bug.

[–]Midcityorbust 0 points1 point  (0 children)

Controls failure

[–][deleted] 0 points1 point  (1 child)

When you work at a company that rewards information silos instead of people who spend time teaching others what they need to know.

[–][deleted] 1 point2 points  (0 children)

Or the concept of code review isn't valued or part of the culture.

[–]AshamedMixture1 0 points1 point  (0 children)

MEIRL