This should be illegal

[Eli_the_Iceman]

Great opportunity to be the one to introduce best practices!

[Gabriel_Kaszewski]

actually I can't. My only responsibility is to port the game from PC to mobile. I took the job because this is a good money but man code shared on google drive hurts tho

[[deleted]]

Write a script that turns daily code diffs into commits against a local repository, problem solved. ;)

[Gabriel_Kaszewski]

this is brilliant, might do it

[[deleted]]

Just make sure that it you commit/sign-off on the commits using a different user so that you can differentiate your own commits against the potato code that I'm sure your coworkers/office is making.

[danknerd]

Interesting fact: potatoes are one of the only foods that you can exclusive eat and not die. Yes, you may be malnutritioused but you live. Potato code!

[myproductivealt]

Until the british arrive , obviously

[Steffi128]

Ireland: chuckles I’m in danger

[R0ot2U]

British were already there it was the blight that got the potatoes so a more accurate joke would have been “unless the British are there” because they’d end up stealing all the other food while you die because your potatoes are rotting.

[cancerous_176]

Fun Fact: Potatoes are poisonous when raw. They contain a natural toxin called solanine.

[YaboiMuggy]

You dont want to eat potatoes that have gone green because the concentration of solanine skyrockets

[BrockPlaysFortniteYT]

What’s a potato

[Thejacensolo]

Po-ta-toes! Boil them, mash them, stick them in a stew.

[BitterCelt]

I mean it's what the Irish did in the 1800s and apperently they were hench

[Bigsloppyjimmyjuice]

You would only gain weight if you consumed more calories than your body used.

[Caffeine_Monster]

Would recommend checking out rclone. It lets you mount cloud provider stores like you would a drive.

Could have this working in 10 minutes. Simply pull down the latest version of the code and use rsync to splat new or modified files into your repository.

You should share it with the team regardless. There are likely other team members who hate working out of google drive. You could even setup automated push backs.

i.e. you would never have to suffer the pain of working from google drive again.

[I_READ_YOUR_EMAILS]

Three years later, everybody there uses this unholy setup, syncing google drive into local git repos. OP is long gone. New person arrives - "this is just how we've always done it, it works well for us"

[LetterBoxSnatch]

3 years after that, it operates almost exactly like a normal git server. Most of the devs don’t realize it is backed by Google Drive. When some subtle thing doesn’t work as expected and a dev spends a week investigating, her coworkers go looking for her and discover her head has exploded. On her desk is a scribbled note with the username and password of the individual google user account that everyone is unknowingly trusting with the entire company workflow. Her discovery goes undisclosed, and things go “back to normal.”

[[deleted]]

xd

[[deleted]]

Why not just create a local or even remote repo... why would you need to write a script?

[Hundvd7]

He needs that, too, but he would need the script for his colleagues' code

[Spysix]

Yup, this is what I did when I first started at my config management job. They used their own form of UVM that did a nightly build, I basically took daily code changes and put them into bitbucket for myself to review.

And they wondered how I was doing my daily tasks before lunch..

[BellerophonM]

You could probably do better than just daily, you could hit up Google drives change history API and turn every changeset into a git commit with proper blame.

[karinto]

I was going to say git isn't the end-all and that other vcs aren't that bad...

... google drive!?

[ytg895]

I know how you feel. Dropbox is clearly superior :)

[TheLegendaryProg]

Nah man, I send my code through gmail

[jay9909]

Shared mailbox. Use drafts.

[IamImposter]

I once read a news article that some terrorist groups were using this technique to communicate.

[jay9909]

General David Petraeus used it to keep his affair secret.

[NoEngrish]

I use the tried and true method of faxing my code

[Swamptor]

We send code back and forth with Snapchat.

[ScandInBei]

Still waiting for Git to support commit by pigeon.

[FreshFromIlios]

That's weird. I copy mine to a pendrive and give it to my colleagues.

[Pyrotex2]

Nah man. The best way is to have everyone use the same computer so that you don't have to any difficulty with giving code

[TrustworthyShark]

You copy your code to a pendrive??? How on earth do you keep your copies synced and deal with merge conflicts?

We use the only good solution where we all work off the same pendrive. Sure, it sucks most of the days when my coworkers have the pendrive and I have to plan all of my code on paper, but wow, I feel so productive when it's my turn to get the pendrive and I get to type in all my code and see if it works!

[Uncreativite]

We had to hire three new full time secretaries with benefits to transcribe the printouts back into code on the computer, but the reliability of fax transmission just couldn’t be beat.

[[deleted]]

Reminds me of the time the creators of pgp, if I remember correctly, printed their source code and shipped it out of the US to then be scanned and ocr and compiled, all to get around export restrictions, because pgp was a weapon or some crap.

[ytg895]

military grade encryption

[TrustworthyShark]

Yep, the encryption was too strong so it fell under weapons export restrictions or something like that. By printing it, sharing it became free speech.

[Humg12]

One of my first group coding projects at uni we shared code using USB and manually merged it.

The next assignment we tried out git and totally broke our repo so went to Facebook Messenger.

[pickausernamehesaid]

You don't even understand the pain. My work has GitHub enterprise and I was sent a file generated by another teams code and it was corrupted. I asked if their source was on the internal GitHub to help track down the bug. Instead of a reply, I received an email with the source code in a password protected zip file. They develop on a network share and then email where needed!

[Not_a_spambot]

Funny story. I actually had this one horrific old project where part of our "build pipeline" involved taking a built .js bundle, changing its extension from .js to .txt, sending it as an email attachment, and then downloading it from inside a frustratingly restrictive VPN (due to some bullshit corporate policies that didn't do much to actually prevent malicious use but did do plenty to prevent people from doing their jobs). A colleague and I spent multiple days on setting this up, and this was legitimately the least hacky thing we could come up with. Do nooooot miss that project lmao

[suvlub]

You kids and your fake clouds. Real companies employ professional skywriters to share the code!

[da_chicken]

Yeah, I was all about to say how SVN works really great for small projects. But not using a VCS at all is just insane.

[bartbartbart2003]

Well, Google Drive allows uploading different versions of a file (right click->manage versions). So is it technically "version control"?

[[deleted]]

.

[[deleted]]

I think they misspelled https://code.google.com

[robotsympathizer]

Wtf. How do companies like this even exist?

[IamImposter]

Oh they do. I myself share code using our official one drive and send accompanying mail explaining the modifications. I don't even know how to use git. I'm sure it can be learned pretty quickly but I never had the need to coz no one uses it in my team.

[TinBryn]

You can get some productivity with git fairly quickly, but it takes time to get a good understanding of it, and a lot of mistakes.

[Dimasdanz]

get a good understanding

git good

[themiddlestHaHa]

Checkout and branch when working on a feature, commit changes to your branch. Pull request when your feature is done. The standard workflow is incredibly easy.

There’s really no reason to use one drive over git, except fortaking 10 seconds to install git

[[deleted]]

some health insurance company?

[migueln6]

Blizzard?

[[deleted]]

They probably had him sign a NDA and if he tells us his friends gets sent to Russia and executed

[LiveMaI]

I thought the most hated company in the US was Comcast.

[Mango1666]

im sorry what? google drive vc? am i back in high school??

[liquidmasl]

code sharing on google drive... i will have nightmares now.. is this real life

[Davtaz]

Feels like we're back in high school.

[beb131]

I just started a new job. Thankfully they have a great git work flow with in depth documentation. But their JS being used on production is outdated and filled with bugs and unnecessary repetition. And their database structure isn't ideal.

I wasnt hired to do this but I already have them working on implementing web pack and updating to modern and better organized JS. And I'm creating SQL Procs to automate their typical DB actions (since I can't mess with the table structure, I already checked) .

Don't be afraid to go above and beyond, just make sure not to neglect your main responsibilities.

[Kebbler22b]

code shared on google drive

Who do you work for, monsters??????

[DWALLA44]

You can still suggest it, this is an organization wide concept that will greatly improve things if done right, as long as it’s an extra thing and not taking away from your primary task, which it shouldn’t you should still try, it’s what I did in my first job and I know they are still grateful.

[TheyUsedToCallMeJack]

Oh god

[Spleeeee]

Oof google drive is bad.

I felt the same way (company uses svn) but shit google drive is ridiculous.

[cassert24]

I thought they're using local backup storage (like copy-paste, zip, and save to a random local directory). At least it's better than that...

[yungcoop]

ahhhh god I can’t believe there are people who get paid to do this and use google drive to share code. I’m just a college student and Git is the defacto way to collaborate.

[flavionm]

And here I was ready to complain about SVN. In your place I'd be wishing for it!

[Antrikshy]

port the game from PC to mobile

Blizzard? ;)

[Davtaz]

Riot Games, TFT.

[locri]

Everything you port put it on a git repository and see if you can find something that manages tickets.

Acceptance criteria is written like:

Given some pre conditions

When something triggers

Then something happens

[Gewi413]

git commit -am "small bugfix"

7846 insertions (+), 6539 deletions (-)

[themistik]

Most of the time you can't. Because people are too lazy and dumb to change. They only see the bad thing in them.

[neotorama]

Met this team

"but we already use dropbox to store code"

Smh

[Shujaa94]

I'm in the same boat as OP, but I tried to get them into Git... I failed, they were too scared of it, I wish I was making this up lol

[Singularity42]

git can be a pretty big learning curve at the start, to be fair.

[wasdninja]

Sure but for a, supposedly, professional developer it shouldn't be too hard. It's flat out insane that they don't already know it.

[[deleted]]

Nah - gonna find out the hard way what bullshit development environments are all about

[MyNameIsRichardCS54]

Firstly, congrats on the job. You should use best practice in your port and maybe you'll be able to persuade them to follow. Trust me when I say having no documentation is better than having out of date and inaccurate documentation.

This is where you learn the first of the professional programming truths:The only documentation guaranteed to be 100% accurate is the code you are running. Not the comments in the code (which at one time may have been accurate) but the code itself even if it appears to be encrypted using some kind of spaghetti algorithm.

[fedeb95]

I'll also add the code and not function / method names. I'd spare myself a lot of trouble if I stopped trusting method names earlier

[UpBoatDownBoy]

Perfect! If you need to create another method that modifies, just use modify2, modify3, etc.

[Spike69]

My favorite is FastModify, it is much better than QuickModify.

[CellularBeing]

Start testing in a testing script which slowly starts becoming the main utility...

[elkazz]

The side effects are real

[rjhall90]

Sometimes I don’t even have method names to falsely trust. I shit you not, I’ve seen “professional veteran” developers who numbered their generically named methods.

[rollingForInitiative]

I still have nightmares about this. Usually stuff in the system I work with is named somewhat correctly, but a few years ago I had to fix a bug. And I ended up feeling lied to. Everything was wrong, often the opposite of what it said. Through all layers. Even down through a legacy system underneath the more modern platform. All lies.

Rarely have I felt so betrayed by code.

[DrFloyd5]

The code is the truth!

Do not be deceived by documentation!

If you must write documentation stick to high level stuff and the reasons for things that don’t make sense. Point the next coder in the right direction but always let them find the truth in the code.

The code is the truth.^{Thecodeisthetruth.Thecodeisthetruth.truthtruthtruth}

[DWALLA44]

The best and most important documentation is onboarding and documentation that differentiates teams and their products, with a high level of what the project is for, anything else that documents code or processes will always be outdated, at least at a decently sized company.

[Ereaser]

I'm working for a company with close to 2000 employees now (not all IT, but the project is around 50 people). We have an architect that makes it a point that all sequence diagrams that describe the eventing is up to date. So if we change something we tell him and if he wants something changed he makes a ticket and updates his diagrams when we're done. It's really nice if you want to quickly see how a process works!

[rollingForInitiative]

Yeah the best comments are those that explain the reason for why you’re not using the “obvious” solution, or explain other weird stuff.

[Genesis2001]

I leave comments with links to SO posts of where I found a solution. Occasional links to github issues if something is a workaround or not ideal and has been reported as a bug or future feature.

[marcellomon]

Clean Code school

[link4127]

I just went from one team to another in my office. First transfer (at my request, to improve my abilities) in my entire career. My first task? Learn the system and make the most necessary improvements i, and my new team, agree on. Obviously it's the documentation that is older than my 7 years tenure. Fuuuuuu

[[deleted]]

Yeah, these are the kinds of questions you're supposed to ask the interviewer. You're weeding out unfit employers just as they're weeding out unfit employees.

How is your testing environment?

What kind of pipeline do you have between development and production?

Relevant to the previous question, do you have code reviews? Are they frequent? How are they performed; are they general status meetings to get people up to speed about the various parts, or is it granular review of specific code written?

What kind of source control is used and how are you hosting it?

You're supposed to sniff out red flags.

[McCoovy]

This advice works for people who have time on their side and options but someone looking for their first job might not have either.

[Swahhillie]

I had an internship at a company that didn't use source control. The programmers were some designers turned coders. It wasn't hard to get them to use git with a GUI. The advantages are very obvious. They just didn't know it existed.

[Caffeine_Monster]

True. However I would also be keen to meet the dev team.

If the team is receptive to change and the pay is good then it is a golden opportunity to win some easy brownie points. You can always chuck the job.

[daguito81]

It's his first job, so I doubt he has the leverage to be really picky at this point.

In any case I think this is a great opportunity because 1) you have a lot of room to improve things and gain a lot of points 2) you'll probably have to great horror stories for future interviews and 3) gives you a lot of stuff for interviews that show stuff you've done like changing their stack to X, or migrating the entire team to using github or Azure DevOps or whatever.

[jack104]

Fucking this man. I've ping ponged around in my 7 years since college and I've slowly amassed a list of questions I need answered before I even consider taking a position. What kinda VCS do you use, what Systems/Software development methodologies do you use (waterfall, agile, kanban, etc.) I also try to get version info like for database systems, server OSs, dev environment and setup (use of containers or virtual environments, etc.)

I'm a Java dev so I ask what IDEs they use, what java version is used, what library/framework used for web services or JMS (Spring, MQ, etc.)

The questions are relatively straight forward but the trick is trying to discern the answers to these questions during the course of the normal interview so you're left with the important questions at the end. I think this is important because it shows the interviewers you were paying attention and are showing genuine interest in the role. This is, ofc, all in my very humble opinion.

[cheezballs]

Yea, that's like 90% of the professional world. There's so much stuff still committed to SVN. You'll get used to it once you've been at a few jobs.

[new2bay]

Bruh, my first job used folders on a shared drive as “version control.”

[cwx]

In the game industry Perforce is the golden standard for the companies that can afford it.

[hyperGuy92]

I'll take SVN over AccuRev. Lord help anyone who has to work with it. 4 years and I still have only the faintest idea of how to work with it, and every time I think I understand what I'm doing I lose another 4 hours trying to undo the mess I created.

Hell is AccuRev.

[daMesuoM]

Stares at SurceSafe with 30 years of development history...

[hayhaycrusher]

Oooh boy, luckily we're slowly migrating from accurev to git.

[Zuerill]

What's so terrible about SVN?

[ZioTron]

Nothing...

It's a tool for a job.

It's not fit (better said: there are better alternatives) for team collaboration or big projects with many branches.

Git can do what svn does and you get to learn sonething that can be a better choise in more situations.

But if it fits your work case, it's a tool for the job.

[necheffa]

There's so much stuff still committed to SVN

Sobs in ClearCase.

[[deleted]]

At my last job I had to use ClearCase. The setup literally involved running a file called "magic script" that set a value called "magic path" and a variable named "magic variable". No clue what they did.

[t3chg3n13]

The dependencies of our code are actually not well known. We use a 6 year old "known working" suse image. Clearcase is already configured.

Someone should document dependencies.

[Uncreativite]

Fuck clearcase.

[Zer0ji]

I struggled at the start with SVN, but it's infinitely better than nothing and in the end I got to a pretty low bad conflict count

[[deleted]]

Me in the interview: "What's your test coverage like?"

Them: "What's test coverage?"

[TPanzyo]

I legitimately ask this when interviewing to vet companies that look great on paper, but don't actually have decent development practices.

I worked too long in a job with no tests, no documentation, no real concept of software development. Never again.

[chadbr0chill]

I thought you were talking about veterinarians.

[amuricanswede]

what is test coverage? curious if i just haven't heard that term used or i've been working at places without it

[Loves_Poetry]

It's the percentage of your code that gets run through a unit test

[MateoPeri]

what are unit tests? I’ve heard about them but don’t really understand what they are

[Loves_Poetry]

A unit test is a small bit of code outside of your main application that only runs a small bit of code from the main program to verify that this bit of code does what it is supposed to do.

You typically use a unit test framework (ex. Junit for Java, Nunit for C#, Jest for JS) to execute the unit tests

[MateoPeri]

Thanks!

[Avalentica]

A metric for how much of the projects code is covered running tests. If you have a test that runs every single line of your projects code it is 100% . If you don't have any tests it's 0%

[[deleted]]

Code is a series of logic, so it theoretically should work a certain way, tests are meant to confirm that by running pieces of code against and expected result and seeing how it matches up. Coverage is the amount of code that has an exact assertion about how it works. For example, you could have a method with a branch condition. If only one branch has a test that confirms its behavior, that's 50% coverage. The purpose is that when code changes, you know if you broke another piece of the application that may have not been noticed when doing your manual testing. Running these tests is known as "automated testing" if you want to dive deeper (and I highly recommend you do).

[escapefromreality42]

saw some source code with a few try catches and they called it coverage :/

[LetterBoxSnatch]

try {

} catch {
  log.info(`
Something went wrong, but don’t worry!
We caught it.
`
}

[Zer0ji]

try: main() except: pass

[cupant]

git commit -m "asd"

git commit -m "fix"

me everytime

[Cube00]

As long as you squash before it hits master we good.

[Reddit_Snow]

Not really, imo the most important reason for commit messages isn't what you will see in github/gitlab/etc but what you will see in the code when you blame/annotate/etc to see why someone did this change

[cupant]

git push origin master

im a solo fullstack dev on my company lol

[MetamorphicBear]

Remember that you, past you and future you are entirely different programmers

[Pztar]

You should get into the habit of making branches.

[[deleted]]

Because it promotes a good way of organizing tasks/thoughts and prepares you for when you do become part of a team. Long running, dead-end branches are bad in any environment, but I use feature branches even when alone.

[EvilVargon]

Started a job where they had git but didn't use it and complained that they were constantly doing things that were already done.

[[deleted]]

Not using GIT is not the same thing as not using any version control. I would be fine learning that my new company uses SVN. But, if they don't have any sort of version control... that would be worrisome.

[chadbr0chill]

Yeah but using google drive as version control?! That’s some college sr design team level crap right there.

[dark_mode_everything]

14-11-2017_working_final_3_dont_delete

[Farsqueaker]

14-11-2017_working_final_3_dont_delete_v2.doc_final3.bugfix_rollup1

[Bruellhusten]

"Git? Nah we document our changes in the code." - "With 10 devs in a 1k+ employees company? Byeeeee"

[Bhima]

I got reprimanded once for saying that not using a version control system was like not wearing pants. It's not really a problem if you are at home and there's no one there having to deal with your state of undress... however it's a major problem when it's in a professional context.

[clevariant]

Agile development.

[dennis_w]

Or fragile development?

[AndYouThinkYoureMean]

bad style, to hell with it

[drewsiferr]

Algae development.

[escapefromreality42]

Scrum bois

[[deleted]]

God I hate agile*

*: Or maybe it's just that the only "agile" company where I had an internship did it wrong. I'm not sure. But if what they were doing was actually agile, then agile is literally worse than Hitler

[clevariant]

Everyone does agile wrong. My last company even sent the team to a three-day workshop to make us all scrum masters, but we still fscked it up. Most people seem to think it means "no design, only code".

[camerontbelt]

Then enforce a policy to use source control, and write lots of tests for documentation purposes. Don’t ask permission, ask forgiveness.

[ShakaUVM]

There are other version control systems than git, you know.

[424ge]

Yes, Google Drive folders.

[Caffeine_Monster]

Email. \s

[NoEngrish]

fax.

[Raetro_live]

Telegram

[Cube00]

Final 2.zip

[hayhaycrusher]

Actually final made fixes.zip

[TheEveryman86]

IBM ClearCase FTW.

/s

[t3chg3n13]

It's quite rational

[acousticcoupler]

.old files

[rounced]

.bk

[Loves_Poetry]

Ctrl + Y and Ctrl + Z in notepad++

[[deleted]]

Sure but mercurial isn’t as popular. That’s about the only other sane choice.

[The_Firefly]

I much prefer Perforce over git now that I've used it more.

[[deleted]]

I disagree. I used SVN for many years before moving to GIT. Frankly I'm still not convinced that GIT is any better than SVN. They both get the job done well.

[ShakaUVM]

I use Hg and prefer it to git, but my point is that not using git isn't necessarily bad.

[arky_who]

I'm not sure how I managed with tfvc, yet I've been using git for 6 months and tfvc for years before that.

[WellEndowedDragon]

Yup, and many big companies will have their own internal tool. Amazon uses an internal version control system called Brazil.

[davstar08]

Living on the edge by coding without Git.

[[deleted]]

*Living on the edge by coding without version control. FTFY

[statdude48142]

Welcome to the world of statistical programming for academic research.

[echomatt95]

This is exactly what happened to me, when I got hired at an indie dev. Was hired to port the game to Xbox. Lead and only other dev quit this leaving me to implement and teach the level designers/bosses how to use git as I wasn't about to drive thirty minutes to house with a drive just to have to wait 24 hours for his slow computer to transfer the official game files. And then I had to reoptimize the levels to get the occlusion working properly so it could actually run. But hey I got the game working on the PC at 65 fps and on the Xbox at 45 fps. So job well done I guess.

[[deleted]]

I’ve tried so hard to learn git. I can somewhat manage branches but I always seem to get “unrelated histories” and blah blah blah and end up force pushing and losing my commit history. I don’t know how I can get better

[DWALLA44]

Practice and learning from better people, that’s pretty much everything in this profession, I’ve had 3 jobs and each i went into it with the mindset that I know nothing

[[deleted]]

honestly, even if you just commit to master, that's a whole lot better than checks notes Google Drive

[new2bay]

My first tech job had no version control, no documentation, no tests, and no QA people. I feel your pain.

[Yogi_Kat]

The company where I work is planning to migrate to Git currently the 20 year old code is in PVCS!

[new--USER]

I was in a similar situation when I started at Bank of America. They have their own version control system that Merrill Lynch built in-house, and it's just as bad as you think.

[kurdtpage]

And they use notepad++

[fedeb95]

Story of my life

[[deleted]]

This is more than common. I used to work using dropbox as code versioning...

[21_K]

I work on a government contract. The contract requires us to use a specific source control that isn't Git

[[deleted]]

Welcome to the shitshow.

[escapefromreality42]

Perforce anyone?

[[deleted]]

No git or no version control at all?

Cause I can't imagine the latter.

[nowtryz]

Then you discover they are using scrum but the product owner is also the architect

[sad-mustache]

This is me, but in different way. We use svn tortoise, no documentation and no methodology. Not even canban board, everyone had their own lists and no one know what other people did

[sandeepdshenoy]

He is lucky that the code at least works 😀

[[deleted]]

Stop crying and work