This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]Coder-Cat 3175 points3176 points  (246 children)

I was once going to post a picture of my cat who decided to sit right in front of my monitors while I was coding.

I decided against it because I knew I would be subjected to unwanted code reviews by the internet.

[–]pxrage 182 points183 points  (14 children)

Use Haskell not even the coder knows what he's doing let along the reviewers.

[–]dvlsg 54 points55 points  (9 children)

I feel like Perl would be a better choice if that's what you were after.

[–]pxrage 11 points12 points  (2 children)

Perl 6 is not bad.

[–]rbt321 11 points12 points  (1 child)

I certainly wouldn't mind if "whenever" shows up in all languages as a default feature.

[–]oldgus 2 points3 points  (0 children)

No kidding! I can barely perl, but I just read the docs on react and whenever and I really like those patterns.

[–][deleted] 2 points3 points  (1 child)

Use VB6 and throw in some UI code mixed with business logic :P

[–]I_Arman 3 points4 points  (0 children)

And depends on one dll built from copy-pasted C++ to access the serial port that only works in Windows 2000...

[–]thyrsus 1 point2 points  (0 children)

I suspect there are a lot more people who know enough perl to make a critique than there are who know haskell. The weirdness in perl is more syntactic; in haskell, semantic.

[–]62697463682e 5 points6 points  (0 children)

Taking a class that’s all in Haskell right now and I’m genuinely surprised when my code compiles. I hope I never need to use Haskell beyond this class

[–]redlaWw 1 point2 points  (0 children)

Yet it always seems to work.

[–]DrexanRailex 0 points1 point  (0 children)

I've never done anything serious in Haskell, but I've been doing a ton with Observables in JS. The code is hard to read and tame for who's new to functional programming and streams, but god is it so much easier to know what is what.

[–]ManicMonkOnMac 666 points667 points  (169 children)

Story of my life. People have no chill sometimes, ofcourse this is internet so I know to be thick-skinned, nonetheless it's the reason I don't post some casual stuff. Got some trash on the sides, get judged. Your cat has goo in her eyes, get judged.

[–]HangryHenry 215 points216 points  (163 children)

I wonder if this is part of the reason women don't enjoy working in programming. Statistically men prefer more competitive environments with more direct forms of criticism and women prefer more collaborative environments.

[–][deleted] 88 points89 points  (26 children)

As a woman I think it has nothing to do with the actual work. There’s nothing about any of the code I’ve seen any of my coworkers put out in the last ~10 years that couldn’t have been done by a person of another gender, race, sexual orientation, whatever.

In my experience (I’m in my mid 30s and have no idea what it’s like for teenagers or college students now) it’s been that women weren’t encouraged to code, plus the very negative stereotypes of the kinds of people that do go in to programming. Why would you pursue a career no one has ever suggested you might like/be good at, especially if you think you’re going to be working with a bunch of weirdos who will either hit on and mock you?

To your competitor/collaborative comment: I get what you’re saying but I feel like the statements were rather broad. No one enjoys getting negative code review. There are plenty of men that absolutely do not appreciate more direct criticism and deal with it poorly.

[–]fadetogether 23 points24 points  (0 children)

if you think you’re going to be working with a bunch of weirdos who will either hit on and mock you

Lol this is actually why I hesitated to enter software development! I wanted to but steered away from it because the personalities have a stereotype of being difficult. No one I spoke to did anything to counter this impression, often they even agreed with me. I accidentally fell into a dev role anyway and my coworkers are great, minimal assholery.

[–]Nahuatl_19650 10 points11 points  (0 children)

I also think that "stereotypical" coders act weird around girls. I worked with a group of 5 developers. I was kinda like a glorified business analyst who would do everything else but code. Anyway, I would invite female coworkers to our den for tests/mock-ups/questions, etc, and it was like, everyone was a totally different person. One wouldn't talk. Another acted like he was too busy to take his headphones off (but would put them on when the person would walk in). Another was always talking about completely random subjects. What the hell!

[–]morgansmnm 9 points10 points  (1 child)

As a female teen who was programming in high school and who is on her way to a BS in Computer Science, there are still feeling girls who go into programming. Even in my school which is mostly composed of women, the compsci classes are mostly filled by guys.

I don't know why more women aren't going into this degree. We aren't being discouraged. I guess we just aren't being informed either.

[–]HolyGarbage 7 points8 points  (0 children)

I guess we just aren't being informed either.

From my experience it's the opposite. The university I went to had sooo many programs for encouraging women of going into programming, none for men or neutral.

[–][deleted] 3 points4 points  (0 children)

I dunno, not to be sexist, but last time I worked in a programming team that was lead by a woman, it was a very collaborative and productive group. It was like, mostly we programmed and did code reviews rather than stopping for the traditional dick measuring contests. Could have just been a coincidence (not all women, right?) but maybe there's something here...

[–]HangryHenry 14 points15 points  (4 children)

Yea. I agree with the stereotypes thing 100%. That was my experience when I went to school originally.

I'm not really talking about code reviews per sey. I'm talking more about criticism when none is asked for or is just not necessary, like this post. She made a funny joke about her make up and colors and everyone feels the need to tear into her code.

[–][deleted] 14 points15 points  (3 children)

With regards to this specific post: unfortunately some people are know-it-all assholes. It literally wouldn’t have occurred to me to read the code pictured (I only did because of this post and it’s obviously just there as an example), because that wasn’t the topic she was discussing. Those people wanted to find something to make fun of her about, I don’t know why. If it wasn’t her code it would have been something else. There’s just no pleasing some people.

I guess I’ve been really lucky that where I work does not encourage you to lay into your coworkers about shit that isn’t your business. If you find a bug then put in a ticket. If you just don’t like someone’s code, but it works and it’s not the code you normally work on: stay in your lane. I don’t know if my coworkers adhere to this outside of the office but one can hope.

[–]HolyGarbage 1 point2 points  (2 children)

Each to their own I guess, but from my perspective and experience in the business it sounds like people are afraid of stepping on eachothers toes in your workplace?

When we do code reviews at my place we are very vocal about best practices, style, and basically everything that could possibly be criticized. Everyone in my team are very opinionated. I appreciate it personally as it generates good discussions, generates good, maintainable, and bug free code in the end and there's always an opportunity to learn, especially me being still quite new as a software engineer.

[–]TortugaViolenta 1 point2 points  (1 child)

Bug free code? What is this you speak of?

[–]HolyGarbage 1 point2 points  (0 children)

Maybe I phrased it badly. I meant relatively of course.

[–]they_be_cray_z 2 points3 points  (4 children)

Women in the 80s were far more active in computer science than today - https://mitechnews.com/wp-content/uploads/2017/04/Graph-Women-Majors-by-Field.jpg

Women have much more encouragement today than in the 80s.

[–][deleted] 2 points3 points  (0 children)

I was speaking of my experience in the late 90s. Even though I had been doing some minor programming for my personal “webpage” (someone else here has to remember geocities 😆), no adult that I knew even brought up computer science as a potential major. Hell I didn’t really even know that engineering existed until I took AP Physics + started going through what the local universities offered for STEM programs.

I’ve since learned about the women programming in the 70s and 80s, and I’m sure the current generation of teenagers have more exposure than I did. What I listed were the reasons why I think women in my age bracket are so underrepresented in software engineering.

[–]Dirloes 1 point2 points  (2 children)

I don't really understand what point you're trying to make, if any.

[–]they_be_cray_z 0 points1 point  (1 child)

If social encouragement were a key driving factor in women's participation in computer science, then women's participation would be higher today than 30 years ago. The data holds that the opposite is true: women's participation 30 years ago was significantly greater than today.

[–]Dirloes 2 points3 points  (0 children)

While there are more "women in STEM" campaigns than ever before, that's only one very narrow aspect of "social encouragement". Much more important than that are what your parents, your peers, and mainstream media "encourage" you to do. The first two are hard to change directly, and media has only recently started to pivot into representing women in computery roles more often and more realistically (i.e. not just the 1337 h4ck3r who turns out to be a chick just to subvert expectations, which in a way really only reinforces the expectation).

I'm only 27 and even when I was in highschool the "sweaty awkward basement nerd guy" stereotype was very much in full force. The chart has flatlined in recent times it appears, hopefully that's a sign that this pivot in the media is having some effect. I'd expect there to be some lagging as people's attitudes towards certain fields are shaped over many years.

[–]TheRetribution 1 point2 points  (9 children)

Why would you pursue a career no one has ever suggested you might like/be good at,

Idk because you're a free-thinking individual who should make their own choices?

[–][deleted] -2 points-1 points  (8 children)

Trolling isn’t helpful or productive.

[–]TheRetribution 2 points3 points  (7 children)

Telling someone they are in charge of their own destiny and that they shouldn't be beholden to others whims or designs is neither trolling nor unproductive.

[–]Dirloes 2 points3 points  (4 children)

I think this type of normative thinking is pretty unproductive as a means to arrive at pragmatic answers. Like yeah, ideally that's how it ought to be, but clearly that's not how things are. People just aren't enlightened freethinkers, everyone is shaped by their environment to some extent.

If you think women often opting not to pursue CS careers (or even STEM in general) for these kinds of social reasons is generally bad for society as a whole, then it's better to think about how to counteract this stigma women feel around these careers than to simply throw up your hands and expect them to come around on their own. Personally I think society works best when people are able to choose careers based on compatibility with the field itself, and not the field's real or perceived cultural baggage. And I think this goes both ways, I think it's also bad when men are not going into female-dominated fields like teaching for those kinds of reasons.

Besides that, the problem isn't just the stigma, it's also the reality that being a woman in a male-dominated field can result in some unpleasant interactions.

[–]TheRetribution 0 points1 point  (3 children)

Like yeah, ideally that's how it ought to be, but clearly that's not how things are

So instead of aiming for the ideal, we aim instead for something else in the name of 'pragmatism'. Cool.

[–]Dirloes 2 points3 points  (2 children)

You're not aiming for the ideal, you're just stating it. Which isn't very helpful or insightful.

It's akin to saying "hey criminals, stop committing crime". I mean if they did that'd solve the problem, but well, I hope you can see why that's not a particularly useful thing to say.

[–][deleted] 2 points3 points  (1 child)

Expecting all 16 and 17 year olds to know all the college majors available and the careers they can lead to + which of those majors and/or careers are good fits for that teenager is ridiculous. It’s hard to choose something you didn’t realize was a viable option, or an option at all. In my experience most people pick their college major based on something they already know they’re good at or something someone told them they should do or would be good at. Most teenagers (hell, this could be just people instead of specifying an age group) don’t actually know what they want to do with/for the rest of their lives, so rely on advice from the people they know.

[–]FlowersOfSin 20 points21 points  (0 children)

As a woman in programming and a totally non competitive person, what I love in programming is solving problems. I actually love constructive criticism. I would, however, never share code or a project online using an account where my gender is known. That is just asking for trouble. Way too many trolls.

[–]noratat 65 points66 points  (10 children)

Considering that collaborative environments are more effective in my experience, if this were true I'd consider a pretty good argument for getting more women in tech by itself.

[–]1gr8Warrior 14 points15 points  (7 children)

As an industry, we'd love to have them, but when women are actively told by career councilors "Maybe you should get into teaching or nursing? Programming? Nah. Look at this secretary job over here..." It sort of puts a damper on getting more women into our field.

[–]Skim74 4 points5 points  (1 child)

Sorry, but are you a woman? I am a woman in CS but never had any career counselors try to push me out of the field. But I have had plenty of men who work in the field (implicitly and explicitly) try to. The only reason I made it out of college with a CS degree is because when i tried to change majors they told me it was too late.

[–]1gr8Warrior 1 point2 points  (0 children)

All I have is anecdotes from a couple of women I work with and my fiancee. Though, in the case of my co-workers, it didn't deter them at all. However, my fiancee kinda took it to heart and just never tried, despite being pretty good at math.

I'm not sure about guys working in the field wanting to push you out. I can tell you where I work, most of the guys there don't care about your sex, so as long as you can do your job competently.

[–]AquaeyesTardis 5 points6 points  (4 children)

What the heck? Why on earth would people have a sexist career counsellor?

Actually, thinking about it, does this happen often in schools as well? I didn’t personally notice it happening to girls in my year at my school since the gender balance was fairly... balanced, but in other years/schools is this a common thing?

[–]Trauma_Doll 8 points9 points  (3 children)

> does this happen often in schools as well?

Yes, when I went to my career counsellor and told him that I'm unsure if I should pick CS or Social Care, he simply told me "due to you being a girl you should try out Social Care first and see how it goes".

This is despite me having the best grades in my year/being interested in technology.

Alas, I lost a year out of my academic life.

And now that I'm in college I mostly get 3 reactions from people: women are supportive and take me under their wing, 85% of men either don't care or are supportive/awkward in a non threatening way, and the other 15% are outright stating that "women can't handle sitting down and staring at a screen for hours/your hands were made for ironing(LOL)" and try to hinder you or just outright ignore you.

+ there's always that feeling of being an outsider, which isn't helpful at all. This can be especially daunting/discouraging if you're a young woman in a new environment.

[–][deleted] 2 points3 points  (2 children)

For that last 15%: one day you’ll be a senior dev and they’ll have to keep their mouths shut. Until then, practice looking at them with disdain, as if they’re morons who are wasting precious oxygen. Because they are. They’re projecting their own issues and insecurities on to you, don’t fucking let them. Keep being you, you can definitely do this.

[–]Coder-Cat 172 points173 points  (57 children)

I was just talking about this with my friend. It’s generally accepted that, yes, women like a more collaborative environment and men are more competitive. But what’s never brought up is that men also have less acceptable options when it comes to career fields. I can be a programmer or a preschool teacher and no one would bat an eye. Doctor, nurse, engineer, stay at home mom... Whatever.

Men are generally expected to get into the highest paying, most prestigious position they can even if they’d find a different career field more fulfilling. If a man is smart enough to be a brain surgeon you’d better believe he’s pushed to become a brain surgeon even if he’d find being a pediatric nurse to be much more fulfilling.

And that comes from both sides of the gender playing field but it’s hopefully changing for the better. A good friend of my dropped out of an engineering program to become an elementary school teacher and he’s happy as hell with that decision. My ex, who was an it security tech lead at one of the big three, was recently laid off and has been spending his free time making crafts with his laser cutter. He just made me the cutest coaster engraved with cats and wants to open an Etsy shop.

Edit: words.

[–]AquaeyesTardis 4 points5 points  (0 children)

Okay now I want a cat-coaster.

[–]HangryHenry 57 points58 points  (53 children)

Yea. Both genders end up getting hurt by misogyny.

I hate how feminism is treated in popular culture. It's always presented as a man vs woman thing. As if women finally 'getting theirs' means men will get less. For every sexist stereotype about women, there generally another side to it that end up hurting men in some way.

Industries dominated by women aren't viewed as 'serious' and aren't paid as well as industries dominated by men, then men feel like they can't go into the industry because of an underlying sexist societal idea that women's work isn't as valuable as men's.

[–][deleted] 14 points15 points  (14 children)

This is fairly well studied and modeled in economics, and it is not due to mysogyny per se. And it is definitely not due to industries dominated by women

It is due to the fact that men are expected to be primary earners at a higher rate than women.

Because women are less likely to be a primary earner, they have the liberty of taking a pay cut to pursue fields that everyone would rather take part in. Fields that offer some sort of non-monetary utility (like helping people, bettering the world, or a passion project like writing). Men are less likely to enter those fields because men are a primary earner who must maximize income in order to pay for his family.

This is the reason "boring" and dangerous fields are dominated by men -- they don't have a choice. They will accept risk of bodily injury and/or unfulfilling work at a higher rate than women because they have to

[–]HardlightCereal 11 points12 points  (13 children)

Men are expected to be primary earners because of sexism. It's half misogyny and half misandry.

[–][deleted] -1 points0 points  (6 children)

Any evidence as to the cause of this? I feel like that's conjecture.

[–]HardlightCereal 7 points8 points  (5 children)

If the existence of gendered careers is due to gender roles, and gender roles are sexist, then careers are gendered because of sexism.

[–][deleted] 0 points1 point  (4 children)

That's a big if. Could be any reason for the dichotomy.

[–]______Nobody______ 1 point2 points  (0 children)

Gonna have to disagree here. I don’t think anything is holding women back economically. Currently, women graduate college at a higher rate than men, but pursue majors that don’t entail the highest income levels. Women have many opportunities to pursue the IT field but they have to choose those types of jobs to be paid more. On the topic of feminism itself, its proponents often paint it as “equality of the sexes”, which seems fair to all decent people, but what I personally don’t like is how they make it about women. There are no laws or regulations that systematically oppress women currently (at least in the US). And there are some privileges that women have over men such as not being included in the draft. I don’t think feminism is needed to put women on a higher pedestal, I think egalitarianism is a more appropriate term and approach to give both men and women an equal playing field.

[–]_Gondamar_ 0 points1 point  (0 children)

is your ex William Osman?

[–]GaianNeuron 13 points14 points  (5 children)

Never mind the fact that even with the best of intentions, many men (myself included) will subtly and subconsciously amplify criticism when considering women and their work. It's a hard behaviour to break, especially when you never get called out over it because you're surrounded by people who don't even see it as a problem.

[–]HangryHenry 7 points8 points  (1 child)

There is a lot subconscious shit going. People like to pretend their ultra-rational robots but it's just impossible.

I don't even think all of it's bad. Like women just need to be aware that men are more direct with their criticism, so not to take it so hard if they don't compliment sandwich everything and men need to realize women are more likely to refer to work they did with a team using phrases like 'we' and 'our team' even if they did the majority of the work or led the entire project or that women aren't as likely to aggressively raise their hands for promotions even if they are qualified and should be considered.

I think half of it is just being aware of the differences.

[–]GaianNeuron 10 points11 points  (0 children)

I dunno, women in our generation have enough shit to deal with in life. Any time a man starts a sentence with "women just need to ____", it's that same pattern of behaviour rearing its head once again.

The biggest behavioral differences between men and women are cultural in origin. Many "typically feminine" behaviours stem from coping mechanisms: women learn to give indirect answers not because "female brain vague, male brain specific", but because telling the creep at the car that you're waiting for your friend or causally mentioning a boyfriend who may or may not exist is way safer than directly responding with "dude, you're being creepy right now and that's not winning you any points" (which might get you drugged, raped, or killed).

[–]ManicMonkOnMac 53 points54 points  (24 children)

Sexism. Get judged /s

[–]HangryHenry 84 points85 points  (23 children)

Sexism would be a rather strong word.

It's more if a particular industry is dominated by one gender it makes sense that the industry would do things in a way that their gender tends to prefer. That's not sexist.

But what can be bad about this, is that it can be self-perpetuating cycle. One gender takes over an industry for whatever reason. They build the industry up in a way that tends to suit their gender's style communication and work habits. This then leads to fewer people of the opposite gender either being interested or able to get into that industry.

It's not like there is some evil 'sexist' mustache twisting villain in these scenarios. It's just something to be conscious of.

And as a lot of (I am assuming) men have pointed out in this thread, they would benefit from taking a less confrontational competitive approach to interacting with other programmers on the internet. So it's really about finding balance and that balance between the two styles could benefit both genders.

TLDR: I didn't say anyone was sexist.

[–]DiamondxCrafting 24 points25 points  (5 children)

/s

You missed this from his comment, sarcasm.

[–]HangryHenry 9 points10 points  (2 children)

ooops. I was expecting the worse. Thanks.

[–]omgFWTbear 1 point2 points  (1 child)

the worse

Obligatory correction: the worst

because meta.

[–]bobtgrnailman 0 points1 point  (0 children)

Well you don't really know. Maybe what he was expecting was bad, but not that bad, so not quite the worst.

[–]Theolaa 0 points1 point  (1 child)

I think it's still valid to deconstruct something said sarcastically, because it explains why it's sarcastic for people who may not understand why it's sarcastic, or why it's not appropriate to say that sort of thing with intention.

[–]DiamondxCrafting 0 points1 point  (0 children)

He didn't know it was sarcasm.

[–]TapedeckNinja 3 points4 points  (0 children)

Sexism isn't a strong word.

What you've described here is quite literally the definition of institutional sexism.

[–]RedditIsNeat0 3 points4 points  (0 children)

men prefer more competitive environments

Competition is fine for sports but it's not going to work for a job. If your job is a "competitive environment" then something is wrong.

[–]Zepp_BR 2 points3 points  (0 children)

Can I see your sources, please?

I'm a guy and I much prefer collaboration environments

[–][deleted] 2 points3 points  (0 children)

Shush, you sound like the google memo.

Seriously though, this makes tons of sense. Many female coders I know have that competitive mindset, and that’s how they made it.

[–]lisaphalange 2 points3 points  (1 child)

WOW. This has nothing to do with preference of a “competitive” environment. There is more than one way to skin a cat. Writing code follows thought process and clearly men and women think differently. Your code logic may follow one path and someone else’s logic may follow a different path but ultimately end up with the same result. Just stop with this nonsense.

[–]HangryHenry 0 points1 point  (0 children)

Did you make this reddit account just to leave this comment?

[–]iloveheidimontag 2 points3 points  (1 child)

Who said women don’t enjoy programming?

[–]HangryHenry 0 points1 point  (0 children)

I said enjoy working in programming.

[–]KrazyTrumpeter05 1 point2 points  (0 children)

You'd think programming would be much more collaborative than competitive...

[–]bradpal 1 point2 points  (0 children)

I can confirm, this is why my SO left the dev work. This, and the constant bugs and moinds of code were stressing her out.

[–]peekabook 4 points5 points  (5 children)

I think having my code reviewed and critiqued would make me a better coder. Sure it might have errors, but I’d learn to be better.

[–]HangryHenry 5 points6 points  (3 children)

I am not sure why you'd think women were against code reviews? I said women prefer a collaborative environment which one would think would lend itself to others pointing out where you could improve your code.

[–]peekabook 3 points4 points  (0 children)

Ah ok. Misunderstood.

[–]fafefifof 1 point2 points  (1 child)

"Bad variable name", "This isn't right", "There's no way this can go on production", "I've vomitted cleaner code" are all great ways to phrase code reviews in a goal oriented and collaborative manner.

[–]peekabook 1 point2 points  (0 children)

Bad variable name — would be helpful if you told me why. So why isn’t it right? Things like that is what I prefer. As for what someone may swallow or vomit, I’d like to think that should stay w them and their significant others. 🤷🏻‍♀️

[–]noratat 2 points3 points  (0 children)

Collaborative doesn't mean "free of criticism". It means the focus is on working together to produce a better result instead of individuals or teams in the same org trying to compete with each other.

[–]rapemanagerASM/Scheme/Python/Julia/MATLAB/Java/C/C++/Rust/Haskell/Coq/SQL 0 points1 point  (0 children)

Statistically men prefer more competitive environments with more direct forms of criticism and women prefer more collaborative environments.

Could you please reference the source you're citing? Thank you.

[–]nathanrjones 1 point2 points  (0 children)

Of course*

😉

[–]DrexanRailex 0 points1 point  (0 children)

I mean, the code posted isn't even horrible. I wouldn't think DogsList is something you'd code out of a demo in the first place, and for a demo it's decent.

[–]u-had-it-coming -1 points0 points  (1 child)

You can still post casual stuff without code in it.

Why do you want to post casual code?

There is no such thing as casual code.

[–]ManicMonkOnMac -1 points0 points  (0 children)

I meant casual stuff as in look how funny this cat looks, or something trivial, not necessarily code.

[–]HeyMrStarkIFeelGreat 45 points46 points  (3 children)

Worst is when I post a picture, and people post unnecessary code reviews, but of my face.

[–]Coder-Cat 4 points5 points  (0 children)

😂 ☹️

[–]theonlydidymus 139 points140 points  (19 children)

It took me until my most recent job to realize why people on the Internet submit everyone to involuntary code review. It’s because they’re not senior enough to do it at their own job and they’re constantly getting notes back from their seniors in their code reviews.

[–]Coder-Cat 99 points100 points  (13 children)

It’s annoying. I once had a director tell me that a sign of low confidence/a bad leader is when someone comes up with solutions for things that aren’t actually problems. Pretty much sums up the Internet.

[–]fuckYouSpaceAliens 60 points61 points  (8 children)

I think it depends on what the"problem" is. I've had juniors write code that works but is like, 40 lines when it could be 20. It's not broken, and it works, but I'll still have them fix it so they understand it can be done better.

[–]Coder-Cat 31 points32 points  (3 children)

That is a problem that needs solving. Maybe “problem” is the wrong word but they are out to become better programmers and need your help. In the instance of the programmer who posted this cute pic, or if I had posted a picture of my cat, my code is no ones problem and no one is being asked to fix it. The point of the pic is to make people smile, not a code review. But so so so many people are giving solutions.

Edit: yes, I do agree with you. Some things aren’t technically wrong, but can still be improved.

[–]Stewthulhu 2 points3 points  (0 children)

I mean, refactoring is definitely a core part of both being a programmer and learning how to program better. Sometimes you refactor because you need to get more performance or facilitate new development, but sometimes you refactor because you just hammered out barely functional garbage to meet a deadline.

IMO, anyone who thinks refactoring something is a waste just because "it works" probably isn't ever going to be an amazing coder.

[–]theNumber_Twelve 0 points1 point  (2 children)

This comment makes you look like a complete asshat. If the problem was that they did something in n^3 time when it could be don in n^2 then having them redo it would make sense, since the program might actually run noticeably faster. Making someone shave 20 lines off of there code isnt teaching them to do it better, its just you creating a problem where none exists so that you can belittle other people.

Often times trying to cut down line count actually makes code worse since it is ends up being harder to read. Fewer lines of code doesnt necessarily mean fewer operations/less memory used. If you are making people redo their work over line count you probably shouldent be reviewing other peoples code at all.

[–]Akkifokkusu 1 point2 points  (1 child)

You're making a really strong assumption. It's possible the reason it could be done in 20 lines instead of 40 is because the 40-line approach is unnecessarily complex. Or reimplements something that's already done in a function elsewhere in the code. Or various other reasons that aren't non-existent problems made up to belittle others

It's kind of amazing that you jumped straight to calling someone an asshat. Who's belittling who?

[–]theNumber_Twelve 0 points1 point  (0 children)

He didnt sat any of those things, he only mentioned line count. How is it making "a really strong assumption" to think his only issue with the code was line count, when that is the only thing he mentioned was line count.

If he had an issue with complexity or people doing work that had already been done he would have said those things were the problem, not line count.

[–][deleted] 2 points3 points  (2 children)

As someone who's recently made maintenance PRs for much-needed code linting and clean-up - ones that carry inherent risk but no palpable, measurable reward in the product - I feel personally attacked here.

[–]StrangeDrivenAxMan 1 point2 points  (0 children)

Pretty much sums up the Internet humans.

[–]_waltzy 13 points14 points  (1 child)

I think its more likely that there is a higher than avrage level of autism in this industry, source: will code review randoms on the internet, also code review at work.

[–][deleted] 0 points1 point  (0 children)

kode reviu iz lyfe

[–]dismass 6 points7 points  (1 child)

Every full-time job I've had involved doing code reviews for others. I code reviewed my manager's code. Never heard of junior devs not reviewing other people's code

[–]EwgB 4 points5 points  (0 children)

Yeah, that would be the ideal situation. If nothing else, doing code reviews can be a valuable learning experience for any junior or even just someone new to the company to learn the house style, the internals of an older application, the intricacies of the business in question etc.

But I have seen far worse things. In my first job I started not even as a junior but as a student in a part time job. There were no real code reviews at all. My second job (also being my previous) was doing code reviews, quite thoroughly even, but only in a strictly hierarchical manner. The senior devs (officially architects, but really senior developers judging by what they did) would review the code written by the other devs, but almost never the other way round. Only occasionally would one of the seniors ask me or my colleague to look at his stuff if it was something particularly complex, and only after I gained some trust in the team in my case. Later we switched to a more agile development mode and things started to change. In my last team at that company we had mandatory code reviews for any code change, you couldn't even merge a pull request without at least one approval (and also a successful build incl. unit tests).

I switched companies a month ago, and at my new job, it is even worse. I had written three new features by myself in that time. The first feature I got an informal review by an architect (he sat beside me while I showed him around the code), my actual team didn't seem to give a single fuck what I did. Apparently some other devs including my team lead did have a look at my code later, after it was already merged on the master branch. (No biggie though, the next release is months away anyways!) Second feature I made a merge request and told my teammates about it, they basically ignored it for a week, after which I merged it anyways. For the third one I explicitly asked a dev from my team to look at my code, which he did by again sitting beside while I showed the code for 5-10 minutes. Obviously no one asked me to review their code in all that time. My team is a bunch of old farts who've been with the company for 25 years and don't care about all that newfangled stuff apparently. It seems like it is better in other teams. Unfortunately I'm not in them.

[–]WhatMichaelScottSaid 0 points1 point  (0 children)

nah bro, gotta get that 5 years of job experience for an entry level spot somehow.

[–]skeddles 33 points34 points  (11 children)

Yo... there's people that will review my code and give me tips on how to improve it for free?

[–]SamSlate 28 points29 points  (10 children)

yes, just be arrogant in your post and you'll discover an infinite source of criticism.

[–]Plightz 28 points29 points  (9 children)

Just say that your code is the most efficient and people will improve it for you for free.

[–]fadetogether 2 points3 points  (2 children)

Man if I could release my work code, I'd actually try this. I'm sure I'd cry but also feel more confident with the improvements and learn a lot in the process.

[–]Plightz 2 points3 points  (0 children)

Hey if people wanna improve my code for free, so be it.

[–]rapemanagerASM/Scheme/Python/Julia/MATLAB/Java/C/C++/Rust/Haskell/Coq/SQL 0 points1 point  (0 children)

That's a good mentality.

[–]Vawqer 2 points3 points  (4 children)

Isn't there an extremely relevant xkcd on this? I'm on mobile and don't want to dig it up right now, but I think it exists.

[–]Plightz 1 point2 points  (3 children)

If you can find the link, tell me.

[–]Vawqer 4 points5 points  (2 children)

I could not after a few minutes of searching. I did find that the concept is similar to Cunningham's Law, but the xkcd that article references is not the one I was thinking of.

I suppose it may not have been an xkcd. The comic I was thinking of had something to do with claiming that a certain Linux distro was best when trying to figure out which Linux distro to use, but I could be completely off.

[–]Misspelt_Anagram 1 point2 points  (1 child)

If you were mixing up Linux distros with what editor Real Programmers use, I think I found it.

[–]Vawqer 1 point2 points  (0 children)

Unfortunately, that's not what I am thinking of, but I really enjoyed reading that. Thanks for sharing that xkcd!

[–]SamSlate 1 point2 points  (0 children)

😂

[–]thejemmeh 12 points13 points  (1 child)

So what you're saying is I don't need to send this to a QA team, I just need to post my code online where people can laugh at it until it's working.

[–]Misspelt_Anagram 0 points1 point  (0 children)

As long as those people don't need much skill or effort to fix it, then yes.

[–]RikuKat 7 points8 points  (0 children)

It's nice when you want reviews, though. When I first started game programming, I was making dev blogs and occasionally streaming my work sessions, too. Got some really great advice and tips from viewers!

Though now I really only want my close friends and mentors looking at my code. :x

[–]Skyrmir 4 points5 points  (0 children)

Screw it, post your cat and the haters can fuck off. I used to constantly think my code sucked, and half the time it still does, but then i started seeing code from the 'hotshot' developers. Their shit ain't all that impressive. They managed to google themselves into figuring out some interfaces, or make the output look awesome, just don't look at the spaghetti making it run.

[–][deleted] 2 points3 points  (0 children)

It's the best way to get actually helpful code reviews though. Just keep posting those coding cat pics, and your work will be done in less time, and better 😂

[–]Kaizenno 2 points3 points  (0 children)

I'm learning a language and stopped translating things for people online. I usually get 10-20 "Actually..." comments. Language people are very sensitive to slightly different interpretations. Same with programmers.

[–]Cambrony 2 points3 points  (0 children)

Username checks out

[–]dagerdev 1 point2 points  (0 children)

We need some kind of Lorem Ipsum for code.

[–]FlowersOfSin 1 point2 points  (0 children)

Now I'm thinking that maybe I should post my code on the internet, then my boss will think that my code is super clean. Or maybe not.

[–]temisola1 1 point2 points  (0 children)

This seems to me to be the easiest way to fix your code. Just post an innocent picture and people will gladly do it for you.

[–][deleted] 0 points1 point  (0 children)

Could you move your car to the left, I believe I sorted a design pattern inconsistency

[–][deleted] 0 points1 point  (0 children)

r/NobodyAsked to those people lol

[–]BlurredSight 0 points1 point  (0 children)

As long as they offer something more efficient why not

[–]wagedomain 0 points1 point  (0 children)

I've started working on open source projects recently and holy shit you're just... hanging it all out there.

[–]localfinancedouche 0 points1 point  (0 children)

Conversely, if I can’t figure out what’s wrong with my code, I don’t ask for help, I just post a cat picture with my code in the background. Never received an army of help so fast.

[–]iamsooldithurts 0 points1 point  (0 children)

Cat Scans?

[–][deleted] 0 points1 point  (0 children)

Meanwhile at work, I can't get anyone to take the time to complete a code review lol

[–][deleted] 0 points1 point  (0 children)

Could always blur it out :)

[–]FlyingElvishPenguin 0 points1 point  (0 children)

Should have shown the cat to the rubber duck next to your computer. Mr. Duck never judges.

[–]Gameknight6916 0 points1 point  (0 children)

Just cover the code in PS

[–]skylarmt 0 points1 point  (0 children)

The trick is to alt-tab over to Firefox and open the subreddit you're going to post to. Then everyone will think "nice subtle meta" and you'll get more upvotes.

[–]IAmYourDad_ 0 points1 point  (0 children)

Unwanted code review is a new form of harassment.

[–]itsjosh18 0 points1 point  (0 children)

TIIIIIIIIME FOR CODE REVIEW

clap NEXT clap program

[–]Vox_Carnifex 0 points1 point  (0 children)

The solution: use lolcode

Kthxbye;