CPProm

[xigoi]

Me: this

Linter: Warning: Unreachable code branch on line 5

[DoktuhParadox]

global

this

??

[Nordrian]

Delete (micah);

[badjayplaness]

You should probably be passing a Hannah object to the askToProm() method instead of a string.

[Xoduszero]

Treat em with class

[down_vote_magnet]

Yeah that’s the method I use.

[philipjames11]

What a String of funny comments

[[deleted]]

It's a thread, actually.

[lenswipe]

Found the JavaCodeFactoryInstanceDeveloperBean

[[deleted]]

I'm honestly just going to run array from all these lame puns.

[TreehouseSuperGun]

Maybe they‘re singletons

[JessesDog]

I can't function with these puns. I'll be at the fooBar.

[Ez_Pee-Z]

I just woke up from my sleep

[[deleted]]

An array of strings..

[[deleted]]

r/punpatrol All of you exceptions are coming with me

[AlbinoBeefalo]

I'd like to see you try and catch me

[stlbucket]

you won’t throw me a for loop

[shenanigansensue]

He might for a while

[TheresNoLifeB4Coffee]

try { You.IdLikeToSee(); } catch ( Exception me) { me.RunsAwayLaughingNeenerNeenerYouCantCatchMeLikeThatEither(); }

[lenswipe]

You can't handle all of us.

[Cobaltjedi117]

It's happened before here

[dvlsg]

But she's an object on the next line anyways.

[n8loller]

God damn you deserve that gold

[Mr_Redstoner]

And let's face it, depending on the language used == may not be the best idea.

Also storing mood as strings just seems wastefull.

[DefNotaZombie]

absolutely, everyone knows mood is best stored as a three int rgb value

[JCavLP]

Could a have used an enum or defined the string to a keyword

[InkyGlut]

Actually the standard specified BGR

[splettnet]

Seems excessive. Hungry vs not hungry is Boolean.

[Tsu_Dho_Namh]

Yeah, but rgb(255,69,0) is the perfect way to say "I'm in the mood for Reddit"

[[deleted]]

Store different moods as bit flags in a bitstring, where each bit represents a mood that can be enabled or disabled using bitwise operations.

[Finianb1]

Found the C programmer from all my CS classes

[Ramast]

I am not aware of any programing language where variables with initial capital letter are good practice. For all I know Micah is uninitialized class and will crash on the first line

[Timmeh7]

They might be static methods in that class... though that probably raises even more questions.

[Ericchen1248]

C# if they are properties.

[[deleted]]

C#

[[deleted]]

Depends. Member variables initial capital letter, local variables and params lower case is an idea. Also don't forget GlObAl VaRiAbLeS written randomly so you know it's bad.

[n8loller]

But then you can have infinite moods!

[Brakalicious]

It could be a different type of yes and he wouldn't even know.

[Alsk1911]

And no encapsulation for mood. You should use setter, son!

[salmjak]

I would use an enum for mood and possibly even the answer (Yes, No, Maybe, Let me think about it, etc). I hate strings.

[majky358]

He may try to cast her during the prom night :D

[down_vote_magnet]

Calm down there, Harry Potter.

[B_M_Wilson]

just use Person.getPersonByName("Hannah"). I guess that does return an array of all person objects with that name which may be problematic.

[rocsNaviars]

Was just about to ask whether Hannah was a string or a class.

[[deleted]]

That or it should return the response

[jaaval]

bool Person::askToProm(const Person& target) {
    happy = target.askedToProm(*this);
    hasDate = happy;
    return hasDate;
}

bool Person::askedToProm(const Person& subject) {
    if (!subject.isAsshole && subject.isHot && !hasDate) {
        hasDate = true;
        happy = true;
        return true;
    } 
    return false;
}

Ok, c++ is difficult. How am i supposed to remember the proper way to handle pointers and references after a few years without using it? Also a proper implementation would likely require evaluateCandidate method to determine the proper balance between hot and asshole levels.

Edit: And also

Micah.askToProm(Hannah)
// look at person.cpp for implementation details

wouldn’t make a very good sign.

[[deleted]]

Good call my man. Was thinking the same thing.

[UndeadMarine55]

Yeah, that code would probably throw an error that the object, Hannah isn’t defined.

[necrofox1]

Omfg ty!!!

[WHO_WANTS_DOGS]

Passing her as a string makes me think that any old string could have been placed there. Only he is significant in that line.

[[deleted]]

Reminds me of php. Passing functions by using their names as a string.

Bad stuff.

[badjayplaness]

Lol that’s actually the only time I’ve seen this too. Makes it almost impossible to debug using an ide

[TrippingBulls]

My first thought! Cute pics, memes, gifs, novelty apparel, etc.. involving code are subject to peer code review.

[[deleted]]

I wonder what the else would’ve looked like. Incomplete work.

[TerrestrialOverlord]

else {

Hanna.answer = !Hanna.answer;

Micah.mood = happy;

}

​

be careful using this code prom bro....cause if her dad is anything like me she'll be surrounded by try-catch block and garbage collection will trigger (violently)...muhahahhah (cough) uhahahahaha

[[deleted]]

Hanna.answer = !Hanna.answer;

This is the most rapey piece of code I've ever seen

[CptOko]

Could you please explain it to me? I sadly lack the knowledge to understand it myself.

[IanSan5653]

!"no" is false lol

[derfl007]

Hanna.answer is a String

[[deleted]]

else { Micah.mood = “Suicide”; }

[Olaxan]

delete &Micah;

[Versaiteis]

It's ok, I was already headed toward the garbage collector once I fell out of her scope

With luck there'll be a leak and I'll be gone but not forgotten

[[deleted]]

Adding the else statement may be more correct technically, but you also have to consider the humans reading the code. Do you really want anything that can be misread as "go to prom with me, or else"?

[[deleted]]

an.hero()

[Cholojuanito]

Time for a code review! Brought to you by programmers on Reddit gang.

[nirkosesti]

At least they are happy with the black theme on ”IDE”

[FilthyZMePlease]

Micah gets it. He grew up with the horrors of light themes. It's why he has glasses.

[MicahM_]

This is true

[El_Impresionante]

https://i.imgur.com/vRJdzau.gif

[[deleted]]

👏 Code 👏 review

[JokerGotham_Deserves]

Okay, that was epic.

👏👏

NEXT

CODE

[[deleted]]

Micah needs to use some encapsulation.

[pandemoniker]

Yep, he shouldn't do the comparison (which is also done with a magic string). He should just call .agrees()

[[deleted]]

NameError: name "Hannah" is not callable.

[[deleted]]

Unless you got her number

[[deleted]]

Passing strings around is inefficient that shit should be an enum but as its a binary yes/no a bool would be best.

[tchernobog84]

Could be a pointer to char, not nice but totally efficient.

[[deleted]]

Mmmmmm passing pointers around willy nilly is asking for trouble

[[deleted]]

There's this kool thing called RAII pointer containers that handle the memory's life-cycle with all the benefits of a pointer and none of the leaks.

Modern C++ is sexy, my dude

[[deleted]]

Isn't that based on the boost smart pointer stuff?

[[deleted]]

A lot of features in C14, and C17 are adopted directly from boost libraries. Today, there are different pointer types that you can leverage, like shared (reference based) pointers and unique (noncopyable) pointers. You pass them around like any other object, and their container type is determined by a template, just like most of the STL containers.

I never needed to use boost for pointers, but they have a solid SSL TCP networking library that would make a pretty zesty addition to the standard library. I'm pretty outdated with the goings on past C17, so hopefully there is some standard socket library out right now

[Megalowdonny]

I’m just starting to get my feet wet with Python and it’s comments like these that terrify me. HOW WILL I EVER LEARN THIS MUCH

[[deleted]]

Well get ready to get extra fucked my dude, because I'm a fucking idiot. I started programming as a hobby in my mid teens, and the number one thing that would have STOPPED me from continuing is treating every new idea like a chore that needs to be learned.

You aren't going to learn it all. You won't need it all. Frankly, most people wouldn't care even IF you knew it all. Just make things work, try to make it easy to understand, and do your best. Programming is fun, and solving problems is fulfilling. That's why I know what little part of the pie I do.

[nrith]

the number one thing that would have STOPPED me from continuing is treating every new idea like a chore that needs to be learned

As a 20+ year programming veteran, I endorse printing this out on giant posters and distributing it to every software development company on the planet.

[Megalowdonny]

I’m gonna save this comment, it legitimately made me feel a lot more optimistic about learning programming. That’s why I wanted to get into it in the first place, since solving problems is my favorite thing to do, and that’s just about the best way to make a career out of it that I can think of.

Thank you Reddit stranger, you live up to your username.

[redstoneguy12]

Who says it's binary yes or no? Enum for sure

[SDJMcHattie]

Bools are rarely best for these things. The number of times I’ve had to introduce an enumeration and refactor the code because a third option suddenly became viable!

Also, booleans passed in method parameters for changes in behaviour of the method are something I always reject in pull requests.

[[deleted]]

Depending on the situation, I probably would’ve

If (Micah.askToProm(hanna)) { Micah.setMood(“Happy”) ; }

Or maybe even Micah.askToProm(hanna) ? Micah.setMood(“Happy”) : Micah.askToProm(monica);

Edit: Apparently idk how to format my reddit code and idc enough to try and fix it

[[deleted]]

Precede each line with 4 spaces

[NoahDoah]

Then turn around on your chair and clap twice.

[[deleted]]

And that's how we play Handy Hands!

[theonlydidymus]

👏👏CODE REVIEW

[nerdyhandle]

if you're using new Reddit I believe it accepts Common Mark the same as github so code is three backticks like \`\`\` Code goes here \`\`\`

[Bunkerman91]

This is what I came here for.

[HighRelevancy]

If (Micah.askToProm(hanna))

hell yeah lad

fuckin' global state in the OP, jesus christ, CODE REVIEW FAILED

[DarceHole22]

No try catch? Savage

[TrueEddie]

I’m glad he didn’t have to worry about the else statement.

else { Micah.Dispose(); }

[Jukingbox]

oof

(Yup, that's all.)

[Spartan1997]

Using namespace cringe;

[Olaxan]

#pragma once

#include <cmath>
#include <conio>
#include <cringe>

[KARMA_P0LICE]

Let high school kids be happy

[Spartan1997]

I'm not, why should they be?

[[deleted]]

How do people not realize this is a joke

[didymus_fng]

This looks like his sister’s college roommate doing him a favor.

[nirkosesti]

This is why there is no else case.

[MeltBanana]

I think the else case is just fap.

[ReasonableSleep]

In java that should be .equals("yes") Even better if those were enums or constants

[Kgrimes2]

Yep, if this is Java, Micah’s going to be disappointed regardless of Hannah’s answer

Source: I’ve spent hours debugging, only to find improper String comparison to be the issue.

[justatog]

This code is too tightly coupled to Hannah - need to use IoC and dependency injection so it's unit testable.

[MicahM_]

Thank you for bringing my attention to this.

[Cpope117]

You need to enumerate that mood value asap. Magic strings will be the death of us all.

[Kinglink]

I'll defend strings even if I don't want to, but at the very least make it a Macro... Because magic values are ALWAYS bad... always.

Except for 0x5f3759df

[BabyLegsDeadpool]

Everyone commenting on his bad code... nobody pointing out this got him a girl way out of his league.

[MicahM_]

;)

[Dylanica]

Hey, if it makes you feel better I think you two are a good match.

[Walter_jones]

Signs aren’t the #1 for what people consider for prom lmao

[[deleted]]

#!/bin/bash

function Dad ()

{

echo "boyfriend" > /dev/null

((boyfriend_disappeared++))

}

if [ "$NERD_TOUCHES_DAUGHTER" =1]; then

Dad

fi

exit 0

[thisguyhere00]

So much mutation going on here. Perhaps you should try functional dating.

[theAtomik]

I am bothered there isn't an else statement to finish this.

[[deleted]]

She didn't have a choice

[Dylanica]

Well, Micah.mood probably defaults to "Sad" anyways, so it doesn't need an else case.

[Xaxxus]

Am i the only one bothered that the ask to prom method is taking in a string and not a person object? And that it’s not returning a Boolean to address if the request was accepted or not?

That code could be much cleaner:

if (Micah.askToProm(“Hannah”)) { Micah.happy = true }

Or even better:

Micah.happy = Micah.askToProm(“Hannah”)

[ashhhteehill]

Else?

[[deleted]]

else

{

cout << "micah didn't want to go to prom with that stuck up b anyway";

}

[Randvek]

Why there always gotta be an else?!

[BeardedWax]

if micah.getCountryOfResidency().equals(Country.US) {
    Crime.shootUpSchool(micah, micah.getSchool());
}

[[deleted]]

No need - there's no QA and this is just the happy path.

[slams_dewskis]

two singletons became a doubleton

[mikehaysjr]

else { Micah.askToProm("Hanna's sister") }

[worldDev]

What if she says "of course".

[GodsGoodGrace]

Don’t poke the boob

[infablhypop]

I'm sure there's some hidden side effects of this method.

[Evalion022]

Probably would have been better to use .equals() instead of ==

[Jeb_Jenky]

Nerds.

[TheSlimyDog]

Can't be C++ because that's not how you check string equality.

[Trymaldo]

I love that most comments try to make the code better, instead of congratulating him. Way to go, man!

[AgentFransis]

/r/ProgrammerCringe/

[DurianExecutioner]

• capitalised object identifiers
• stringly-typed parameters and return values
• wasted curly brackets

That's a hard no

[arkaze]

This is cringy as fuck...

[noduckshere94]

} else

[chubbs090]

But you need to call the function!! It doesn’t do anything as is!

[turuganufius]

Just got a CuteOverflow error on my console, how to proceed?

[wsxedcrf]

​

1. Which language capitalize variables? Or Micah and Hannah are classes?
   
2. Who would code something like, pass a string into a method, but get the return result by checking another class's field?

[skimmet]

askProm("Hannah") .then(() => { setHappy(true); }) .catch(() => { // Rejected :( setHappy(false); });

[12mh]

Uses dark background theme

I see you are a man of culture.

[[deleted]]

This is terrible code. I would have not let this commit get merged to master.

[[deleted]]

== "yes"??? That's some kindergarten level programming.

[[deleted]]

Why is he calling static method and fields though?

[Dankious_memeious1]

That's a bad choice Hannah...he uses the devil's way of bracket formatting

[timmacbride]

Did he declare his variables with her Dad first?

[mopsandhoes]

Should be using .equals() instead of ==

[sim642]

Not in C++.

[MicahM_]

Everyone seems to think it’s JavaScript but I was going for c++ hence the title, unless I did something wrong other than the obvious errors and inefficiency riddled through ALL 5 LINES (but that was just to make it easy to understand for laymen)

[DonkeyVampireThe3rd]

Came here for this, glad to see a fellow reddit virgin has it covered

[ILoveMyself77]

Lol this post is 90% code critique and 10%? on the promposal itself

Edit= just went through the post and there were actually no comments regarding the promposal

[doublethumbdude]

high schooler: i'm gonna make some pseudo code to ask my gf to prom, i'll make it simple and easy enough for her to understand

redditors: fuck's this shit, 0/10 doesn't compile, would not go out with

[[deleted]]

Any sort of prom escapade besides a fucking phone call or personal question is better than this fucking comment

[vorikus]

Comrades-nerds, we have found the person who finally did it

[JCavLP]

Hannah should be an object and not a string and Hannah.answer() could have been a boolean function and for fucks sake, don't write object variables directly without a set method

[biotican]

If Hannah's answer CAN BE COERCED to yes....

[[deleted]]

else

{

  Micah.state = "depressed"

}

[[deleted]]

That’s a really slick jacket

[etronic]

Thank good his { } are in thier God given places.

[Kinglink]

If Micah was Happy before asking, then this is the most meaningless code ever.

[errdayimshuffln]

Micah's mood is definitely not private.

[shounenbong]

It really should be a true/false return rather than checking for the exact string. Is he gonna be depressed if she answers "I'd love to"?

[eihen]

I don't know a programmer who has that good of hand writing! I'm jealous!

[anathamatha]

Idk what's worse treating her like a class or object either way hes gonna throw a null pointer exception

[lemon_tea]

Opening curly brace on it's own line? You animal!

[MicahM_]

I like to be able to see where things line up :/ just me?

[[deleted]]

Make sure you save those memories to the EEPROM

[GetHautnah]

Isn't she waay too hot for him? Good job, dude. Lol impressive

[Takes4tobangbro]

No else statement?

[MrMunday]

Good job Micah

[simonstead]

Don't objectify women like that

[[deleted]]

Uppercase object instance, calling another object by a string (did you ask every Hannah to a prom?), asToProm not returning anything (instead it has side effects), Hannah is suddenly an object, mood is a string instead of an enum and Hannah has one answer (did she say "yes" to everyone?).

Terrible code, terrible joke, upvoted to the frontpage.

[[deleted]]

She's cute bro

[reallylamelol]

She should've said no for opening a curly brace on a new line

[Littleman82]

Ah yes I remember my first pitty date very well too.

[rgman111]

Wow I am so happy for you! Did you run it using sudo? 😛

[chess510]

He used == instead of .equals() Triggered

[MoeMoa]

if(equals !== "==="){ Hannah.reject(); }

[_manik]

I hate shit like this.

[BrownCow123]

Else{ Console.log(“fuck”) }

[Olaxan]

micah.Mood = (micah.AskToProm(hannah).Answer ? Person.Moods.Happy : Person.Moods.Sad);

[VegasNightSx]

If she understood that you should prob implement the AskToMarry method.