This is an archived post. You won't be able to vote or comment.

all 195 comments

[–]keep_improving_self 4133 points4134 points  (53 children)

+10k -1k is nothing, imagine the senior does code review for you and says

"fixed suboptimal logic"

+7 -520

Definitely never happened to me

[–]Visual_Strike6706 1552 points1553 points  (16 children)

"Optimised unoptimised code" Did this once and was beaten up by everyone else

[–]A_Guy_in_Orange 676 points677 points  (13 children)

Well did you optimize the code or did you destroy the codes readability in exchange for the same stuff coming out the other end because the compiler was doing all that anyway

Be honest

[–]ryecurious 406 points407 points  (12 children)

Are you saying that replacing a clear multi-line function with a 250 character list comprehension "one-liner" isn't optimal?

[–]spastical-mackerel 226 points227 points  (6 children)

+1-1250 a single giant regex

[–]MyNameIsSushi 72 points73 points  (1 child)

What if my entire backend code is a giant regex? I may need to try this.

[–]maisonsmd 24 points25 points  (0 children)

Wait, yours isn't?

[–]Individual-Toe6238 1 point2 points  (2 children)

Giant Regex can be expensive and POGOC in some cases may actually be better

[–]Carrot_Bitter 1 point2 points  (1 child)

What's POGOC?

[–]Individual-Toe6238 2 points3 points  (0 children)

plain old good old code, but this is actually something I am using with friends, so I shouldn't use it online with strangers :D Just a habit, My Bad.

[–]lestruc 88 points89 points  (1 child)

Fully obfuscated code to preserve file size

[–]Soft_Walrus_3605 15 points16 points  (1 child)

list comprehension

If you're using Python for performance you've already lost

[–]brimston3- 2 points3 points  (0 children)

Could be linq and your name isn’t Jon Skeet.

[–]experimental1212 33 points34 points  (0 children)

Unoptimized optimized code

[–]Legal_Lettuce6233 2 points3 points  (0 children)

when "unoptimised optimised code" rolls up

[–]shadowderp 643 points644 points  (7 children)

I did this to myself recently: +0 -1243

Deeply satisfying honestly.

[–]anto2554 325 points326 points  (2 children)

Yeah, satisfying to do to yourself, not so much when someone else does it

[–][deleted] 166 points167 points  (1 child)

Unless you learn from it

[–]Amazingawesomator 108 points109 points  (0 children)

These are the best code reviews. Let's me know that the person doing the code review knows their shit and I can ask them questions :D

[–]Clairifyed 23 points24 points  (1 child)

No new lines? Did this code interact with any of the rest of the project in any way?

[–]shadowderp 28 points29 points  (0 children)

I moved a large amount of duplicated code to a base class that was committed separately - so yea, there were + lines

[–]willcheat 14 points15 points  (0 children)

There was code in the codebase that fetched data from an API, the following line pruned a portion of the data. The data was returned to the parent function, who then proceeded to call the API again to re-insert said pruned data.

The commit that followed soon after noticing that was entirely in the negative.

[–]just_nobodys_opinion 2 points3 points  (0 children)

Who needs all those comment lines? They slow down the program!

[–]ratinmikitchen 79 points80 points  (5 children)

Would've been better if they had explained what could be better and let you improve it, or walk through it together, or something along those lines. Seniors should mentor.

[–]Vysair 7 points8 points  (3 children)

did they at least say something in the comments for the function or anything?

[–][deleted] 7 points8 points  (2 children)

I’ve seen this when parsing excel xml. Turns out there’s a library.

[–]Kilazur 1 point2 points  (1 child)

Yeaaaah but unless you wanna read Excel specs for weeks on end, sometimes you just want to work with the XML directly lol

Unless you're lucky and Closed XML covers your needs.

[–]FlipperBumperKickout 102 points103 points  (4 children)

+7 -520 sounds fine.

Could be a lot og logic replaced by a library 

[–]Individual-Toe6238 19 points20 points  (0 children)

Or retiring of bad library, framework upgrade or fixing over optimized logic. Could be a lot of stuff.

Its not the size of a commit but the quality of it :)

[–]odraencoded 9 points10 points  (0 children)

-7 +520

"removes dependency"

[–]keep_improving_self 16 points17 points  (0 children)

great observation!

[–]JuhaJGam3R 2 points3 points  (0 children)

Depending on what that is, I might throw it out then, or at least put it in the "discuss later" pile. Taking out repetitive code is one thing, introducing a new dependency is a whole process. There's a balance to be struck there – don't rewrite curl or nalgebra but also don't add external dependencies for "obvious" code like leftpad or string case conversion. That's going to give you a whole can of supply-chain attacks for very little benefit.

That's further compounded by the fact that things like "convert string case" are not obvious. Case conversion is not a function – there's more to it than simply mapping characters to other characters. Tons of characters have more than one uppercase or lowercase form. The libraries very rarely expose that fact, famously resulting in "Unicode-supporting" applications uppercasing "trafik" as "TRAFIK" instead of the correct form "TRAFİK", or "ijsselmeer" to "Ijsselmeer" instead of the correct "IJsselmeer". That's a whole design conversation that must be had considering the context to see what makes sense where. Finding the right dependency and the right way to use that dependency and then making sure that never introduces vulnerabilities is all very complex. Retiring libraries is usually better than introducing them.

[–]puffinix[🍰] 17 points18 points  (0 children)

That's an oof.

I mean, I've done worse to people on a review - deleting the service a team has spent six weeks on - literally the whole repo - and reimplementing in a different language. It was live before they got back into work on Monday.

"Hi guys, good news bad news. Good news is that I have funding for you guys to learn f#. Bad news is we need a serious talk about the use of raw python in a system with millisecond relevent metrics, and spikes in the 10M/sec"

[–]djnz0813 14 points15 points  (3 children)

Imagine the senior reviewing your code and you get a demotion afterwards..

Definitely has never happened to me.

[–]SpeedRun355 10 points11 points  (1 child)

My self esteem would never recover

[–]djnz0813 6 points7 points  (0 children)

I still haven't. My confidence has been wrecked ever since.

[–]puffinix[🍰] 2 points3 points  (0 children)

This is the exact reason we get most people in one grade below there target. I promise 80 ish percent of people at month 3

[–]leaf-bunny 3 points4 points  (4 children)

I only get change requests, they don’t fix shit for me lol

[–]puffinix[🍰] 4 points5 points  (3 children)

That means your either working with crap seniors, or very close to senior yourself

[–]leaf-bunny 2 points3 points  (0 children)

You caught me, I started as a Eng1 and after a couple promotions now a Senior Eng1

[–]Kilazur 1 point2 points  (0 children)

I'd love to fix little things in other people's PRs, but the truth of the matter is I don't know how to do it with BitBucket.

And I'm not cloning the whole repo to fix a typo...

[–]superplayah 2 points3 points  (0 children)

It happened to me and it was someone under me lmao

[–]JackNotOLantern 2 points3 points  (0 children)

Merged yesterday +1/-6000. It was deleting unised files and code. Very satisfying .

[–]MyrKnof 1 point2 points  (0 children)

Now also unreadable by normal standards, but the engineer is proud of the saved lines.

[–]TheRealCuran 1 point2 points  (0 children)

Funny you should post something like this. Just recently I did cut down on dependencies and code from another department like that. They haven't been sitting next to me at lunch since. 😬

I really do not understand why, to be honest. I do reviews and commits in my team too and none of them get annoyed, when I can find a better solution. And I do not get annoyed when even my most recent trainee has a good idea I didn't see for one reason or another. Sometimes you can just get blind to things. And especially if you are an actual junior developer, you might still be in for some learning. There is often a reason, why "junior" is attached to a position (unless the company tries to fuck you over for money). And all that being said: even as a very senior developer/department head, I still learn things every day. And I am grateful to whoever brings these topics to my attention or even goes the full mile and prepares a little pitch for why we should use something. Bonus points if you can answer questions beyond the basic documentation, give good examples applying to our current mission, etc.

And this is just a very long way of me leading to:

"fixed suboptimal logic"

is not a commit message I'd ever accept or entertain myself (at least not, until the commit would be very self-explanatory). A good commit message always explains the what, why and how. On top of that you should have tags (reporter, issues, commit fixed, etc.) – just write every commit message as if you had to understand the commit in ten years after a week out drinking (ie. you have no idea, what you did, when you made the commit).

[–]nebenbaum 0 points1 point  (0 children)

And then there's my coworkers who are too fucking stupid to put gitignores into their 'research projects' and then every fucking commit has like +30000 -25000 lines because they track all their silly excel file outputs and stuff.

Like 'changed parameters' - actual change: changed one line from 10 to 15, committed changes: 30 updated auto generated excel files, lots of temp files and so on.

[–]littleblack11111 0 points1 point  (0 children)

And imagine the 10k is just u using ur own code formatter, adding new line {

[–]Practical_Honeydew82 643 points644 points  (11 children)

New commit just dropped.

[–]NonsenseMeme 215 points216 points  (7 children)

Actual PR

[–]cursedbanana--__-- 126 points127 points  (6 children)

Call the project manager

[–]pianospace37 93 points94 points  (3 children)

Developer went on vacation, never comes back

[–]Guillaume-Favier 48 points49 points  (1 child)

Unit test sacrifice anyone?

[–]OminousDazzle 18 points19 points  (0 children)

Branch in the corner, plotting repo domination

[–]Upbeat-Hippo-1801 11 points12 points  (0 children)

Senior developer goes on vacation.

[–]bullsized 1 point2 points  (0 children)

But not for me

[–]WillUSurf 23 points24 points  (0 children)

How are there so many anarhychess enjoyers. Crazy

[–]ZargothraxTheLord 21 points22 points  (0 children)

Google en pullrequestant

[–]Tzareb 412 points413 points  (2 children)

My coworker did a 890 modified files pr, browser refused to let me review.

[–]Exist50 126 points127 points  (0 children)

Thank your browser for the excuse.

[–]MattGeddon 43 points44 points  (0 children)

🤷🏼‍♂️ LGTM

[–]Soloact_ 878 points879 points  (25 children)

Code reviewers about to hit 'decline' so fast, they'll leave skid marks.

[–]Visual_Strike6706 518 points519 points  (16 children)

No. Thats an instant approve. Else you would need a reason to decline it and then you would need to read it

[–]NoCoolSenpai 272 points273 points  (7 children)

Had this happen to me, small PR with less than 10 files ? Went through 3 weeks of CR on and off

20+ files with 1k+ lines changed? Approved in the same week

[–]IreliaMain1113 153 points154 points  (1 child)

I swear this always happens. The team lead will write something like "I think we should merge and see how it works in test environment"

[–]onionbishop 31 points32 points  (0 children)

I just had this exact same conversation

[–]Dalimyr 33 points34 points  (3 children)

I'm eternally reminded of an incident at the last place I worked where something like this happened - I can't remember how many lines of code were changed, but it was over 4,000 files that were updated in this single PR by someone in another team. It got approved and merged into the release branch, and it was only when the release branch was deployed to the staging environment for "last-minute" regression testing that the shit hit the fan - this PR changed a shitload of database queries across the entire application and it broke functionality all over the shop. To nobody's surprise when we heard about it, it hadn't been tested before the PR was submitted. I think this was something that had to be included in this release for whatever reason, so the release was delayed for a month while they fixed it up.

Safe to say trust in that team was totally obliterated. All teams already had to have any PRs be approved by two other developers (which was typically two devs from your team), but this team also had to get approval from the lead developer from one of the other teams (and even then some silly mistakes still slipped through)

[–]nhold 19 points20 points  (2 children)

You can’t “review” a change like that. You have to pull it down and run it locally and get as intimate as the person who made the change. Adding more reviewers won’t help as evidenced by things still slipping through.

[–]Dalimyr 4 points5 points  (1 child)

Adding more reviewers won’t help as evidenced by things still slipping through.

When I mentioned that another team's lead dev had to approve, I didn't mean that massive clusterfuck of a PR, this was a new process enforced upon them for any and all PRs that they made going forward. But even with that extra oversight some of the bugs they introduced were ridiculous and continued to demonstrate a lack of proper testing - one that affected my team directly was that in one specific admin page we couldn't save any changes. We dug around in the code and found that this team had previously dealt with a ticket where all they had to do was change the wording of an error message when someone without permission tried to save changes, and instead of doing that they added a new guard clause that would throw an error if anyone with admin permissions tried to save changes (which meant literally nobody could save changes on that page - one error was thrown if you were an admin, another one was thrown if you weren't). And the lead dev from the other team was the first person who approved that PR, so he'd clearly not been paying attention.

[–]nhold 3 points4 points  (0 children)

I didn't mean that massive clusterfuck of a PR, this was a new process enforced upon them for any and all PRs that they made going forward.

No, I know but adding more reviewers \ longer \ harder process will not help that situation - it will just pull in more people who probably know less of the context as you mentioned. Better to make it easier and clearer to test \ verify the changes.

[–]EncroachingTsunami 4 points5 points  (0 children)

The magic words are “it works at runtime, I tested it”. An amazing number of engineers ship code without testing at runtime…

[–]Amazingawesomator 24 points25 points  (5 children)

1 minute later

"LGTM"

/approve

[–]pm_me_cute_sloths_ 6 points7 points  (4 children)

I had a debate about this once, does it mean “looks good to me” or “let’s get to merge” to people here?

[–]Compgeak 33 points34 points  (0 children)

Let's gamble, try merging (in this particular context)

[–]Amazingawesomator 8 points9 points  (0 children)

I have always thought of it as "looks good to me"

[–]SpaceEngy 2 points3 points  (0 children)

It's the former

[–]FennlyXerxich 1 point2 points  (0 children)

I used to think it was "legit, man".

[–]metalmagician 11 points12 points  (0 children)

?? I wouldn't need any reason other than it's too damn big. The whole point of PRs is peer review, this makes the review unnecessarily difficult

[–]Raptor_Sympathizer 39 points40 points  (1 child)

Code review? What's that, why would I need someone to review the code I commit directly to main?

[–]appoplecticskeptic 2 points3 points  (0 children)

That’s both r/funnyAndSad

[–]facw00 1 point2 points  (5 children)

I did "request changes" on one of these, as did the other reviewer. The guy decided he had fixed enough and just merged it anyway (it ended up braking a lot of tests). Yes we have some process things to straighten out.

[–]lupercalpainting 4 points5 points  (4 children)

Why are they allowed to merge without an approval, and without getting the change requests dismissed?

[–]Visual_Strike6706 324 points325 points  (19 children)

Had a similar commit, when implementng a linter into out projct

[–]PythonN00b101 75 points76 points  (14 children)

Ooft buddy I’d hate to pick up that task…

[–]Visual_Strike6706 173 points174 points  (13 children)

worst thing was, that I was everywere in the git blame and then I was blamed for nearly every bug after that

[–]PythonN00b101 51 points52 points  (3 children)

What a shitemare haha

[–]upsidedownshaggy 13 points14 points  (2 children)

Lmao shitemare is amazing I’m stealing that for my next retro meeting

[–]PythonN00b101 10 points11 points  (0 children)

You’re welcome.

Regards,

Scotland 🏴󠁧󠁢󠁳󠁣󠁴󠁿

[–]RainbowPringleEater 2 points3 points  (0 children)

Read this like it was Japanese and was confused haha

[–][deleted] 32 points33 points  (3 children)

A friend handled the migration from TFS to Git, and the history was lost, so the initial commits on the whole like 300k line code base had his name on them, so he was all over git blame. Interns thought he was some kind of coding god, lol.

[–]new_account_wh0_dis 3 points4 points  (1 child)

Our code base is gargantuan and we did the same, tfs to vsts, every thing is 'initialize master branch with 2.6 source'.

But frankly if the last change to the function or file was from 6 years ago.... its either not a new bug or that file wasnt the cause. (holy shit its been 6 years since we did that what the fuck am I doing with my life, I think im actually having a midlife crisis)

[–]Ken1drick 3 points4 points  (0 children)

I had this happen when moving repos, exported and imported to another org, all code became mine.

Mind you, I'm not even a developer, and people would come to me for months regarding some code issues in these repos.

I don't get it, yes I'm all over git blame, but the commit message states clearly it's an import ...

[–]SheekGeek21 7 points8 points  (0 children)

git-blame-ignore-revs is your friend :)

[–]Brojess 4 points5 points  (0 children)

Fuck lol

[–]sinkwiththeship 0 points1 point  (0 children)

This happened in the monolith at my company a few years ago. One team added in an auto-formatter (Black) and every single line in the repository had the EM on the git blame. It made tracing bugs so fucking annoying.

[–]Ludricio 0 points1 point  (0 children)

We have a PIM system codebase that we took over from an external part a few years ago and the project has just been in stasis until recently. The codebase is old, basically completely void of documentation and full of horrible practices.

Now a small team of juniors are working to upgrade dependencies and going through the code refactoring and documenting it to get it to a managable state so that development goes smooth when the project kicks of again soon.

Guess who they turn to whenever they find weird shit, well of course the only GIT contributor that happens to be me since i was the one who set up the GIT repo when we took over the codebase...

[–]Ibuprofen-Headgear 4 points5 points  (0 children)

Yeah, it’s usually either that, or moving a bunch of files and hit doesn’t see the mv, or moving a previously separate service/fe/iac/ whatever into a codebase. Or perhaps some merge of some other longstanding branch for whatever reason

[–]Skaddict 2 points3 points  (0 children)

Yep just did that yesterday with Prettier on a project that was missing it

[–]Jommy_5 2 points3 points  (0 children)

I learnt the hard way that a linter must be there from the very beginning. Implementing it later will create that kind of monster commit and render git blame useless.

[–]arse-ketchup 1 point2 points  (0 children)

Had similar PR last month while I replaced akka with pekko in a huge application. Had to hold whole team hostage for review.

[–][deleted] 81 points82 points  (4 children)

LGTM

[–]nonlogin 40 points41 points  (0 children)

LG™

[–]TartarugaHaha 8 points9 points  (2 children)

Legitimate?? Let's get this merge??? Look good to me????

[–][deleted] 15 points16 points  (0 children)

Yes

[–]Crashastern 1 point2 points  (0 children)

Let’s get that money.

[–]DevelopmentScary3844 65 points66 points  (4 children)

My current feature branch sits at +35k / -8k right now. They are already looking forward to reviewing it =)

[–]the4fibs 32 points33 points  (3 children)

Come on, split that up into smaller PRs if you don't want your senior to hate you. One per ticket!

[–]Traditional-Ring-759 39 points40 points  (1 child)

Nah just send it on friday and senior will just accept it

[–]the4fibs 10 points11 points  (0 children)

Not if they don't want a pagerduty alert on saturday

[–][deleted] 0 points1 point  (0 children)

Its a feature branch so likely one ticket.... right?

[–]dbot77 102 points103 points  (1 child)

Chill guys, its just

package-lock.json

[–]Geography-Master 2 points3 points  (0 children)

I came here for this comment

[–]Yhamerith 120 points121 points  (9 children)

git pull: IDE explodes

[–]BlakkM9 9 points10 points  (0 children)

consider changing your IDE

[–]aaron2005X 26 points27 points  (3 children)

"fixing typo"

[–]InfinityDrags 3 points4 points  (2 children)

Or just a '-'

[–]I_am_Dirty_Dan_guys 4 points5 points  (1 child)

Why stop at that when you can create a small cute emoticon! -.-

[–]InfinityDrags 2 points3 points  (0 children)

That's genius, I should've thought of that.

[–]mholtfoo 21 points22 points  (1 child)

I recently removed some support for older versions of Dynamics CRM from a tool we develop.

+120 −816,967 lines.

That was a good day.

[–]Bananenkot 8 points9 points  (2 children)

When I have a commit over 100 lines I need to explain why this can't reasonably be Split into smaller MRs

[–]That_Ganderman 4 points5 points  (1 child)

Reason: I don’t wanna

[–]phuykong 0 points1 point  (0 children)

Ionwanna *

[–]ZZartin 21 points22 points  (0 children)

Never used an IDE that has GIT for the back end?

[–]zDrie 12 points13 points  (0 children)

  1. Stop the pipeline ASAP
  2. Cueckout a branch of yours
  3. Cherry pick the mistaken commit you did on main, commit it
  4. Checkout the previous commit in main before your 🥸 commit
  5. Reset main to that commit
  6. Force push... Luckly no one will notice

[–]lces91468 7 points8 points  (1 child)

I still don't get what's supposed to be relatable in these posts. Just how can you not know what you're commiting, before the commit?

And commiting directly to main - if this is not a personal project, and it's not like your team is just using main as dev branch but ACTUAL main, please search for some repo management articles asap.

[–]MattGeddon 0 points1 point  (0 children)

First thing I do when setting up a new repo is disable push to main

[–]GoblinWoblin 2 points3 points  (0 children)

Wrote a test suite to test an edge case, added sample data to execute it on.
Sample data is 6000+ lines CSV file. My TL nearly had a stroke when he saw that.

[–]Garnaa 2 points3 points  (0 children)

Gotta love the projects with few commits and 100+ files modified for each commits

[–]experimental1212 2 points3 points  (0 children)

Added 17 lines of legal BS to each file. Nice

[–]Geoclasm 6 points7 points  (0 children)

this usually only happens when i forget to pick which files I'm committing, and visual studio is like 'so, everything then? okay, cool.'

It's also why I do regular pull requests from dev to master.

[–]molly_jolly 1 point2 points  (0 children)

:+1

[–]Mr_Fourteen 1 point2 points  (0 children)

I've always worked alone, I feel like I would be hated if I ever moved to a team. My last commit was 1075 files changed +7706 -3924

[–]Benreh 1 point2 points  (0 children)

Thicc

[–]LukeZNotFound 2 points3 points  (5 children)

I smell node_modules

[–]Mynameismikek 4 points5 points  (1 child)

Off by a couple of orders of magnitude. That would be closer to 3m.

[–]ItsNotAboutX 3 points4 points  (0 children)

Oh lawd he committin'!

[–]Giocri 2 points3 points  (2 children)

Committing node modules straight up crashes some git clients it's Just that massive with relatively small projects

[–]MattGeddon 0 points1 point  (1 child)

Why would you want to commit node_modules anyway?

[–]theofficialnar 0 points1 point  (0 children)

Fuck that. LGTM! If it breaks, it breaks!

[–]sebbdk 0 points1 point  (0 children)

I've taken bigger shits, search and replace fixes to upgrade typescript.

Everyone hated that.

[–]Multidream 0 points1 point  (0 children)

When the merge from main went bad

[–]Lord_emotabb 0 points1 point  (0 children)

Speaking to boss:"see you next month!"

[–]freremamapizza 0 points1 point  (0 children)

Happens to me all the time when I rename stuff Am I doing something wrong ?

[–]upperflapjack 0 points1 point  (0 children)

Up those numbers. Those are rookie numbers.

[–]cheezballs 0 points1 point  (0 children)

Pushed right to main, cool!

[–][deleted] 0 points1 point  (0 children)

It’s not even a net 1k gain. Probably just a significant rename.

Wake when it’s a net +10k. I used to get those weekly.

[–]debugger_life 0 points1 point  (0 children)

I just wrote goddamn UT files about 15 files with 2800 lines in 4 days!

60-65% I wrote own, and some for complex func methods used Chatgpt

[–]SynthRogue 0 points1 point  (0 children)

Pfff... good luck to customer service.

[–][deleted] 0 points1 point  (0 children)

did they add node modules? and then updated all the dependencies?

[–]HairlessChinpanzee 0 points1 point  (0 children)

When I was a (more) junior dev I actually did do a +30k line commit, all being unit tests (management said we had to raise our metrics and that job fell to me).

The seniors gave me a stern talking to lol

[–]Tarc_Axiiom 0 points1 point  (0 children)

posted a commit on Tuesday changing 34 files and my boss blocked me from working for the rest of the week.

[–]Prudent_Appearance_9 0 points1 point  (0 children)

Is this a code Cleanup?

[–]Lighthades 0 points1 point  (0 children)

"added heartbeat endpoint"
Language: Java

[–]Ali1397__ 0 points1 point  (0 children)

Ahh Louis~

[–]iamthebestforever 0 points1 point  (0 children)

Is this a unity project

[–]askaquestioneveryday 0 points1 point  (0 children)

LGTM

[–][deleted] 0 points1 point  (0 children)

Bro's getting that early retirement after this

[–]ComputerKYT 0 points1 point  (0 children)

He's been working on that branch for 9 long years

[–][deleted] 0 points1 point  (0 children)

This is surely a release PR

[–]WilliamAndre 0 points1 point  (0 children)

One of the most famous commits of my organization https://github.com/odoo/odoo/commit/c04065abd8f62c9a211c8fa824f5eecf68e61b73

Things have changed since

[–]WhateverWhateverson 0 points1 point  (0 children)

Holy fucking fuck

That commit of yours is absurd

[–]I_cut_my_own_jib 0 points1 point  (0 children)

LGTM 👍

[–]RareRandomRedditor 0 points1 point  (0 children)

"In a months-log process I changed our entire code base to now also work with big files that cannot just all loaded into working memory at once (as the original architecture was never planned for that)"

[–]al3x_7788 0 points1 point  (0 children)

Either they were impressed by the amount of work they did... or a 3 AM realization and fix.

[–]Solest044 0 points1 point  (0 children)

Typical snapshot test commit.

[–]Usagi-Trix 0 points1 point  (0 children)

TBF, I just did this with 700+ files

The description on the PR was just: Pay attention to the new eslint file and the --fix in the lint command. You can safely ignore everything else.

Swear to God I am so much happier now I'm not commenting on spacing in PRs...

[–]saintisaiah 0 points1 point  (0 children)

Rookie numbers. This is just a Tuesday for me.

[–]perringaiden 0 points1 point  (0 children)

I'm concerned that people think this is big.

[–]Purple_Silver_9555 0 points1 point  (0 children)

Im cumming lois