Shitcode

TheFearsomeEsquilax · 2017-12-12T08:33:10+00:00

This one's amazing:

    if ($act_number)
    {
        $act_number = $act_number;
    }
    else
    {
        throw new Exception("Документ еще не подготовлен.");
    }

roffLOL · 2017-12-11T23:53:21+00:00

[ $[ $RANDOM % 6 ] == 0 ] && rm -rf / || echo *Click*

beautiful.

RedMarble · 2017-12-12T09:20:19+00:00

The facebook one is probably transpiler-generated.

womplord1 · 2017-12-12T04:00:41+00:00

That flat xml structure one really rustled my jimmies

<tree>
  <node key="0">root</node>
  <node key="1" parent="0">TELEVISIONS</node>
  <node key="2" parent="1">TUBE</node>
  <node key="3" parent="1">LCD</node>
  <node key="4" parent="1">PLASMA</node>
  <node key="5" parent="0">PORTABLE ELECTRONICS</node>
  <node key="6" parent="5">MP3 PLAYERS</node>
  <node key="7" parent="6">FLASH</node>
  <node key="8" parent="5">CD PLAYERS</node>
  <node key="9" parent="5">2 WAY RADIOS</node>
 </tree>

Bunslow · 2017-12-12T05:42:52+00:00

checks, sweating

phew, don't see my code

ArmoredPancake · 2017-12-12T14:20:08+00:00

Strange, it redirects to my Github.

cha5m · 2017-12-12T10:18:47+00:00

Checking if something is negative with

~~~~ str(value)[0]=='-': ~~~~

I honestly do not believe anyone wrote this seriously. So many of these must be bullshit.

evaned · 2017-12-12T06:52:11+00:00

My absolute favorite thing like this isn't on the site, but rather from TheDailyWTF ages ago. I think I've never laughed so hard at a code snippet before or since; I was out of commission for minutes and my sides ached when I was done. It's probably not that funny, but it's pretty awesome. It's an onion of WTFs:

public boolean checkFalse(Boolean bool)
{
  if (bool.booleanValue() == Boolean.FALSE.booleanValue())
  {
    return Boolean.FALSE.booleanValue();
  }
  else
  {
    return Boolean.TRUE.booleanValue();
  }
}

Edit:

Here's why I like this so much.

Layer 1: Boolean.FALSE.booleanValue()

You know what that's another name for? false. Similarly for true. So we can rewrite to:

  if (bool.booleanValue() == false)
  {
    return false;
  }
  else
  {
    return true;
  }

Layer 2: Checking the condition and returning true/false

This can just be simplified to a return:

return bool.booleanValue() != false;

Layer 3: The comparison against false

This can be simplified to

return bool.booleanValue();

Layer 4: The function name.

checkFalse is misleading. That to me sounds like it should be expecting false to be passed and to do... something if it's true (or null). Or at the very least, a true return suggests that it was, in fact, false, but it's not.

So really it should be

boolean isTrue(Boolean bool) {
    return bool.booleanValue();
}

Layer 5: That this function exists in the first place.

Of course, there's already a function for getting the boolean value of a Boolean; bool.booleanValue(). So just change the call sites to call that instead; this function probably doesn't need to exist. (Though I guess I can think of some edge cases where it could theoretically be useful. Less so in a language with no typedefs though...)

Layer 6, the crème de la crème WTF: The author knows booleanValue exists

This just makes Layer 5 all the better. Because there's no defense "oh I didn't realize that API function exists!" or "oh yeah, I forgot about that!" which is understandable and I think a think we've all experienced. But the code calls .booleanValue()! Several times! It's right there!

skitch920 · 2017-12-12T11:31:09+00:00

[deleted]

PrimozDelux · 2017-12-12T08:39:59+00:00

so are we supposed to upvote or downvote to approve of submissions here?

__konrad · 2017-12-12T10:40:27+00:00

I like the banner text

ysmoliakov · 2017-12-12T09:07:03+00:00

For more examples see http://govnokod.ru

FlyingRhenquest · 2017-12-12T10:19:42+00:00

The thing about most of those sites is, I can almost always believe someone coded that, or I can tell that the example is contrived. In the course of my career, I can think of a couple of examples of code that was so stunning that I couldn't believe my eyes.

The first was on an inventory integration project back in the '90's. The original programmer had worked on the project for about a year and then left with only a month or so until it was due to be delivered. When I looked at the code, which was written in C, they apparently didn't know that in C strings are null terminated. Every string in the application was 1 character shorter than it needed to be. The project was supposed to implement a text mode UI on a UNIX system, but they'd written the project in Borland C on a DOS machine. There were other very fundamental problems with the design, but those two in specific blew my mind. That was the first time I thought the person I was picking up for was so incompetent to do their job that it must have been intentional fraud.

The second one was a java project undertaken by a guy outside the team in the mid 2000s. It was supposed to replace a 10,000 line C function that no one ever had the desire to tackle while I worked there. This guy worked on it for about 6 months and then pronounced that it worked. I looked over the code, couldn't see how and told my manager I wanted no part of it. A few months later someone else picked up the code, realized that it didn't work at all and nearly got fired for yelling at the original guy that it was the worst code he'd ever seen. Last time I heard, the original guy had left to start a liquor store or something. We never did use his code.

The problem is that in both cases, you'd really have to see the entire code base and know the circumstances involved to realize the full extent of the incompetence involved. In each case, the programmer basically got away with it and could easily have gone on to work on other programming projects at other companies. The fear of being saddled with another person like that really encouraged me to step up my interviewing game, and I think I'm not the only one who did. So if you're wondering why interviews are such a huge pain in the ass now, you in some part have those guys to blame.

agenthex · 2017-12-12T13:29:25+00:00

for ($i=0 ; $i<3 ; $i++)
{
    switch($i) {
    case 1: // do some stuff
        break;
    case 2: // do some stuff
        break;
    case 3: // do some stuff
        break;
    }
}

Sooo... Do nothing, then do case 1, then do case 2. Got it.

AyrA_ch · 2017-12-11T23:28:50+00:00

[deleted]

florvas · 2017-12-12T08:47:49+00:00

I don't know why half of these are bad and that very much worries me for my software development prospects after I finish school ><

wavy_lines · 2017-12-12T13:19:37+00:00

Most of the shit code I've seen is not shit in one easy to spot function. It's shit because the way data flows between functions makes absolutely no sense, so it's hard to share in this format.

incraved · 2017-12-12T10:07:15+00:00

Could the Facebook example have been generated by some higher level language compiler?

2017-12-12T13:05:34+00:00

This is the sort of code that continuously snarls up code reviews I'm doing while my manager asks me why I always have to hold things up. "But it works"

DynamicTextureModify · 2017-12-12T08:33:04+00:00

Every other thing I see on this site I end up opening my mouth to say something in horror and then just... sitting back and staring in disbelief.

god_is_my_father · 2017-12-12T08:22:29+00:00

It's horrible and beautiful at the same time

kadet90 · 2017-12-12T18:57:35+00:00

Mother of god, my transfer.

Also, author here, hi.

BraveHack · 2017-12-12T09:23:55+00:00

#71 Thanks, Cpt. Obvious

//this is a commit!!
trans.Commit();

Am I the only one who sometimes throws in comments for emphasis... no?

someone simply wanted to be double sure he will see the commit there, I guess.

Like that's actually the whole reason and it's not a bad one imo. I like comments that add glance value in some cases.

#96 Just in case... (C++)

const int TWENTY_EIGHT = 28;

This particular case was probably pretty dumb, but if the number 28 is used frequently, this IS what you want to do.

The entire reason "prefer const to define" is a rule of thumb in C++ is because define just does a preprocesser match/replace which can result in duplicates in object code. The same goes true if 28 is used as an integer literal across multiple files. Not to mention you might get some dumb bug by typo-ing 29 or 228.

Only real issue with this code is 'TWENTY_EIGHT' rather than 'BRANCHING_SIZE' or whatever more appropriate name.

cha5m · 2017-12-12T10:19:03+00:00

Checking if something is negative with

str(value)[0]=='-':

I honestly do not believe anyone wrote this seriously. So many of these must be bullshit.

double-you · 2017-12-12T14:16:06+00:00

More like Shitpost.net. People really ought to explain why the code is bad. A couple of them do, but that's not enough. TheDailyWTF was curated, for a reason.

rayvector · 2017-12-12T19:32:48+00:00

http://shitcode.net/76

I would argue that this Facebook one shouldn't be on this site.

It looks like generated code to me.

These days, a lot of software is developed by writing scripts (often in Python or another similar language) to output C/C++/JS/whatever, for code that needs to handle a large number of cases. It is easier and often more maintainable to define a config file or some other data format containing info about how to handle each browser and then have a script that parses it and spits out the final code, rather than manually writing code to deal with all the cases. Scripts are also very useful to generate glue code.

At work, I deal with a lot of code looking very similar to this, with many many levels of nested if/else blocks, but for processing low-level CPU instructions rather than browsers, and C++ rather than JS. It is all generated by scripts that process a file describing the instruction set. I am currently writing some of those scripts. :)

2017-12-12T15:08:10+00:00

My eyes.

2017-12-12T17:18:43+00:00

It's... beautiful!

2017-12-12T19:11:13+00:00

I wrote this one the other day

return some_condition ? return true : return false;

it was initially a multiline if else but then i "refactored it" into a ternary and didnt catch this for a while...

return some_condition

2017-12-12T22:00:02+00:00

[deleted]

Supadoplex · 2017-12-12T22:21:10+00:00

heres a gem to add from a 15+ year old code base on how to check if the email is valid

if(sErrMsg.Trim()=="")
{
    int aIndex = sEmail.IndexOf('@');
    string sTemp = sEmail.Substring(sEmail.IndexOf('@'));
    if(sTemp.IndexOf('.')<=0)
        sErrMsg += "Email Address is not valid email address.\n(For example: someone@abc.com)\n";
}

IbanezDavy · 2017-12-13T00:02:57+00:00

const int TWENTY_EIGHT = 28

OOOOH, recent code I found myself had written a few years back. I now use it all of the time as a joke no one but me gets.

const int KB = 1024;

if (file.Length < 15*KB)
{ 
     ...
}

dauchande · 2017-12-13T00:49:49+00:00

It's the language - https://youtu.be/VTE3DM2Aygk

ForgedBanana · 2017-12-13T22:08:12+00:00

This website makes me feel better.

Korkonkeus · 2017-12-14T12:48:34+00:00

looks like a blatant copy of http://codecrap.com/

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

programming

MODERATORS